You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/09/23 09:17:30 UTC

[GitHub] [cloudstack-kubernetes-provider] onitake commented on pull request #8: Some fixes for Go 1.13

onitake commented on pull request #8:
URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/8#issuecomment-697241611


   Hi @rhtyd it's actually not necessary to require Go 1.15.
   go.mod should reflect the minimum version required to build the module, which is 1.13. See here: https://golang.org/doc/go1.12#modules
   
   But I'll gladly update the Dockerfile so 1.15 is used for standard builds. Are you ok if I commit this into this PR?
   
   On another note:
   Since Go modules are pretty much the standard now, it would probably be ok to drop the vendored dependencies. What do you think? go.mod and go.sum will ensure the right trees are fetched anyway.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org