You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maka.apache.org by "liuxiaocs7 (via GitHub)" <gi...@apache.org> on 2026/08/30 10:57:48 UTC
[I] CI: 'Check renderer architecture' wedged on main since #4246 (stale ledger) [maka]
liuxiaocs7 opened a new issue, #4257:
URL: https://github.com/apache/maka/issues/4257
## Summary
The `Check renderer architecture` job (CI workflow, `test`) has been failing on `main` — and on every branch cut from it — since **#4246**. The committed `apps/desktop/renderer-architecture.json` ledger records stale metrics for three debt-tracked renderer files whose source drifted after the ledger was last regenerated in #4249, each merging without a paired ledger update.
## Failing check output
```
Renderer architecture check failed:
- src/renderer/app-shell-chat-actions.ts: nonTriviaTokens changed; expected 4363, received 4376
- src/renderer/app-shell-session-events.ts: nonTriviaTokens changed; expected 2931, received 3042
- src/renderer/settings/import-tasks-settings-page.tsx: hookCalls changed; expected {useEffect:4,useRef:3,...}, received {useEffect:5,useRef:5,...}
```
## Timeline
| Commit | PR | Drift | CI |
|---|---|---|---|
| `9ff267510` | #4249 | ledger regenerated, matches source | :white_check_mark: green |
| `bdb103d59` | #4246 | `app-shell-chat-actions.ts` tokens 4363→4376 | :x: **first red** |
| `838936c80` | #4232 | + `app-shell-session-events.ts` tokens 2931→3042 | :x: red |
| `2db04c2b8` | #3905 | + `import-tasks-settings-page.tsx` hookCalls | :x: red |
Each of these three PRs modified a debt-tracked renderer file without running `npm run check:renderer-architecture -- --write`, and their own push CI was already red — yet they still landed on `main`.
## Fix
Regenerate the ledger snapshot so it matches the current source (`--write`). No runtime code changes.
## Follow-up (process)
Worth investigating separately: how three PRs with a failing required `test` check merged into `main`. Consider enforcing the `Check renderer architecture` job as a required status check on the merge queue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org
Re: [I] CI: 'Check renderer architecture' wedged on main since #4246 (stale ledger) [maka]
Posted by "liuxiaocs7 (via GitHub)" <gi...@apache.org>.
liuxiaocs7 commented on issue #4257:
URL: https://github.com/apache/maka/issues/4257#issuecomment-5468265418
Fix up in #4255.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org
Re: [I] CI: 'Check renderer architecture' wedged on main since #4246 (stale ledger) [maka]
Posted by "Astro-Han (via GitHub)" <gi...@apache.org>.
Astro-Han closed issue #4257: CI: 'Check renderer architecture' wedged on main since #4246 (stale ledger)
URL: https://github.com/apache/maka/issues/4257
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org