You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@gobblin.apache.org by GitBox <gi...@apache.org> on 2021/06/14 21:56:08 UTC

[GitHub] [gobblin] aplex commented on a change in pull request #3297: [GOBBLIN-1458] Add endpoint to trigger a flow in GaaS

aplex commented on a change in pull request #3297:
URL: https://github.com/apache/gobblin/pull/3297#discussion_r651303539



##########
File path: gobblin-restli/gobblin-flow-config-service/gobblin-flow-config-service-api/src/main/idl/org.apache.gobblin.service.flowconfigsV2.restspec.json
##########
@@ -79,7 +79,12 @@
       } ]
     } ],
     "entity" : {
-      "path" : "/flowconfigsV2/{id}"
+      "path" : "/flowconfigsV2/{id}",
+      "actions" : [ {
+        "name" : "triggerExecution",

Review comment:
       The action name is a bit strange. What options do we have here? run/start/execute/startFlow/startExecution ... ?
   
   "trigger" is an uncommon way to describe an action in APIs. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org