[GitHub] [hudi] nsivabalan commented on a diff in pull request #8125: [HUDI-5900] Clean up unused metadata configs

["nsivabalan (via GitHub)" <gi...@apache.org>]

nsivabalan commented on code in PR #8125:
URL: https://github.com/apache/hudi/pull/8125#discussion_r1152612841


##########
hudi-common/src/main/java/org/apache/hudi/common/config/HoodieMetadataConfig.java:
##########
@@ -41,6 +41,15 @@
         + " to avoid overhead of accessing cloud storage, during queries.")
 public final class HoodieMetadataConfig extends HoodieConfig {
 
+  // Asynchronous cleaning for metadata table is disabled by default
+  public static final boolean DEFAULT_METADATA_ASYNC_CLEAN = false;
+  // Full scanning of log files while reading log records is enabled by default for metadata table
+  public static final boolean DEFAULT_ENABLE_FULL_SCAN_LOG_FILES = true;
+  // Meta fields are not populated by default for metadata table
+  public static final boolean DEFAULT_POPULATE_META_FIELDS = false;
+  // Default number of commits to retain, without cleaning, on metadata table
+  public static final int DEFAULT_CLEANER_COMMITS_RETAINED = 3;

Review Comment:
   can we prefix "DEFAULT_METADATA" to all variables like how we have done for DEFAULT_METADATA_ASYNC_CLEAN. when used in other places, when variable alone is used, its not very apparent whether its data table defalt or MDT default 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org