You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2017/11/16 02:58:32 UTC

[GitHub] eric-haibin-lin commented on a change in pull request #8662: 2bit gradient compression

eric-haibin-lin commented on a change in pull request #8662: 2bit gradient compression
URL: https://github.com/apache/incubator-mxnet/pull/8662#discussion_r151310992
 
 

 ##########
 File path: tests/nightly/test_kvstore.py
 ##########
 @@ -55,10 +60,160 @@ def test_kvstore(kv_type):
             err = sum(err) / np.sum(np.abs(res[j]))
             assert(err < 1e-6), (err, shapes[j])
 
+def test_compress_kvstore(kv_type, compression='2bit', threshold=0.5):
 
 Review comment:
   Is there a test in which you set compression to active/inactive and verify the result? 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services