[jira] [Commented] (SQOOP-1804) Repository Structure + API: Storing/Retrieving the From/To config inputs ( editable/ overrides)

["Sqoop QA bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SQOOP-1804?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14303689#comment-14303689 ] 

Sqoop QA bot commented on SQOOP-1804:
-------------------------------------

Testing file [SQOOP-1804.patch|https://issues.apache.org/jira/secure/attachment/12696233/SQOOP-1804.patch] against branch sqoop2 took 0:00:09.530300.

{color:red}Overall:{color} -1 due to an error

{color:red}ERROR:{color} failed to apply patch (exit code 1):
{code}<stdin>:1533: trailing whitespace.
  
<stdin>:1684: trailing whitespace.
   * 
<stdin>:1881: trailing whitespace.
          + COLUMN_SQIR_CHILD 
<stdin>:1960: trailing whitespace.
  
<stdin>:2155: trailing whitespace.
  
error: repository/repository-common/src/main/java/org/apache/sqoop/repository/common/CommonRepositoryError.java: No such file or directory
error: patch failed: repository/repository-common/src/main/java/org/apache/sqoop/repository/common/CommonRepositoryHandler.java:24
error: repository/repository-common/src/main/java/org/apache/sqoop/repository/common/CommonRepositoryHandler.java: patch does not apply
error: patch failed: repository/repository-common/src/main/java/org/apache/sqoop/repository/common/CommonRepositoryInsertUpdateDeleteSelectQuery.java:75
error: repository/repository-common/src/main/java/org/apache/sqoop/repository/common/CommonRepositoryInsertUpdateDeleteSelectQuery.java: patch does not apply
error: patch failed: repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java:293
error: repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java: patch does not apply
error: patch failed: repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaCreateQuery.java:367
error: repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaCreateQuery.java: patch does not apply
error: patch failed: repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaUpgradeQuery.java:508
error: repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaUpgradeQuery.java: patch does not apply
{code}

{color:green}SUCCESS:{color} Clean was successful

Console output is available [here|https://builds.apache.org/job/PreCommit-SQOOP-Build/1014/console].

This message is automatically generated.

> Repository Structure + API: Storing/Retrieving the From/To config inputs ( editable/ overrides)
> -----------------------------------------------------------------------------------------------
>
>                 Key: SQOOP-1804
>                 URL: https://issues.apache.org/jira/browse/SQOOP-1804
>             Project: Sqoop
>          Issue Type: Sub-task
>            Reporter: Veena Basavaraj
>            Assignee: Veena Basavaraj
>             Fix For: 1.99.5
>
>         Attachments: SQOOP-1804.patch
>
>
> Details of this proposal are in the wiki.
> https://cwiki.apache.org/confluence/display/SQOOP/Delta+Fetch+And+Merge+Design#DeltaFetchAndMergeDesign-Wheretostoretheoutputinsqoop?
> Update: The above highlights the pros and cons of each approach. 
> #4 is chosen, since it is less intrusive, more clean and allows U/Edit per value in the output easily.
> Will use this ticket for more detailed discussion on storage options for the output from connectors
> 1. 
> {code}
> // will have FK to submission
>  public static final String QUERY_CREATE_TABLE_SQ_JOB_OUTPUT_SUBMISSION =
>      "CREATE TABLE " + TABLE_SQ_JOB_OUTPUT + " ("
>      + COLUMN_SQ_JOB_OUT_ID + " BIGINT GENERATED ALWAYS AS IDENTITY (START WITH 1, INCREMENT BY 1), "
>      + COLUMN_SQ_JOB_OUT_KEY + " VARCHAR(32), "
>      + COLUMN_SQ_JOB_OUT_VALUE + " LONG VARCHAR,"
>      + COLUMN_SQ_JOB_OUT_TYPE + " VARCHAR(32),"
>      + COLUMN_SQD_ID + " VARCHAR(32)," // FK to the direction table, since this allows to distinguish output from FROM/ TO part of the job
>    + COLUMN_SQRS_SUBMISSION + " BIGINT, "
>    + "CONSTRAINT " + CONSTRAINT_SQRS_SQS + " "
>      + "FOREIGN KEY (" + COLUMN_SQRS_SUBMISSION + ") "
>        + "REFERENCES " + TABLE_SQ_SUBMISSION + "(" + COLUMN_SQS_ID + ") ON DELETE CASCADE "
> {code}
> 2.
> At the code level, we will define  MOutputType, one of the types can be BLOB as well, if a connector decides to store the value as a BLOB
> {code}
> class JobOutput {
> String key;
> Object value;
> MOutputType type;
> }
> {code}
> 3. 
> At the repository API, add a new API to get job output for a particular submission Id and allow updates on values. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)