You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/05/28 14:47:32 UTC

[GitHub] [shardingsphere] kimmking commented on a change in pull request #5825: optimize rule configuration in orchestration module.

kimmking commented on a change in pull request #5825:
URL: https://github.com/apache/shardingsphere/pull/5825#discussion_r431895664



##########
File path: shardingsphere-control-panel/shardingsphere-orchestration/shardingsphere-orchestration-core/shardingsphere-orchestration-core-configcenter/src/main/java/org/apache/shardingsphere/orchestration/core/configcenter/listener/SchemaChangedListener.java
##########
@@ -109,7 +108,7 @@ private ShardingOrchestrationEvent createUpdatedEvent(final String shardingSchem
     }
     
     private ShardingOrchestrationEvent createUpdatedEventForExistedSchema(final DataChangedEvent event, final String shardingSchemaName) {
-        return event.getKey().equals(configurationNode.getDataSourcePath(shardingSchemaName)) 
+        return event.getKey().equals(configurationNode.getDataSourcePath(shardingSchemaName))

Review comment:
       it's better to try these functions work well via a real zk.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org