[GitHub] andrzej-kaczmarek opened a new pull request #224: Update handling of package-level build profiles

[GitBox <gi...@apache.org>]

andrzej-kaczmarek opened a new pull request #224: Update handling of package-level build profiles
URL: https://github.com/apache/mynewt-newt/pull/224
 
 
   This fixes two issues with build profiles defined on package-level:
   
   1. Build profile specified for package on target level should take precedence over build profile specified by package itself.
   Not sure why this was implemented the other way around (perhaps there was some reason so my fix may break something) but I think this should works the same way as syscfg where target can ultimately override any other settings. Consider following case: package specified build profile which is heavily optimized, but I would like to debug it so I prefer to override this easily in target instead of changing package definition directly.
   
   2. Target build profile should be used if overridden build profile is not supported by compiler
   Currently, if package has build profile overridden to something that is not supported by compiler we'll just have default error message which states, that target build profile is not supported by compiler:
   ```
   Error: Compiler doesn't support build profile specified by target on this OS (build_profile="foo" OS="linux")
   ```
   This is confusing since it does not state what actually failed. Instead, let's just emit a more verbose warning and use target build profile instead:
   ```
   2018/10/17 12:10:20.028 [WARNING] Unsupported build profile for package, using default build profile (pkg="@apache-mynewt-core/hw/drivers/rtt" build_profile="foo" OS="linux")
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services