You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@kvrocks.apache.org by GitBox <gi...@apache.org> on 2022/10/11 16:10:05 UTC

[GitHub] [incubator-kvrocks] torwig commented on a diff in pull request #973: Add `UniqueFD` and `ScopeExit`

torwig commented on code in PR #973:
URL: https://github.com/apache/incubator-kvrocks/pull/973#discussion_r992527924


##########
src/replication.cc:
##########
@@ -748,9 +749,9 @@ Status ReplicationThread::parallelFetchFile(const std::string &dir,
           if (!s.IsOK()) {
             return Status(Status::NotOK, "connect the server err: " + s.Msg());
           }
+          UniqueFD unique_fd{sock_fd};
           s = this->sendAuth(sock_fd);

Review Comment:
   I think the `this` keyword can be omitted.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org