You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Andrzej Jarmoniuk (Jira)" <ji...@apache.org> on 2022/10/07 15:45:00 UTC

[jira] [Updated] (MNG-7559) ComparableVersion vs versions with custom qualifiers

     [ https://issues.apache.org/jira/browse/MNG-7559?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andrzej Jarmoniuk updated MNG-7559:
-----------------------------------
    Description: 
Since I know that ComparableVersion was brought to Maven from versions-maven-plugin, it turns out the bug described here:

https://github.com/mojohaus/versions-maven-plugin/issues/744

also exists in maven, at least in 3.8.3.

According to the maven version spec, versions containing a qualifier should be treated as less major than the same versions without the qualifier. 

Currently it's only the case for a few "standard" qualifiers, e.g. "-rc*", "-alpha", etc.

However, it looks like "2.3-pfd" is deemed less major than "2.3".

{code:java}
    @Test
    public void testComparableVersionWithCustomQualifier()
    {
        assertThat( new ComparableVersion( "2.3" ).compareTo( new ComparableVersion( "2.3-pfd" ) ),
                greaterThan( 0 ) );
    }
{code}

  was:
Since I know that ComparableVersion was brought to Maven from versions-maven-plugin, it turns out the bug described here:

https://github.com/mojohaus/versions-maven-plugin/issues/744

also exists in maven, at least in 3.8.3.

According to the maven version spec, versions containing a qualifier should be treated as less major than the same versions without the qualifier. 

Currently it's only the case for a few "standard" qualifiers, e.g. "-rc*", "-alpha", etc.

However, it looks like "2.3-pfd" is deemed as less major than "2.3".

{code:java}
    @Test
    public void testComparableVersionWithCustomQualifier()
    {
        assertThat( new ComparableVersion( "2.3" ).compareTo( new ComparableVersion( "2.3-pfd" ) ),
                greaterThan( 0 ) );
    }
{code}


> ComparableVersion vs versions with custom qualifiers
> ----------------------------------------------------
>
>                 Key: MNG-7559
>                 URL: https://issues.apache.org/jira/browse/MNG-7559
>             Project: Maven
>          Issue Type: Bug
>    Affects Versions: 3.8.3
>            Reporter: Andrzej Jarmoniuk
>            Priority: Major
>
> Since I know that ComparableVersion was brought to Maven from versions-maven-plugin, it turns out the bug described here:
> https://github.com/mojohaus/versions-maven-plugin/issues/744
> also exists in maven, at least in 3.8.3.
> According to the maven version spec, versions containing a qualifier should be treated as less major than the same versions without the qualifier. 
> Currently it's only the case for a few "standard" qualifiers, e.g. "-rc*", "-alpha", etc.
> However, it looks like "2.3-pfd" is deemed less major than "2.3".
> {code:java}
>     @Test
>     public void testComparableVersionWithCustomQualifier()
>     {
>         assertThat( new ComparableVersion( "2.3" ).compareTo( new ComparableVersion( "2.3-pfd" ) ),
>                 greaterThan( 0 ) );
>     }
> {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)