[GitHub] [spark] allisonwang-db commented on a diff in pull request #38660: [SPARK-40199][SQL][WIP] Provide useful error when encountering null values in non-null fields

[GitBox <gi...@apache.org>]

allisonwang-db commented on code in PR #38660:
URL: https://github.com/apache/spark/pull/38660#discussion_r1038557594


##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Expression.scala:
##########
@@ -117,6 +117,7 @@ abstract class Expression extends TreeNode[Expression] {
   lazy val deterministic: Boolean = children.forall(_.deterministic)
 
   def nullable: Boolean
+  def trustNullability: Boolean = true

Review Comment:
   I might be missing some context but why do we need a new field `trustNullability`? Can't we simply use `nullable` and maybe add a flag to enforce the nullability of UDFs?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org