You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/07/04 08:52:02 UTC

[GitHub] [skywalking] Ax1an commented on a change in pull request #5028: Fix no data bug of oap self observability instance_metrics_second_aggregation metrics.

Ax1an commented on a change in pull request #5028:
URL: https://github.com/apache/skywalking/pull/5028#discussion_r449754155



##########
File path: oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/analysis/worker/MetricsAggregateWorker.java
##########
@@ -69,7 +69,7 @@
                                                           .getService(MetricsCreator.class);
         aggregationCounter = metricsCreator.createCounter(
             "metrics_aggregation", "The number of rows in aggregation",
-            new MetricsTag.Keys("metricName", "level", "dimensionality"), new MetricsTag.Values(modelName, "1", "min")
+            new MetricsTag.Keys("metricName", "level", "dimensionality"), new MetricsTag.Values(modelName, "1", "minute")

Review comment:
       Keep code style uniform.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org