You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "emmenlau (via GitHub)" <gi...@apache.org> on 2023/10/12 12:54:00 UTC

[PR] Do not install `FindLibevent.cmake` when libevent is disabled [thrift]

emmenlau opened a new pull request, #2868:
URL: https://github.com/apache/thrift/pull/2868

   When libevent is not used, the script `FindLibevent.cmake` may be confusing to downstream projects. Do not install it.
   
   - [ ] Did you create an [Apache Jira](https://issues.apache.org/jira/projects/THRIFT/issues/) ticket?  ([Request account here](https://selfserve.apache.org/jira-account.html), not required for trivial changes)
   - [ ] If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"?
   - [x] Did you squash your changes to a single commit?  (not required, but preferred)
   - [x] Did you do your best to avoid breaking changes?  If one was needed, did you label the Jira ticket with "Breaking-Change"?
   - [x] If your change does not involve any code, include `[skip ci]` anywhere in the commit message to free up build resources.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@thrift.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Do not install `FindLibevent.cmake` when libevent is disabled [thrift]

Posted by "emmenlau (via GitHub)" <gi...@apache.org>.
emmenlau commented on PR #2868:
URL: https://github.com/apache/thrift/pull/2868#issuecomment-1761067779

   Build system problems are unrelated, merging.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Do not install `FindLibevent.cmake` when libevent is disabled [thrift]

Posted by "emmenlau (via GitHub)" <gi...@apache.org>.
emmenlau merged PR #2868:
URL: https://github.com/apache/thrift/pull/2868


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@thrift.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org