You are viewing a plain text version of this content. The canonical link for it is here.
Posted to mapreduce-issues@hadoop.apache.org by "Todd Lipcon (JIRA)" <ji...@apache.org> on 2010/12/19 04:50:01 UTC
[jira] Created: (MAPREDUCE-2224) Synchronization bugs in JvmManager
Synchronization bugs in JvmManager
----------------------------------
Key: MAPREDUCE-2224
URL: https://issues.apache.org/jira/browse/MAPREDUCE-2224
Project: Hadoop Map/Reduce
Issue Type: Bug
Components: tasktracker
Affects Versions: 0.22.0
Reporter: Todd Lipcon
Assignee: Todd Lipcon
Priority: Critical
Fix For: 0.22.0
JvmManager.JvmManagerForType has several HashMap members that are inconsistently synchronized. I've seen sporadic NPEs in the 0.20 version of this code which has similar bugs.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (MAPREDUCE-2224) Synchronization bugs in
JvmManager
Posted by "Scott Chen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12975349#action_12975349 ]
Scott Chen commented on MAPREDUCE-2224:
---------------------------------------
+1 Looks good.
Todd: Can you run ant test and post it here? I think Hudson doesn't work.
> Synchronization bugs in JvmManager
> ----------------------------------
>
> Key: MAPREDUCE-2224
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2224
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: tasktracker
> Affects Versions: 0.22.0
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Priority: Critical
> Fix For: 0.22.0
>
> Attachments: mapreduce-2224-cdh3.txt, mapreduce-2224.txt, mapreduce-2224.txt, mapreduce-2224.txt, mapreduce-2224.txt
>
>
> JvmManager.JvmManagerForType has several HashMap members that are inconsistently synchronized. I've seen sporadic NPEs in the 0.20 version of this code which has similar bugs.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (MAPREDUCE-2224) Synchronization bugs in
JvmManager
Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12973362#action_12973362 ]
Todd Lipcon commented on MAPREDUCE-2224:
----------------------------------------
Good call, let me look into that.
> Synchronization bugs in JvmManager
> ----------------------------------
>
> Key: MAPREDUCE-2224
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2224
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: tasktracker
> Affects Versions: 0.22.0
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Priority: Critical
> Fix For: 0.22.0
>
> Attachments: mapreduce-2224-cdh3.txt, mapreduce-2224.txt, mapreduce-2224.txt
>
>
> JvmManager.JvmManagerForType has several HashMap members that are inconsistently synchronized. I've seen sporadic NPEs in the 0.20 version of this code which has similar bugs.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (MAPREDUCE-2224) Synchronization bugs in JvmManager
Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2224?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Todd Lipcon updated MAPREDUCE-2224:
-----------------------------------
Status: Patch Available (was: Open)
> Synchronization bugs in JvmManager
> ----------------------------------
>
> Key: MAPREDUCE-2224
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2224
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: tasktracker
> Affects Versions: 0.22.0
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Priority: Critical
> Fix For: 0.22.0
>
> Attachments: mapreduce-2224-cdh3.txt, mapreduce-2224.txt, mapreduce-2224.txt
>
>
> JvmManager.JvmManagerForType has several HashMap members that are inconsistently synchronized. I've seen sporadic NPEs in the 0.20 version of this code which has similar bugs.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] [Commented] (MAPREDUCE-2224) Synchronization bugs in
JvmManager
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13016924#comment-13016924 ]
Hudson commented on MAPREDUCE-2224:
-----------------------------------
Integrated in Hadoop-Mapreduce-trunk #643 (See [https://hudson.apache.org/hudson/job/Hadoop-Mapreduce-trunk/643/])
> Synchronization bugs in JvmManager
> ----------------------------------
>
> Key: MAPREDUCE-2224
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2224
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: tasktracker
> Affects Versions: 0.22.0
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Priority: Critical
> Fix For: 0.22.0
>
> Attachments: mapreduce-2224-cdh3.txt, mapreduce-2224.txt, mapreduce-2224.txt, mapreduce-2224.txt, mapreduce-2224.txt
>
>
> JvmManager.JvmManagerForType has several HashMap members that are inconsistently synchronized. I've seen sporadic NPEs in the 0.20 version of this code which has similar bugs.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MAPREDUCE-2224) Synchronization bugs in
JvmManager
Posted by "Scott Chen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12973302#action_12973302 ]
Scott Chen commented on MAPREDUCE-2224:
---------------------------------------
Good catch!
I have a question. Is the following part necessary? The method kill() is already synchronized.
{code}
@@ -493,7 +501,9 @@ class JvmManager {
// Check inital context before issuing a kill to prevent situations
// where kill is issued before task is launched.
if (initalContext != null && initalContext.env != null) {
- initalContext.pid = jvmIdToPid.get(jvmId);
+ synchronized (JvmManagerForType.this) {
+ initalContext.pid = jvmIdToPid.get(jvmId);
+ }
{code}
> Synchronization bugs in JvmManager
> ----------------------------------
>
> Key: MAPREDUCE-2224
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2224
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: tasktracker
> Affects Versions: 0.22.0
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Priority: Critical
> Fix For: 0.22.0
>
> Attachments: mapreduce-2224-cdh3.txt, mapreduce-2224.txt, mapreduce-2224.txt
>
>
> JvmManager.JvmManagerForType has several HashMap members that are inconsistently synchronized. I've seen sporadic NPEs in the 0.20 version of this code which has similar bugs.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (MAPREDUCE-2224) Synchronization bugs in JvmManager
Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2224?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Todd Lipcon updated MAPREDUCE-2224:
-----------------------------------
Attachment: mapreduce-2224-cdh3.txt
Attaching backport I did for CDH 20 branch which should also apply on YDH. Includes unit test. Will port unit test forward also
> Synchronization bugs in JvmManager
> ----------------------------------
>
> Key: MAPREDUCE-2224
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2224
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: tasktracker
> Affects Versions: 0.22.0
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Priority: Critical
> Fix For: 0.22.0
>
> Attachments: mapreduce-2224-cdh3.txt, mapreduce-2224.txt
>
>
> JvmManager.JvmManagerForType has several HashMap members that are inconsistently synchronized. I've seen sporadic NPEs in the 0.20 version of this code which has similar bugs.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (MAPREDUCE-2224) Synchronization bugs in JvmManager
Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2224?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Todd Lipcon updated MAPREDUCE-2224:
-----------------------------------
Attachment: mapreduce-2224.txt
Hi Scott. That was a good catch - jcarder confirmed the potential deadlock you saw. Here's a patch which is a bit bigger but should be deadlock free and cleans up some encapsulation issues as well in the process.
> Synchronization bugs in JvmManager
> ----------------------------------
>
> Key: MAPREDUCE-2224
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2224
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: tasktracker
> Affects Versions: 0.22.0
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Priority: Critical
> Fix For: 0.22.0
>
> Attachments: mapreduce-2224-cdh3.txt, mapreduce-2224.txt, mapreduce-2224.txt, mapreduce-2224.txt
>
>
> JvmManager.JvmManagerForType has several HashMap members that are inconsistently synchronized. I've seen sporadic NPEs in the 0.20 version of this code which has similar bugs.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (MAPREDUCE-2224) Synchronization bugs in
JvmManager
Posted by "Scott Chen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12974815#action_12974815 ]
Scott Chen commented on MAPREDUCE-2224:
---------------------------------------
Hi Todd, I like the patch. Just have some minor comments in the review board.
> Synchronization bugs in JvmManager
> ----------------------------------
>
> Key: MAPREDUCE-2224
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2224
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: tasktracker
> Affects Versions: 0.22.0
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Priority: Critical
> Fix For: 0.22.0
>
> Attachments: mapreduce-2224-cdh3.txt, mapreduce-2224.txt, mapreduce-2224.txt, mapreduce-2224.txt
>
>
> JvmManager.JvmManagerForType has several HashMap members that are inconsistently synchronized. I've seen sporadic NPEs in the 0.20 version of this code which has similar bugs.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (MAPREDUCE-2224) Synchronization bugs in JvmManager
Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2224?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Todd Lipcon updated MAPREDUCE-2224:
-----------------------------------
Attachment: mapreduce-2224.txt
Updated patch for trunk to include unit test. Also I had missed one synchronization case which the test found.
> Synchronization bugs in JvmManager
> ----------------------------------
>
> Key: MAPREDUCE-2224
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2224
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: tasktracker
> Affects Versions: 0.22.0
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Priority: Critical
> Fix For: 0.22.0
>
> Attachments: mapreduce-2224-cdh3.txt, mapreduce-2224.txt, mapreduce-2224.txt
>
>
> JvmManager.JvmManagerForType has several HashMap members that are inconsistently synchronized. I've seen sporadic NPEs in the 0.20 version of this code which has similar bugs.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (MAPREDUCE-2224) Synchronization bugs in
JvmManager
Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12973337#action_12973337 ]
Todd Lipcon commented on MAPREDUCE-2224:
----------------------------------------
Hi Scott. Yea, it's necessary, since kill() is synchronized on the inner class. It needs to synchronize on its outer "this" - note that it's {{JvmManagerForType.this}} and not {{this}}
> Synchronization bugs in JvmManager
> ----------------------------------
>
> Key: MAPREDUCE-2224
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2224
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: tasktracker
> Affects Versions: 0.22.0
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Priority: Critical
> Fix For: 0.22.0
>
> Attachments: mapreduce-2224-cdh3.txt, mapreduce-2224.txt, mapreduce-2224.txt
>
>
> JvmManager.JvmManagerForType has several HashMap members that are inconsistently synchronized. I've seen sporadic NPEs in the 0.20 version of this code which has similar bugs.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (MAPREDUCE-2224) Synchronization bugs in
JvmManager
Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12975418#action_12975418 ]
Todd Lipcon commented on MAPREDUCE-2224:
----------------------------------------
[exec] +1 overall.
[exec]
[exec] +1 @author. The patch does not contain any @author tags.
[exec]
[exec] +1 tests included. The patch appears to include 3 new or modified tests.
[exec]
[exec] +1 javadoc. The javadoc tool did not generate any warning messages.
[exec]
[exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings.
[exec]
[exec] +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
[exec]
[exec] +1 release audit. The applied patch does not increase the total number of release audit warnings.
[exec]
[exec] +1 system test framework. The patch passed system test framework compile.
Failed tests:
[junit] Test org.apache.hadoop.mapred.TestControlledMapReduceJob FAILED (timeout)
[junit] Test org.apache.hadoop.mapreduce.lib.db.TestDBJob FAILED (timeout)
[junit] Test org.apache.hadoop.mapreduce.lib.db.TestDataDrivenDBInputFormat FAILED (timeout)
which I believe are all failing on trunk
> Synchronization bugs in JvmManager
> ----------------------------------
>
> Key: MAPREDUCE-2224
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2224
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: tasktracker
> Affects Versions: 0.22.0
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Priority: Critical
> Fix For: 0.22.0
>
> Attachments: mapreduce-2224-cdh3.txt, mapreduce-2224.txt, mapreduce-2224.txt, mapreduce-2224.txt, mapreduce-2224.txt
>
>
> JvmManager.JvmManagerForType has several HashMap members that are inconsistently synchronized. I've seen sporadic NPEs in the 0.20 version of this code which has similar bugs.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] [Updated] (MAPREDUCE-2224) Synchronization bugs in
JvmManager
Posted by "Benoy Antony (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2224?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Benoy Antony updated MAPREDUCE-2224:
------------------------------------
Attachment: mr-2224-0.22.patch
Patch for 0.22
> Synchronization bugs in JvmManager
> ----------------------------------
>
> Key: MAPREDUCE-2224
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2224
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: tasktracker
> Affects Versions: 0.22.0
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Priority: Critical
> Fix For: 0.22.0
>
> Attachments: mapreduce-2224-cdh3.txt, mapreduce-2224.txt, mapreduce-2224.txt, mapreduce-2224.txt, mapreduce-2224.txt, mr-2224-0.22.patch
>
>
> JvmManager.JvmManagerForType has several HashMap members that are inconsistently synchronized. I've seen sporadic NPEs in the 0.20 version of this code which has similar bugs.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MAPREDUCE-2224) Synchronization bugs in
JvmManager
Posted by "Scott Chen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12973347#action_12973347 ]
Scott Chen commented on MAPREDUCE-2224:
---------------------------------------
Hey Todd, Thanks. Got it. I missed that there is this inner class of a inner class of a class.
I have another question.
It seems that now following two code paths will have two different locking sequences for JvmRunner and JvmManagerForType.
Is it possible that this may deadlock?
{code}
JvmManagerForType.killJvmRunner() -> JvmRunner.kill()
JvmRunner.runChild() -> JvmRunner.kill()
{code}
> Synchronization bugs in JvmManager
> ----------------------------------
>
> Key: MAPREDUCE-2224
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2224
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: tasktracker
> Affects Versions: 0.22.0
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Priority: Critical
> Fix For: 0.22.0
>
> Attachments: mapreduce-2224-cdh3.txt, mapreduce-2224.txt, mapreduce-2224.txt
>
>
> JvmManager.JvmManagerForType has several HashMap members that are inconsistently synchronized. I've seen sporadic NPEs in the 0.20 version of this code which has similar bugs.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] [Updated] (MAPREDUCE-2224) Synchronization bugs in
JvmManager
Posted by "Benoy Antony (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2224?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Benoy Antony updated MAPREDUCE-2224:
------------------------------------
Attachment: mr-2224-0.22.patch
Updated the patch to reflect the changes to JvmManager due to MR-2178
> Synchronization bugs in JvmManager
> ----------------------------------
>
> Key: MAPREDUCE-2224
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2224
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: tasktracker
> Affects Versions: 0.22.0
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Priority: Critical
> Fix For: 0.22.0
>
> Attachments: mapreduce-2224-cdh3.txt, mapreduce-2224.txt, mapreduce-2224.txt, mapreduce-2224.txt, mapreduce-2224.txt, mr-2224-0.22.patch, mr-2224-0.22.patch
>
>
> JvmManager.JvmManagerForType has several HashMap members that are inconsistently synchronized. I've seen sporadic NPEs in the 0.20 version of this code which has similar bugs.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MAPREDUCE-2224) Synchronization bugs in JvmManager
Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2224?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Todd Lipcon updated MAPREDUCE-2224:
-----------------------------------
Attachment: mapreduce-2224.txt
new revision from review board
> Synchronization bugs in JvmManager
> ----------------------------------
>
> Key: MAPREDUCE-2224
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2224
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: tasktracker
> Affects Versions: 0.22.0
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Priority: Critical
> Fix For: 0.22.0
>
> Attachments: mapreduce-2224-cdh3.txt, mapreduce-2224.txt, mapreduce-2224.txt, mapreduce-2224.txt, mapreduce-2224.txt
>
>
> JvmManager.JvmManagerForType has several HashMap members that are inconsistently synchronized. I've seen sporadic NPEs in the 0.20 version of this code which has similar bugs.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] [Commented] (MAPREDUCE-2224) Synchronization bugs in
JvmManager
Posted by "Konstantin Shvachko (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13289208#comment-13289208 ]
Konstantin Shvachko commented on MAPREDUCE-2224:
------------------------------------------------
This is already committed to 0.22 and should go into a separate jira.
Created MAPREDUCE-4314 to commit the patch.
> Synchronization bugs in JvmManager
> ----------------------------------
>
> Key: MAPREDUCE-2224
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2224
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: tasktracker
> Affects Versions: 0.22.0
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Priority: Critical
> Fix For: 0.22.0
>
> Attachments: mapreduce-2224-cdh3.txt, mapreduce-2224.txt, mapreduce-2224.txt, mapreduce-2224.txt, mapreduce-2224.txt, mr-2224-0.22.patch, mr-2224-0.22.patch
>
>
> JvmManager.JvmManagerForType has several HashMap members that are inconsistently synchronized. I've seen sporadic NPEs in the 0.20 version of this code which has similar bugs.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MAPREDUCE-2224) Synchronization bugs in
JvmManager
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12975425#action_12975425 ]
Hudson commented on MAPREDUCE-2224:
-----------------------------------
Integrated in Hadoop-Mapreduce-trunk-Commit #564 (See [https://hudson.apache.org/hudson/job/Hadoop-Mapreduce-trunk-Commit/564/])
MAPREDUCE-2224. Fix synchronization bugs in JvmManager. Contributed by Todd Lipcon
> Synchronization bugs in JvmManager
> ----------------------------------
>
> Key: MAPREDUCE-2224
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2224
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: tasktracker
> Affects Versions: 0.22.0
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Priority: Critical
> Fix For: 0.22.0
>
> Attachments: mapreduce-2224-cdh3.txt, mapreduce-2224.txt, mapreduce-2224.txt, mapreduce-2224.txt, mapreduce-2224.txt
>
>
> JvmManager.JvmManagerForType has several HashMap members that are inconsistently synchronized. I've seen sporadic NPEs in the 0.20 version of this code which has similar bugs.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (MAPREDUCE-2224) Synchronization bugs in
JvmManager
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12993909#comment-12993909 ]
Hudson commented on MAPREDUCE-2224:
-----------------------------------
Integrated in Hadoop-Mapreduce-22-branch #33 (See [https://hudson.apache.org/hudson/job/Hadoop-Mapreduce-22-branch/33/])
> Synchronization bugs in JvmManager
> ----------------------------------
>
> Key: MAPREDUCE-2224
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2224
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: tasktracker
> Affects Versions: 0.22.0
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Priority: Critical
> Fix For: 0.22.0
>
> Attachments: mapreduce-2224-cdh3.txt, mapreduce-2224.txt, mapreduce-2224.txt, mapreduce-2224.txt, mapreduce-2224.txt
>
>
> JvmManager.JvmManagerForType has several HashMap members that are inconsistently synchronized. I've seen sporadic NPEs in the 0.20 version of this code which has similar bugs.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MAPREDUCE-2224) Synchronization bugs in
JvmManager
Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12974377#action_12974377 ]
Todd Lipcon commented on MAPREDUCE-2224:
----------------------------------------
review here: https://reviews.apache.org/r/190/diff/#index_header
> Synchronization bugs in JvmManager
> ----------------------------------
>
> Key: MAPREDUCE-2224
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2224
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: tasktracker
> Affects Versions: 0.22.0
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Priority: Critical
> Fix For: 0.22.0
>
> Attachments: mapreduce-2224-cdh3.txt, mapreduce-2224.txt, mapreduce-2224.txt, mapreduce-2224.txt
>
>
> JvmManager.JvmManagerForType has several HashMap members that are inconsistently synchronized. I've seen sporadic NPEs in the 0.20 version of this code which has similar bugs.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (MAPREDUCE-2224) Synchronization bugs in JvmManager
Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2224?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Todd Lipcon updated MAPREDUCE-2224:
-----------------------------------
Attachment: mapreduce-2224.txt
> Synchronization bugs in JvmManager
> ----------------------------------
>
> Key: MAPREDUCE-2224
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2224
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: tasktracker
> Affects Versions: 0.22.0
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Priority: Critical
> Fix For: 0.22.0
>
> Attachments: mapreduce-2224.txt
>
>
> JvmManager.JvmManagerForType has several HashMap members that are inconsistently synchronized. I've seen sporadic NPEs in the 0.20 version of this code which has similar bugs.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (MAPREDUCE-2224) Synchronization bugs in JvmManager
Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2224?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Todd Lipcon updated MAPREDUCE-2224:
-----------------------------------
Resolution: Fixed
Hadoop Flags: [Reviewed]
Status: Resolved (was: Patch Available)
Committed to trunk and branch-22. Thanks for reviewing, Scott.
> Synchronization bugs in JvmManager
> ----------------------------------
>
> Key: MAPREDUCE-2224
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2224
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: tasktracker
> Affects Versions: 0.22.0
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Priority: Critical
> Fix For: 0.22.0
>
> Attachments: mapreduce-2224-cdh3.txt, mapreduce-2224.txt, mapreduce-2224.txt, mapreduce-2224.txt, mapreduce-2224.txt
>
>
> JvmManager.JvmManagerForType has several HashMap members that are inconsistently synchronized. I've seen sporadic NPEs in the 0.20 version of this code which has similar bugs.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.