You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by "Baoyuantop (via GitHub)" <gi...@apache.org> on 2023/03/16 07:08:41 UTC
[GitHub] [apisix-dashboard] Baoyuantop opened a new pull request, #2773: fix: upstream nodes metadata miss
Baoyuantop opened a new pull request, #2773:
URL: https://github.com/apache/apisix-dashboard/pull/2773
Please answer these questions before submitting a pull request, **or your PR will get closed**.
**Why submit this pull request?**
- [x] Bugfix
- [ ] New feature provided
- [ ] Improve performance
- [ ] Backport patches
**What changes will this PR take into?**
Please update this section with detailed description.
**Related issues**
fix/resolve #2661
**Checklist:**
- [ ] Did you explain what problem does this PR solve? Or what new features have been added?
- [ ] Have you added corresponding test cases?
- [ ] Have you modified the corresponding document?
- [ ] Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] codecov-commenter commented on pull request #2773: fix: upstream nodes metadata miss
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #2773:
URL: https://github.com/apache/apisix-dashboard/pull/2773#issuecomment-1471429202
## [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2773?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#2773](https://codecov.io/gh/apache/apisix-dashboard/pull/2773?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (17fc967) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/85fadb6ac29c6cc7fc292af8d6e9f2ef581642be?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (85fadb6) will **decrease** coverage by `26.59%`.
> The diff coverage is `100.00%`.
> :exclamation: Current head 17fc967 differs from pull request most recent head e77cda2. Consider uploading reports for the commit e77cda2 to get more accurate results
```diff
@@ Coverage Diff @@
## master #2773 +/- ##
===========================================
- Coverage 76.50% 49.92% -26.59%
===========================================
Files 139 47 -92
Lines 3763 3437 -326
Branches 881 0 -881
===========================================
- Hits 2879 1716 -1163
- Misses 884 1511 +627
- Partials 0 210 +210
```
| Flag | Coverage Δ | |
|---|---|---|
| backend-unit-test | `49.92% <100.00%> (?)` | |
| frontend-e2e-test | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/2773?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [api/internal/core/entity/format.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2773?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2Zvcm1hdC5nbw==) | `87.71% <100.00%> (ø)` | |
... and [185 files with indirect coverage changes](https://codecov.io/gh/apache/apisix-dashboard/pull/2773/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] Baoyuantop merged pull request #2773: fix: upstream nodes metadata miss
Posted by "Baoyuantop (via GitHub)" <gi...@apache.org>.
Baoyuantop merged PR #2773:
URL: https://github.com/apache/apisix-dashboard/pull/2773
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org