You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/12/30 09:10:21 UTC
[GitHub] [apisix-dashboard] juzhiyuan opened a new pull request #1157: feat(FE): version manager
juzhiyuan opened a new pull request #1157:
URL: https://github.com/apache/apisix-dashboard/pull/1157
Please answer these questions before submitting a pull request
- Why submit this pull request?
- [ ] Bugfix
- [x] New feature provided
- [ ] Improve performance
- Related issues
resolve #823
___
### Bugfix
- Description
- How to fix?
___
### New feature or improvement
- Describe the details and related test reports.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] LiteSun commented on a change in pull request #1157: feat(FE): version manager
Posted by GitBox <gi...@apache.org>.
LiteSun commented on a change in pull request #1157:
URL: https://github.com/apache/apisix-dashboard/pull/1157#discussion_r550255156
##########
File path: web/src/pages/Route/components/Step1/MetaView.tsx
##########
@@ -14,21 +14,88 @@
* See the License for the specific language governing permissions and
* limitations under the License.
*/
-import React, { useState } from 'react';
+import React, { useEffect, useState } from 'react';
import Form from 'antd/es/form';
-import { Input, Switch, Select, Button, Tag } from 'antd';
+import { Input, Switch, Select, Button, Tag, AutoComplete } from 'antd';
import { useIntl } from 'umi';
import { PanelSection } from '@api7-dashboard/ui';
import { FORM_ITEM_WITHOUT_LABEL } from '@/pages/Route/constants';
import LabelsDrawer from './LabelsDrawer';
-
-const DEFAULT_VERSION_LABEL_PREFIX = 'version:';
+import { fetchLabelList } from '../../service';
const MetaView: React.FC<RouteModule.Step1PassProps> = ({ disabled, form, isEdit, onChange }) => {
const { formatMessage } = useIntl();
const [visible, setVisible] = useState(false);
- const [showVersionManager, setShowVersionManager] = useState(false);
+ const [labelList, setLabelList] = useState<RouteModule.LabelList>({});
+
+ useEffect(() => {
+ // TODO: use a better state name
+ fetchLabelList().then(setLabelList);
+ }, []);
+
+ const NormalLabelComponent = () => {
+ const field = 'custom_normal_labels';
+ const title = 'Label Manager';
+
+ return (
+ <React.Fragment>
+ <Form.Item label={formatMessage({ id: 'component.global.labels' })} name={field}>
+ <Select
+ mode="tags"
+ style={{ width: '100%' }}
+ placeholder="--"
+ disabled={disabled}
+ open={false}
+ bordered={false}
+ tagRender={(props) => {
+ const { value, closable, onClose } = props;
+ return (
+ <Tag closable={closable && !disabled} onClose={onClose} style={{ marginRight: 3 }}>
+ {value}
+ </Tag>
+ );
+ }}
+ />
+ </Form.Item>
+ <Form.Item {...FORM_ITEM_WITHOUT_LABEL}>
+ <Button type="dashed" disabled={disabled} onClick={() => setVisible(true)}>
+ {formatMessage({ id: 'component.global.manage' })}
+ </Button>
+ </Form.Item>
+ {visible && (
+ <Form.Item shouldUpdate noStyle>
+ {() => {
+ const labels = form.getFieldValue(field) || [];
+ return (
+ <LabelsDrawer
+ title={title}
+ actionName={field}
+ dataSource={labels}
+ disabled={disabled || false}
+ onChange={onChange}
+ onClose={() => setVisible(false)}
+ />
+ );
+ }}
+ </Form.Item>
+ )}
+ </React.Fragment>
+ );
+ };
+
+ const VersionLabelComponent = () => {
+ return (
+ <React.Fragment>
+ <Form.Item label="版本" name="custom_version_selected_label">
Review comment:
i18n
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1157: feat(FE): version manager
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #1157:
URL: https://github.com/apache/apisix-dashboard/pull/1157#issuecomment-752388306
# [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1157?src=pr&el=h1) Report
> Merging [#1157](https://codecov.io/gh/apache/apisix-dashboard/pull/1157?src=pr&el=desc) (04abe54) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/45d79b674c2f500d76b76939674b6792201a70bb?el=desc) (45d79b6) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/apisix-dashboard/pull/1157?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1157 +/- ##
=======================================
Coverage 42.30% 42.30%
=======================================
Files 31 31
Lines 1924 1924
=======================================
Hits 814 814
Misses 1000 1000
Partials 110 110
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1157?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1157?src=pr&el=footer). Last update [45d79b6...04abe54](https://codecov.io/gh/apache/apisix-dashboard/pull/1157?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1157: feat(FE): version manager
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #1157:
URL: https://github.com/apache/apisix-dashboard/pull/1157#issuecomment-752388306
# [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1157?src=pr&el=h1) Report
> Merging [#1157](https://codecov.io/gh/apache/apisix-dashboard/pull/1157?src=pr&el=desc) (3fc6a93) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/a34317193cece2532ed333aaaacfd3a6af7328c4?el=desc) (a343171) will **increase** coverage by `0.05%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/apisix-dashboard/pull/1157?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1157 +/- ##
==========================================
+ Coverage 42.27% 42.32% +0.05%
==========================================
Files 31 31
Lines 1928 1928
==========================================
+ Hits 815 816 +1
+ Misses 1002 1001 -1
Partials 111 111
```
| [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1157?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [api/internal/core/store/store.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1157/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmUuZ28=) | `80.00% <0.00%> (+0.62%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1157?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1157?src=pr&el=footer). Last update [a343171...8c2b62e](https://codecov.io/gh/apache/apisix-dashboard/pull/1157?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1157: feat(FE): version manager
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #1157:
URL: https://github.com/apache/apisix-dashboard/pull/1157#issuecomment-752388306
# [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1157?src=pr&el=h1) Report
> Merging [#1157](https://codecov.io/gh/apache/apisix-dashboard/pull/1157?src=pr&el=desc) (ecb0c66) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/2d0fcd6e6efd5a5b666099f3b1f5582df34c646b?el=desc) (2d0fcd6) will **decrease** coverage by `0.05%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/apisix-dashboard/pull/1157?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1157 +/- ##
==========================================
- Coverage 42.32% 42.27% -0.06%
==========================================
Files 31 31
Lines 1928 1928
==========================================
- Hits 816 815 -1
- Misses 1001 1002 +1
Partials 111 111
```
| [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1157?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [api/internal/core/store/store.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1157/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmUuZ28=) | `79.37% <0.00%> (-0.63%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1157?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1157?src=pr&el=footer). Last update [2d0fcd6...ecb0c66](https://codecov.io/gh/apache/apisix-dashboard/pull/1157?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io commented on pull request #1157: feat(FE): version manager
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #1157:
URL: https://github.com/apache/apisix-dashboard/pull/1157#issuecomment-752388306
# [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1157?src=pr&el=h1) Report
> Merging [#1157](https://codecov.io/gh/apache/apisix-dashboard/pull/1157?src=pr&el=desc) (22623a3) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/45d79b674c2f500d76b76939674b6792201a70bb?el=desc) (45d79b6) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/apisix-dashboard/pull/1157?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1157 +/- ##
=======================================
Coverage 42.30% 42.30%
=======================================
Files 31 31
Lines 1924 1924
=======================================
Hits 814 814
Misses 1000 1000
Partials 110 110
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1157?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1157?src=pr&el=footer). Last update [45d79b6...22623a3](https://codecov.io/gh/apache/apisix-dashboard/pull/1157?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] LiteSun merged pull request #1157: feat(FE): version manager
Posted by GitBox <gi...@apache.org>.
LiteSun merged pull request #1157:
URL: https://github.com/apache/apisix-dashboard/pull/1157
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1157: feat(FE): version manager
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #1157:
URL: https://github.com/apache/apisix-dashboard/pull/1157#issuecomment-752388306
# [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1157?src=pr&el=h1) Report
> Merging [#1157](https://codecov.io/gh/apache/apisix-dashboard/pull/1157?src=pr&el=desc) (ce42b19) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/83759625db904da3fd06e3462605b2be22408ac5?el=desc) (8375962) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/apisix-dashboard/pull/1157?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1157 +/- ##
=======================================
Coverage 42.32% 42.32%
=======================================
Files 31 31
Lines 1928 1928
=======================================
Hits 816 816
Misses 1001 1001
Partials 111 111
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1157?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1157?src=pr&el=footer). Last update [8375962...ce42b19](https://codecov.io/gh/apache/apisix-dashboard/pull/1157?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #1157: feat(FE): version manager
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on a change in pull request #1157:
URL: https://github.com/apache/apisix-dashboard/pull/1157#discussion_r550353894
##########
File path: web/src/pages/Route/components/Step1/LabelsDrawer.tsx
##########
@@ -108,12 +112,14 @@ const LabelList = (disabled: boolean, labelList: RouteModule.LabelList) => {
};
const LabelsDrawer: React.FC<Props> = ({
- disabled,
- labelsDataSource,
+ title = 'Label Manager',
Review comment:
*i18n
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1157: feat(FE): version manager
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #1157:
URL: https://github.com/apache/apisix-dashboard/pull/1157#issuecomment-752388306
# [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1157?src=pr&el=h1) Report
> Merging [#1157](https://codecov.io/gh/apache/apisix-dashboard/pull/1157?src=pr&el=desc) (8c2b62e) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/a34317193cece2532ed333aaaacfd3a6af7328c4?el=desc) (a343171) will **increase** coverage by `0.05%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/apisix-dashboard/pull/1157?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1157 +/- ##
==========================================
+ Coverage 42.27% 42.32% +0.05%
==========================================
Files 31 31
Lines 1928 1928
==========================================
+ Hits 815 816 +1
+ Misses 1002 1001 -1
Partials 111 111
```
| [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1157?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [api/internal/core/store/store.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1157/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmUuZ28=) | `80.00% <0.00%> (+0.62%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1157?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1157?src=pr&el=footer). Last update [a343171...8c2b62e](https://codecov.io/gh/apache/apisix-dashboard/pull/1157?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1157: feat(FE): version manager
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #1157:
URL: https://github.com/apache/apisix-dashboard/pull/1157#issuecomment-752388306
# [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1157?src=pr&el=h1) Report
> Merging [#1157](https://codecov.io/gh/apache/apisix-dashboard/pull/1157?src=pr&el=desc) (01533af) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/83759625db904da3fd06e3462605b2be22408ac5?el=desc) (8375962) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/apisix-dashboard/pull/1157?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1157 +/- ##
=======================================
Coverage 42.32% 42.32%
=======================================
Files 31 31
Lines 1928 1928
=======================================
Hits 816 816
Misses 1001 1001
Partials 111 111
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1157?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1157?src=pr&el=footer). Last update [8375962...ce42b19](https://codecov.io/gh/apache/apisix-dashboard/pull/1157?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #1157: feat(FE): version manager
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on a change in pull request #1157:
URL: https://github.com/apache/apisix-dashboard/pull/1157#discussion_r550353845
##########
File path: web/src/pages/Route/components/Step1/LabelsDrawer.tsx
##########
@@ -108,12 +112,14 @@ const LabelList = (disabled: boolean, labelList: RouteModule.LabelList) => {
};
const LabelsDrawer: React.FC<Props> = ({
- disabled,
- labelsDataSource,
+ title = 'Label Manager',
Review comment:
Will update in another PR :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1157: feat(FE): version manager
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #1157:
URL: https://github.com/apache/apisix-dashboard/pull/1157#issuecomment-752388306
# [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1157?src=pr&el=h1) Report
> Merging [#1157](https://codecov.io/gh/apache/apisix-dashboard/pull/1157?src=pr&el=desc) (f35c46b) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/2d0fcd6e6efd5a5b666099f3b1f5582df34c646b?el=desc) (2d0fcd6) will **decrease** coverage by `0.05%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/apisix-dashboard/pull/1157?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1157 +/- ##
==========================================
- Coverage 42.32% 42.27% -0.06%
==========================================
Files 31 31
Lines 1928 1928
==========================================
- Hits 816 815 -1
- Misses 1001 1002 +1
Partials 111 111
```
| [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1157?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [api/internal/core/store/store.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1157/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmUuZ28=) | `79.37% <0.00%> (-0.63%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1157?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1157?src=pr&el=footer). Last update [2d0fcd6...f35c46b](https://codecov.io/gh/apache/apisix-dashboard/pull/1157?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] liuxiran commented on a change in pull request #1157: feat(FE): version manager
Posted by GitBox <gi...@apache.org>.
liuxiran commented on a change in pull request #1157:
URL: https://github.com/apache/apisix-dashboard/pull/1157#discussion_r550349849
##########
File path: web/src/pages/Route/components/Step1/LabelsDrawer.tsx
##########
@@ -108,12 +112,14 @@ const LabelList = (disabled: boolean, labelList: RouteModule.LabelList) => {
};
const LabelsDrawer: React.FC<Props> = ({
- disabled,
- labelsDataSource,
+ title = 'Label Manager',
Review comment:
i18n
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] LiteSun commented on a change in pull request #1157: feat(FE): version manager
Posted by GitBox <gi...@apache.org>.
LiteSun commented on a change in pull request #1157:
URL: https://github.com/apache/apisix-dashboard/pull/1157#discussion_r550254763
##########
File path: web/src/pages/Route/components/Step1/LabelsDrawer.tsx
##########
@@ -24,6 +24,8 @@ import { fetchLabelList } from '../../service';
type Props = {
title?: string;
+ labelPrefix?: string;
Review comment:
?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org