You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2014/04/23 15:52:15 UTC

[jira] [Commented] (SLING-3510) Check for null classUrls and warn when no @Model classes found by Sling Models

    [ https://issues.apache.org/jira/browse/SLING-3510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13978202#comment-13978202 ] 

ASF GitHub Bot commented on SLING-3510:
---------------------------------------

GitHub user cpilsworth opened a pull request:

    https://github.com/apache/sling/pull/15

    SLING-3510 Check for null classUrls and warn when no @Model classes found

    When a non-existent package is added to Sling-Model-Packages, then an NPE is thrown as there are no matching classes found. I guess the same would happen for existing packages that contain no @Model classes. Check for classUrls and warn, then continue if null.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/cpilsworth/sling SLING-3510

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/sling/pull/15.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #15
    
----
commit 88e2a197c7fda2922244b42b77499f54ab6a503a
Author: Chris Pilsworth <cp...@gmail.com>
Date:   2014-04-23T13:49:20Z

    SLING-3510 Check for null classUrls and warn when no @Model classes found by Sling Models

----


> Check for null classUrls and warn when no @Model classes found by Sling Models
> ------------------------------------------------------------------------------
>
>                 Key: SLING-3510
>                 URL: https://issues.apache.org/jira/browse/SLING-3510
>             Project: Sling
>          Issue Type: Bug
>          Components: Extensions
>    Affects Versions: Sling Models Implementation 1.0.2
>            Reporter: Chris Pilsworth
>
> When a non-existent package is added to Sling-Model-Packages, then an NPE is thrown as there are no matching classes found. I guess the same would happen for existing packages that contain no @Model classes. Check for classUrls and warn, then continue if null.



--
This message was sent by Atlassian JIRA
(v6.2#6252)