[GitHub] [superset] ktmud edited a comment on pull request #12478: fix: do not show vertical scrollbar for charts in dashboard

[GitBox <gi...@apache.org>]

ktmud edited a comment on pull request #12478:
URL: https://github.com/apache/superset/pull/12478#issuecomment-759112490


   For transparency, what I did is reverting #11580 and adding a proper fix for #11419 , making chart header sticky as mentioned in https://github.com/apache/superset/pull/11580#issuecomment-724181309 .
   
   Chart renders do have access to parent container size, you just need to pass it on in `transformProps`.
   
   In general, charts should handle its own scrollable area, the chart container should always be unscrollable. We will make sure wherever the charts are rendered, correct parent sizes are passed to `SuperChart`.
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org