[jira] [Comment Edited] (MESOS-9143) MasterQuotaTest.RemoveSingleQuota is flaky.

["Meng Zhu (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MESOS-9143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16769794#comment-16769794 ] 

Meng Zhu edited comment on MESOS-9143 at 2/15/19 10:15 PM:
-----------------------------------------------------------

{noformat}
commit 4380e5ba999b31782ef2fb32f51a1f225d28f5c5
Date:   Wed Feb 13 16:06:26 2019 -0800

Fixed a flaky test `MasterQuotaTest.RemoveSingleQuota`.

The test is flaky due to a race between metrics update
and metrics query.

This patch adds clock settle to ensure quota update and
removal are fully processed (including metrics updates) before
continuing with the metrics query.

Review: https://reviews.apache.org/r/69981
{noformat}


was (Author: mzhu):
commit 4380e5ba999b31782ef2fb32f51a1f225d28f5c5
Date:   Wed Feb 13 16:06:26 2019 -0800

Fixed a flaky test `MasterQuotaTest.RemoveSingleQuota`.

The test is flaky due to a race between metrics update
and metrics query.

This patch adds clock settle to ensure quota update and
removal are fully processed (including metrics updates) before
continuing with the metrics query.

Review: https://reviews.apache.org/r/69981

> MasterQuotaTest.RemoveSingleQuota is flaky.
> -------------------------------------------
>
>                 Key: MESOS-9143
>                 URL: https://issues.apache.org/jira/browse/MESOS-9143
>             Project: Mesos
>          Issue Type: Bug
>          Components: test
>            Reporter: Alexander Rukletsov
>            Assignee: Meng Zhu
>            Priority: Major
>              Labels: flaky, flaky-test, mesosphere, resource-management
>             Fix For: 1.8.0
>
>         Attachments: RemoveSingleQuota-badrun.txt
>
>
> {noformat}
> ../../src/tests/master_quota_tests.cpp:493
> Value of: metrics.at<JSON::Number>(metricKey).isNone()
>   Actual: false
> Expected: true
> {noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)