You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "ASF subversion and git services (JIRA)" <ji...@apache.org> on 2018/10/03 11:08:00 UTC
[jira] [Commented] (SOLR-12756) Refactor Assign and extract replica
placement strategies out of it
[ https://issues.apache.org/jira/browse/SOLR-12756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16636794#comment-16636794 ]
ASF subversion and git services commented on SOLR-12756:
--------------------------------------------------------
Commit 17cb1b17172926d0d9aed3dfd3b9adb90cf65e0f in lucene-solr's branch refs/heads/branch_7x from [~shalinmangar]
[ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=17cb1b1 ]
SOLR-12756: Refactor Assign and extract replica placement strategies out of it.
Now, assignment is done with the help of a builder class instead of calling a method with large number of arguments. The number of special cases that had to be handled have been cut down as well.
(cherry picked from commit c587410f99375005c680ece5e24a4dfd40d8d3eb)
> Refactor Assign and extract replica placement strategies out of it
> ------------------------------------------------------------------
>
> Key: SOLR-12756
> URL: https://issues.apache.org/jira/browse/SOLR-12756
> Project: Solr
> Issue Type: Task
> Security Level: Public(Default Security Level. Issues are Public)
> Components: SolrCloud
> Reporter: Shalin Shekhar Mangar
> Assignee: Shalin Shekhar Mangar
> Priority: Minor
> Fix For: 7.6, master (8.0)
>
> Attachments: SOLR-12756.patch, SOLR-12756.patch, SOLR-12756.patch, SOLR-12756.patch
>
>
> While working on SOLR-12648, I found Assign class to be very complex. Many methods have overlapping functionality, differ in side-effects and have non-intuitive arguments. We should clean this up and extract replica placement strategies out of that class.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org