You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2019/08/20 01:37:00 UTC

[jira] [Commented] (AIRFLOW-5247) Getting all dependencies from NPM can be moved up in Dockerfile

    [ https://issues.apache.org/jira/browse/AIRFLOW-5247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16910898#comment-16910898 ] 

ASF GitHub Bot commented on AIRFLOW-5247:
-----------------------------------------

potiuk commented on pull request #5870: [AIRFLOW-5247] Move NPM dependencies up in the Dockerfile
URL: https://github.com/apache/airflow/pull/5870
 
 
   This change should speed-up incremental builds in case of setup.py changes. Previously setup.py changed caused npm ci to be triggered but there are several reasons why this is not needed:
   
   * setup.py changes far more frequently than package.json and package-npm.json. In most cases when setup.py changes, the npm packages do not need to be updated
   * npm packages do not depend on pip packages installed
   * there is pre-installation of pip packages implemented now - so when we hit the npm ci in the new version, we already have master dependencies installed from pip. Therefore even if package-lock.json changes, the pip packages are already pre-installed and at most we just install the changed ones.
   
   That should speed up the build (when setup.py changes) by about a minute.
   
   Make sure you have checked _all_ steps below.
   
   ### Jira
   
   - [x] My PR addresses the following [Airflow Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
     - https://issues.apache.org/jira/browse/AIRFLOW-5247
   
   ### Description
   
   - [x] Here are some details about my PR, including screenshots of any UI changes:
   
   ### Tests
   
   - [ ] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
   
   ### Commits
   
   - [ ] My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [ ] In case of new functionality, my PR adds documentation that describes how to use it.
     - All the public functions and the classes in the PR contain docstrings that explain what it does
     - If you implement backwards incompatible changes, please leave a note in the [Updating.md](https://github.com/apache/airflow/blob/master/UPDATING.md) so we can assign it to a appropriate release
   
   ### Code Quality
   
   - [ ] Passes `flake8`
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Getting all dependencies from NPM can be moved up in Dockerfile
> ---------------------------------------------------------------
>
>                 Key: AIRFLOW-5247
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-5247
>             Project: Apache Airflow
>          Issue Type: Improvement
>          Components: ci
>    Affects Versions: 1.10.4, 2.0.0
>            Reporter: Jarek Potiuk
>            Assignee: Jarek Potiuk
>            Priority: Major
>
> Retrieving all NPM dependencies can happen before updating apt-get dependencies. It takes long time and it does not change that often so it is quite OK to move it before adding setup.py in dockerfile



--
This message was sent by Atlassian Jira
(v8.3.2#803003)