You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tapestry.apache.org by ta...@apache.org on 2012/09/04 03:58:48 UTC
[4/4] git commit: TAP5-1770: Fixed 'String index out of range' in
PageTester while testing pages with request/events
TAP5-1770: Fixed 'String index out of range' in PageTester while testing pages with request/events
Project: http://git-wip-us.apache.org/repos/asf/tapestry-5/repo
Commit: http://git-wip-us.apache.org/repos/asf/tapestry-5/commit/4a0780f6
Tree: http://git-wip-us.apache.org/repos/asf/tapestry-5/tree/4a0780f6
Diff: http://git-wip-us.apache.org/repos/asf/tapestry-5/diff/4a0780f6
Branch: refs/heads/master
Commit: 4a0780f6e16c71d90042c447875e77060fe62775
Parents: 6223ac8
Author: Taha Hafeez Siddiqi <ta...@apache.org>
Authored: Tue Sep 4 07:19:48 2012 +0530
Committer: Taha Hafeez Siddiqi <ta...@apache.org>
Committed: Tue Sep 4 07:22:08 2012 +0530
----------------------------------------------------------------------
atlassian-ide-plugin.xml | 5 ++++
.../java/org/apache/tapestry5/test/PageTester.java | 4 +-
tapestry-core/src/test/conf/testng.xml | 1 +
.../org/apache/tapestry5/test/PageTesterTest.java | 18 +++++++++++++++
4 files changed, 26 insertions(+), 2 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/tapestry-5/blob/4a0780f6/atlassian-ide-plugin.xml
----------------------------------------------------------------------
diff --git a/atlassian-ide-plugin.xml b/atlassian-ide-plugin.xml
new file mode 100644
index 0000000..c7826a8
--- /dev/null
+++ b/atlassian-ide-plugin.xml
@@ -0,0 +1,5 @@
+<atlassian-ide-plugin>
+ <project-configuration>
+ <servers />
+ </project-configuration>
+</atlassian-ide-plugin>
\ No newline at end of file
http://git-wip-us.apache.org/repos/asf/tapestry-5/blob/4a0780f6/tapestry-core/src/main/java/org/apache/tapestry5/test/PageTester.java
----------------------------------------------------------------------
diff --git a/tapestry-core/src/main/java/org/apache/tapestry5/test/PageTester.java b/tapestry-core/src/main/java/org/apache/tapestry5/test/PageTester.java
index 72536ab..e6ceaa7 100644
--- a/tapestry-core/src/main/java/org/apache/tapestry5/test/PageTester.java
+++ b/tapestry-core/src/main/java/org/apache/tapestry5/test/PageTester.java
@@ -331,7 +331,7 @@ public class PageTester
setupRequestFromURI(link.toRedirectURI());
}
- private void setupRequestFromURI(String URI)
+ void setupRequestFromURI(String URI)
{
String linkPath = stripContextFromPath(URI);
@@ -342,7 +342,7 @@ public class PageTester
request.clear().setPath(path);
if (comma > 0)
- decodeParametersIntoRequest(path.substring(comma + 1));
+ decodeParametersIntoRequest(linkPath.substring(comma + 1));
}
private void decodeParametersIntoRequest(String queryString)
http://git-wip-us.apache.org/repos/asf/tapestry-5/blob/4a0780f6/tapestry-core/src/test/conf/testng.xml
----------------------------------------------------------------------
diff --git a/tapestry-core/src/test/conf/testng.xml b/tapestry-core/src/test/conf/testng.xml
index 1eb2b7d..fa399e8 100644
--- a/tapestry-core/src/test/conf/testng.xml
+++ b/tapestry-core/src/test/conf/testng.xml
@@ -10,6 +10,7 @@
<suite name="Tapestry Core" annotations="1.5" verbose="2">
<test name="Component Unit Tests" enabled="true">
<packages>
+ <package name="org.apache.tapestry5.test"/>
<package name="org.apache.tapestry5.integration.pagelevel"/>
<package name="org.apache.tapestry5.corelib.base"/>
<package name="org.apache.tapestry5.corelib.components"/>
http://git-wip-us.apache.org/repos/asf/tapestry-5/blob/4a0780f6/tapestry-core/src/test/groovy/org/apache/tapestry5/test/PageTesterTest.java
----------------------------------------------------------------------
diff --git a/tapestry-core/src/test/groovy/org/apache/tapestry5/test/PageTesterTest.java b/tapestry-core/src/test/groovy/org/apache/tapestry5/test/PageTesterTest.java
new file mode 100644
index 0000000..3fecded
--- /dev/null
+++ b/tapestry-core/src/test/groovy/org/apache/tapestry5/test/PageTesterTest.java
@@ -0,0 +1,18 @@
+package org.apache.tapestry5.test;
+
+import org.testng.Assert;
+import org.testng.annotations.Test;
+
+public class PageTesterTest extends Assert
+{
+
+ @Test
+ public void setupRequestFromURI_accepts_query_strings()
+ {
+ PageTester pageTester = new PageTester("org.example.app1", "app1");
+
+ pageTester.setupRequestFromURI("/foo/somePage?param=value");
+
+ }
+
+}