You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "FoghostCn (via GitHub)" <gi...@apache.org> on 2024/05/18 09:33:24 UTC
[PR] change method WithClientCheck to WithClientNoCheck [dubbo-go]
FoghostCn opened a new pull request, #2680:
URL: https://github.com/apache/dubbo-go/pull/2680
resolve #2652
since Consumer.Check default value is true, change method WithClientCheck to WithClientNoCheck with Consumer.Check set to false
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] change method WithClientCheck to WithClientNoCheck [dubbo-go]
Posted by "AlexStocks (via GitHub)" <gi...@apache.org>.
AlexStocks merged PR #2680:
URL: https://github.com/apache/dubbo-go/pull/2680
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] change method WithClientCheck to WithClientNoCheck [dubbo-go]
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #2680:
URL: https://github.com/apache/dubbo-go/pull/2680#issuecomment-2118768651
## [](https://sonarcloud.io/dashboard?id=apache_dubbo-go&pullRequest=2680) **Quality Gate passed**
Issues
 [0 New issues](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=2680&resolved=false&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=2680&resolutions=WONTFIX)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo-go&pullRequest=2680&resolved=false&sinceLeakPeriod=true)
 No data about Coverage
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo-go&pullRequest=2680&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_dubbo-go&pullRequest=2680)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] change method WithClientCheck to WithClientNoCheck [dubbo-go]
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #2680:
URL: https://github.com/apache/dubbo-go/pull/2680#issuecomment-2118767417
## [](https://sonarcloud.io/dashboard?id=apache_dubbo-go&pullRequest=2680) **Quality Gate passed**
Issues
 [0 New issues](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=2680&resolved=false&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=2680&resolutions=WONTFIX)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo-go&pullRequest=2680&resolved=false&sinceLeakPeriod=true)
 No data about Coverage
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo-go&pullRequest=2680&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_dubbo-go&pullRequest=2680)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] change method WithClientCheck to WithClientNoCheck [dubbo-go]
Posted by "AlexStocks (via GitHub)" <gi...@apache.org>.
AlexStocks commented on code in PR #2680:
URL: https://github.com/apache/dubbo-go/pull/2680#discussion_r1605735257
##########
client/options.go:
##########
@@ -531,9 +531,9 @@ func (cliOpts *ClientOptions) init(opts ...ClientOption) error {
type ClientOption func(*ClientOptions)
-func WithClientCheck() ClientOption {
+func WithClientNoCheck() ClientOption {
Review Comment:
与其改名字,还不如传一个 check bool 参数进来
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] change method WithClientCheck to WithClientNoCheck [dubbo-go]
Posted by "FoghostCn (via GitHub)" <gi...@apache.org>.
FoghostCn commented on code in PR #2680:
URL: https://github.com/apache/dubbo-go/pull/2680#discussion_r1605737487
##########
client/options.go:
##########
@@ -531,9 +531,9 @@ func (cliOpts *ClientOptions) init(opts ...ClientOption) error {
type ClientOption func(*ClientOptions)
-func WithClientCheck() ClientOption {
+func WithClientNoCheck() ClientOption {
Review Comment:
这套 options 的 api 整体风格差不多就是枚举配置项,传参有点风格不一致
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] change method WithClientCheck to WithClientNoCheck [dubbo-go]
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #2680:
URL: https://github.com/apache/dubbo-go/pull/2680#issuecomment-2118736704
## [](https://sonarcloud.io/dashboard?id=apache_dubbo-go&pullRequest=2680) **Quality Gate passed**
Issues
 [0 New issues](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=2680&resolved=false&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=2680&resolutions=WONTFIX)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo-go&pullRequest=2680&resolved=false&sinceLeakPeriod=true)
 No data about Coverage
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo-go&pullRequest=2680&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_dubbo-go&pullRequest=2680)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] change method WithClientCheck to WithClientNoCheck [dubbo-go]
Posted by "FoghostCn (via GitHub)" <gi...@apache.org>.
FoghostCn commented on code in PR #2680:
URL: https://github.com/apache/dubbo-go/pull/2680#discussion_r1605921766
##########
client/options.go:
##########
@@ -531,9 +531,9 @@ func (cliOpts *ClientOptions) init(opts ...ClientOption) error {
type ClientOption func(*ClientOptions)
-func WithClientCheck() ClientOption {
+func WithClientNoCheck() ClientOption {
Review Comment:
是这样的雨哥,这个 API 目前只发布了一个 rc 版本,使用的人非常少,API 还处于一个不太稳定的状态,而且其实 withCheck 方法用不到,因为默认值就是 true, withCheck 也是设置为true,所以我觉得留着没啥意义
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] change method WithClientCheck to WithClientNoCheck [dubbo-go]
Posted by "AlexStocks (via GitHub)" <gi...@apache.org>.
AlexStocks commented on code in PR #2680:
URL: https://github.com/apache/dubbo-go/pull/2680#discussion_r1605798379
##########
client/options.go:
##########
@@ -531,9 +531,9 @@ func (cliOpts *ClientOptions) init(opts ...ClientOption) error {
type ClientOption func(*ClientOptions)
-func WithClientCheck() ClientOption {
+func WithClientNoCheck() ClientOption {
Review Comment:
> 这套 options 的 api 整体风格差不多就是枚举配置项,传参有点风格不一致
这个接口改动后,关键是会影响外部用户使用,所以我还是建议不要改名字,可以在注释上把函数的含义解释清楚。对外接口,不要轻易改动。
OR
把这个函数标记为 deprecated,重新实现一个新函数 WithClientNoCheck
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org