[GitHub] [dubbo-go] xavier-niu commented on a change in pull request #1299: Rft: Filter

[GitBox <gi...@apache.org>]

xavier-niu commented on a change in pull request #1299:
URL: https://github.com/apache/dubbo-go/pull/1299#discussion_r665071621



##########
File path: protocol/protocolwrapper/protocol_filter_wrapper_test.go
##########
@@ -62,12 +62,12 @@ func TestProtocolFilterWrapperRefer(t *testing.T) {
 
 // the same as echo filter, for test
 func init() {
-	extension.SetFilter("echo", GetFilter)
+	extension.SetFilter("echo", newFilter)
 }

Review comment:
       Is this not affected the real EchoFilter? (If this `SetFilter` is performed after real EchoFilter 's `SetFilter`) @LaurenceLiZhixin 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org