You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "lostluck (via GitHub)" <gi...@apache.org> on 2023/07/28 19:11:50 UTC
[GitHub] [beam] lostluck opened a new pull request, #27744: [#23043] Re-enable single iteration for the Go SDK.
lostluck opened a new pull request, #27744:
URL: https://github.com/apache/beam/pull/27744
Re-enable single iteration "decode on-demand" stream for the Go SDK.
Originally disabled due to #22933, in #23042, the principle remains sound, and it's long past time to look at why it failed in the first place.
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/get-started-contributing/#make-the-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI or the [workflows README](https://github.com/apache/beam/blob/master/.github/workflows/README.md) to see a list of phrases to trigger workflows.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] commented on pull request #27744: [#23043] Re-enable single iteration for the Go SDK.
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #27744:
URL: https://github.com/apache/beam/pull/27744#issuecomment-1656213186
## [Codecov](https://app.codecov.io/gh/apache/beam/pull/27744?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#27744](https://app.codecov.io/gh/apache/beam/pull/27744?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (7bbc882) into [master](https://app.codecov.io/gh/apache/beam/commit/9919d5a0dc76aef48c78b8b3be960f1354d64009?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (9919d5a) will **increase** coverage by `0.03%`.
> Report is 6 commits behind head on master.
> The diff coverage is `100.00%`.
```diff
@@ Coverage Diff @@
## master #27744 +/- ##
==========================================
+ Coverage 70.89% 70.92% +0.03%
==========================================
Files 860 860
Lines 104631 104631
==========================================
+ Hits 74173 74208 +35
+ Misses 28904 28869 -35
Partials 1554 1554
```
| Flag | Coverage Δ | |
|---|---|---|
| go | `53.46% <100.00%> (+0.09%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files Changed](https://app.codecov.io/gh/apache/beam/pull/27744?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [sdks/go/pkg/beam/core/runtime/exec/datasource.go](https://app.codecov.io/gh/apache/beam/pull/27744?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2Rrcy9nby9wa2cvYmVhbS9jb3JlL3J1bnRpbWUvZXhlYy9kYXRhc291cmNlLmdv) | `70.67% <100.00%> (+3.88%)` | :arrow_up: |
... and [2 files with indirect coverage changes](https://app.codecov.io/gh/apache/beam/pull/27744/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] lostluck commented on pull request #27744: [#23043] Re-enable single iteration for the Go SDK.
Posted by "lostluck (via GitHub)" <gi...@apache.org>.
lostluck commented on PR #27744:
URL: https://github.com/apache/beam/pull/27744#issuecomment-1660450347
Thanks for the review!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] lostluck commented on pull request #27744: [#23043] Re-enable single iteration for the Go SDK.
Posted by "lostluck (via GitHub)" <gi...@apache.org>.
lostluck commented on PR #27744:
URL: https://github.com/apache/beam/pull/27744#issuecomment-1659128593
Run Go Spark ValidatesRunner
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] lostluck commented on pull request #27744: [#23043] Re-enable single iteration for the Go SDK.
Posted by "lostluck (via GitHub)" <gi...@apache.org>.
lostluck commented on PR #27744:
URL: https://github.com/apache/beam/pull/27744#issuecomment-1656201399
Run Go Flink ValidatesRunner
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] lostluck commented on pull request #27744: [#23043] Re-enable single iteration for the Go SDK.
Posted by "lostluck (via GitHub)" <gi...@apache.org>.
lostluck commented on PR #27744:
URL: https://github.com/apache/beam/pull/27744#issuecomment-1659129396
Ready for a look. Ready to submit if the Spark Validates runner passes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] lostluck commented on pull request #27744: [#23043] Re-enable single iteration for the Go SDK.
Posted by "lostluck (via GitHub)" <gi...@apache.org>.
lostluck commented on PR #27744:
URL: https://github.com/apache/beam/pull/27744#issuecomment-1656201460
Run Go Samza ValidatesRunner
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] lostluck commented on pull request #27744: [#23043] Re-enable single iteration for the Go SDK.
Posted by "lostluck (via GitHub)" <gi...@apache.org>.
lostluck commented on PR #27744:
URL: https://github.com/apache/beam/pull/27744#issuecomment-1656226885
Whoops. Forgot to mark this as draft Jack. Just wanted to see if we could replicate the failure still (as listed in the description).
It doesn't occur on Prism (validated on laptop).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] jrmccluskey commented on pull request #27744: [#23043] Re-enable single iteration for the Go SDK.
Posted by "jrmccluskey (via GitHub)" <gi...@apache.org>.
jrmccluskey commented on PR #27744:
URL: https://github.com/apache/beam/pull/27744#issuecomment-1660395706
Looks like everything is good apart from the `go fmt` check
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] lostluck commented on pull request #27744: [#23043] Re-enable single iteration for the Go SDK.
Posted by "lostluck (via GitHub)" <gi...@apache.org>.
lostluck commented on PR #27744:
URL: https://github.com/apache/beam/pull/27744#issuecomment-1659217022
Run Go Spark ValidatesRunner
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] lostluck merged pull request #27744: [#23043] Re-enable single iteration for the Go SDK.
Posted by "lostluck (via GitHub)" <gi...@apache.org>.
lostluck merged PR #27744:
URL: https://github.com/apache/beam/pull/27744
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] lostluck commented on pull request #27744: [#23043] Re-enable single iteration for the Go SDK.
Posted by "lostluck (via GitHub)" <gi...@apache.org>.
lostluck commented on PR #27744:
URL: https://github.com/apache/beam/pull/27744#issuecomment-1656201235
Run Go Spark ValidatesRunner
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] lostluck commented on pull request #27744: [#23043] Re-enable single iteration for the Go SDK.
Posted by "lostluck (via GitHub)" <gi...@apache.org>.
lostluck commented on PR #27744:
URL: https://github.com/apache/beam/pull/27744#issuecomment-1656492194
It's very strange, since that element doesn't exist, it's just a windowed value header with no element, since there's only one element at all. Current idea is that element "always" exists, and it's being skipped somehow in the non-singleIterate path.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #27744: [#23043] Re-enable single iteration for the Go SDK.
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #27744:
URL: https://github.com/apache/beam/pull/27744#issuecomment-1656224852
Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`:
R: @jrmccluskey for label go.
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
The PR bot will only process comments in the main thread (not review comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] lostluck commented on pull request #27744: [#23043] Re-enable single iteration for the Go SDK.
Posted by "lostluck (via GitHub)" <gi...@apache.org>.
lostluck commented on PR #27744:
URL: https://github.com/apache/beam/pull/27744#issuecomment-1656453194
Run Go Spark ValidatesRunner
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] lostluck commented on pull request #27744: [#23043] Re-enable single iteration for the Go SDK.
Posted by "lostluck (via GitHub)" <gi...@apache.org>.
lostluck commented on PR #27744:
URL: https://github.com/apache/beam/pull/27744#issuecomment-1656201573
Run Go PostCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] lostluck commented on pull request #27744: [#23043] Re-enable single iteration for the Go SDK.
Posted by "lostluck (via GitHub)" <gi...@apache.org>.
lostluck commented on PR #27744:
URL: https://github.com/apache/beam/pull/27744#issuecomment-1656412093
Run Go Spark ValidatesRunner
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org