You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ambari.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/10/08 11:48:00 UTC

[jira] [Commented] (AMBARI-24551) [Log Search UI] get rid of redundant requests after undoing or redoing several history steps

    [ https://issues.apache.org/jira/browse/AMBARI-24551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16641703#comment-16641703 ] 

ASF GitHub Bot commented on AMBARI-24551:
-----------------------------------------

tobias-istvan opened a new pull request #5: [AMBARI-24551] [Log Search UI] get rid of redundant requests after undoing or redoing several history steps
URL: https://github.com/apache/ambari-logsearch/pull/5
 
 
   # What changes were proposed in this pull request?
   
   We can prevent extra calls by using the `LogsContainerService` `resetFiltersForms` method.
   
   ## How was this patch tested?
   
   It was tested manually checking the Network tab in dev tools and by running unit tests:
   ```
   PhantomJS 2.1.1 (Mac OS X 0.0.0): Executed 269 of 269 SUCCESS (9.276 secs / 9.178 secs)
   ✨  Done in 35.58s.
   ```
   
   Please review [Ambari Contributing Guide](https://cwiki.apache.org/confluence/display/AMBARI/How+to+Contribute) before opening a pull request.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> [Log Search UI] get rid of redundant requests after undoing or redoing several history steps
> --------------------------------------------------------------------------------------------
>
>                 Key: AMBARI-24551
>                 URL: https://issues.apache.org/jira/browse/AMBARI-24551
>             Project: Ambari
>          Issue Type: Bug
>          Components: ambari-logsearch, logsearch
>    Affects Versions: 2.7.1
>            Reporter: Istvan Tobias
>            Assignee: Istvan Tobias
>            Priority: Minor
>              Labels: pull-request-available
>             Fix For: 2.7.2
>
>   Original Estimate: 4h
>          Time Spent: 2h 40m
>  Remaining Estimate: 1h 20m
>
> After undoing or redoing more than one history items several redundant API requests are sent. This occurs because changes for several filter controls are applied step-by-step, and each control change generates new request.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)