[GitHub] liubao68 commented on a change in pull request #774: [SCB-685] Service comb chassis must support default values in query parameters

[GitBox <gi...@apache.org>]

liubao68 commented on a change in pull request #774: [SCB-685] Service comb chassis must support default values in query parameters
URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/774#discussion_r197393995
 
 

 ##########
 File path: samples/springmvc-sample/springmvc-consumer/src/main/java/org/apache/servicecomb/samples/springmvc/consumer/SpringmvcConsumerMain.java
 ##########
 @@ -51,9 +51,12 @@ public static void main(String[] args) throws Exception {
     // RestTemplate Consumer
     String sayHiResult =
         restTemplate.postForObject("cse://springmvc/springmvchello/sayhi?name=Java Chassis", null, String.class);
+    String sayHiDefaultResult =
 
 Review comment:
   It's better to add test cases in demo projects. Sample are short examples, and demos folder are integration tests, you can add as many test cases you like. 
   
   And maybe you need to test some primitive types default value, and from the following code, they seems not properly handled. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services