You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Christine Poerschke (JIRA)" <ji...@apache.org> on 2017/02/21 09:25:44 UTC
[jira] [Commented] (SOLR-10178) TestInPlaceUpdatesDistrib unable to
use NoMergePolicy[Factory] on branch_6x
[ https://issues.apache.org/jira/browse/SOLR-10178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15875660#comment-15875660 ]
Christine Poerschke commented on SOLR-10178:
--------------------------------------------
bq. ... needs to be backported to branch_6x for this test to work ...
Hmm, not sure about that, master and branch_6x should currently be in-sync w.r.t. MergePolicy\[Factory\] logic as far as I recall and SOLR-8668 itself i.e. the removal of (deprecated) MergePolicy support on master branch in favour of (replacement) MergePolicyFactory remains to be done.
bq. ... or some other stopgap ...
If the deprecated code path i.e. MergePolicy is troublesome for the test then something like this (for branch_6x only) might work to 'skip' the troublesome code path when randomisation leads the test to take the deprecated merge policy rather than the replacement merge policy factory code path.
{code}
assumeFalse("true".equals(System.getenv(SolrTestCaseJ4.SYSTEM_PROPERTY_SOLR_TESTS_USEMERGEPOLICY)));
{code}
> TestInPlaceUpdatesDistrib unable to use NoMergePolicy[Factory] on branch_6x
> ---------------------------------------------------------------------------
>
> Key: SOLR-10178
> URL: https://issues.apache.org/jira/browse/SOLR-10178
> Project: Solr
> Issue Type: Test
> Security Level: Public(Default Security Level. Issues are Public)
> Reporter: Ishan Chattopadhyaya
>
> TestInPlaceUpdatesDistrib depends on consistent segments to track docIds to assert in-place updates.
> Towards that, NoMergePolicy is best suited and working fine on master (by defining it using NoMergePolicyFactory).
> This doesn't work with just the MergePolicy (systemSetPropertySolrTestsMergePolicy()), since NoMergePolicy is a singleton and doesn't have a constructor. Setting only a NoMergePolicyFactory (systemSetPropertySolrTestsMergePolicyFactory()) seems to take no effect and falls back on RandomMergePolicyFactory. As a result, this test cannot use the NoMergePolicy[Factory].
> Here's the corresponding test failure: https://jenkins.thetaphi.de/job/Lucene-Solr-master-Linux/19012/
> Seems to me that SOLR-8668 needs to be backported to branch_6x for this test to work, or some other stopgap hack needs to be put in place to make it work before SOLR-8668 is backported. [~cpoerschke], WDYT?
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org