[jira] [Commented] (TWILL-65) Fix BundleJarExample NPE and BundleJarRunner

["Alvin Wang (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TWILL-65?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14746617#comment-14746617 ] 

Alvin Wang commented on TWILL-65:
---------------------------------

One of the issues mentioned by [~achin] was fixed by https://github.com/apache/incubator-twill/commit/b9e668c41c9b89a8984d46a65bf6dfbfcb5e119e. However, now the *library directory* is always set to "/lib". We'll need to perform the fixes mentioned in the description still.

> Fix BundleJarExample NPE and BundleJarRunner
> --------------------------------------------
>
>                 Key: TWILL-65
>                 URL: https://issues.apache.org/jira/browse/TWILL-65
>             Project: Apache Twill
>          Issue Type: Bug
>          Components: ext
>            Reporter: Terence Yim
>            Assignee: Alvin Wang
>             Fix For: 0.7.0-incubating
>
>
> See the mail
> http://s.apache.org/z0z
> ---
> Needed changes:
> 1. Instead of unpacking application jar and then adding both the original application jar and the jars within the libFolder directory inside the unpacked jar directory, BundledJarRunner should add ./, ./\*.jar, and ./lib/\*.jar within the unpacked jar directory to the classpath.
> 2. Remove required library directory argument from BundledJarExample and BundledJarRunner.
> 3. Add optional additional library directories to BundledJarRunner, in addition to ./\*.jar and ./lib/\*.jar.
> 4. Add better validations so that errors indicate a clear root cause.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)