You are viewing a plain text version of this content. The canonical link for it is here.
Posted to log4j-dev@logging.apache.org by "Gary Gregory (JIRA)" <ji...@apache.org> on 2015/06/23 10:06:01 UTC
[jira] [Commented] (LOG4J2-1058) Log4jMarker#contains(String) does
not respect org.slf4j.Marker contract
[ https://issues.apache.org/jira/browse/LOG4J2-1058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14597316#comment-14597316 ]
Gary Gregory commented on LOG4J2-1058:
--------------------------------------
You're welcome. Yes I did review and fix a couple of methods that were not compliant.
I would appreciate a further review of our SLF4J modules if you are up to it.
Submitting patches for fixes or additional tests would be most welcome in additional Jira tickets.
Thank you,
Gary
> Log4jMarker#contains(String) does not respect org.slf4j.Marker contract
> -----------------------------------------------------------------------
>
> Key: LOG4J2-1058
> URL: https://issues.apache.org/jira/browse/LOG4J2-1058
> Project: Log4j 2
> Issue Type: Bug
> Components: SLF4J Bridge
> Affects Versions: 2.3
> Reporter: Daniel Branzea
> Priority: Minor
> Fix For: 2.4
>
>
> Expected behavior
> ==============
> 'org.apache.logging.slf4j.Log4jMarker' implements 'org.slf4j.Marker'.
> 'org.slf4j.Marker#contains(String name)' contract states that: "If 'name' is null the returned value is always false."
> http://www.slf4j.org/apidocs/org/slf4j/Marker.html#contains%28java.lang.String%29
> Actual behavior
> =============
> 'org.apache.logging.slf4j.Log4jMarker#contains(final String name)' throws 'IllegalArgumentException' if 'name' is null
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
For additional commands, e-mail: log4j-dev-help@logging.apache.org