You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@subversion.apache.org by ph...@apache.org on 2011/04/15 14:32:41 UTC
svn commit: r1092684 - /subversion/trunk/subversion/libsvn_repos/log.c
Author: philip
Date: Fri Apr 15 12:32:40 2011
New Revision: 1092684
URL: http://svn.apache.org/viewvc?rev=1092684&view=rev
Log:
* subversion/libsvn_repos/log.c
(detect_changed): Don't leak subpool when exiting early.
Modified:
subversion/trunk/subversion/libsvn_repos/log.c
Modified: subversion/trunk/subversion/libsvn_repos/log.c
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_repos/log.c?rev=1092684&r1=1092683&r2=1092684&view=diff
==============================================================================
--- subversion/trunk/subversion/libsvn_repos/log.c (original)
+++ subversion/trunk/subversion/libsvn_repos/log.c Fri Apr 15 12:32:40 2011
@@ -183,7 +183,7 @@ detect_changed(apr_hash_t **changed,
{
apr_hash_t *changes;
apr_hash_index_t *hi;
- apr_pool_t *subpool = svn_pool_create(pool);
+ apr_pool_t *subpool;
svn_boolean_t found_readable = FALSE;
svn_boolean_t found_unreadable = FALSE;
@@ -195,6 +195,8 @@ detect_changed(apr_hash_t **changed,
revision is readable, then. */
return SVN_NO_ERROR;
+ subpool = svn_pool_create(pool);
+
for (hi = apr_hash_first(pool, changes); hi; hi = apr_hash_next(hi))
{
/* NOTE: Much of this loop is going to look quite similar to