You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@ofbiz.apache.org by ad...@apache.org on 2013/09/25 21:57:13 UTC
svn commit: r1526276 - /ofbiz/trunk/framework/common/servicedef/services.xml
Author: adrianc
Date: Wed Sep 25 19:57:13 2013
New Revision: 1526276
URL: http://svn.apache.org/r1526276
Log:
Fixed a warning caused by a framework dependency on the Party component.
Modified:
ofbiz/trunk/framework/common/servicedef/services.xml
Modified: ofbiz/trunk/framework/common/servicedef/services.xml
URL: http://svn.apache.org/viewvc/ofbiz/trunk/framework/common/servicedef/services.xml?rev=1526276&r1=1526275&r2=1526276&view=diff
==============================================================================
--- ofbiz/trunk/framework/common/servicedef/services.xml (original)
+++ ofbiz/trunk/framework/common/servicedef/services.xml Wed Sep 25 19:57:13 2013
@@ -181,9 +181,9 @@ under the License.
<description>Create a CustomTimePeriod record</description>
<auto-attributes mode="OUT" include="pk" optional="false"/>
<auto-attributes mode="IN" include="nonpk" optional="true"/>
+ <attribute name="organizationPartyId" type="String" mode="IN" optional="false"/><!-- FIXME: Framework dependency on Party component -->
<override name="fromDate" optional="false"/>
<override name="thruDate" optional="false"/>
- <override name="organizationPartyId" optional="false"/>
<override name="periodTypeId" optional="false"/>
</service>
<service name="updateCustomTimePeriod" default-entity-name="CustomTimePeriod" engine="simple"
Re: svn commit: r1526276 -
/ofbiz/trunk/framework/common/servicedef/services.xml
Posted by Jacques Le Roux <ja...@les7arts.com>.
I did not ask about all of them, just this one...
Jacques
Adrian Crum wrote:
> I have put dozens of FIXME comments in the project. No, I don't have
> time to fix them all.
>
> Adrian Crum
> Sandglass Software
> www.sandglass-software.com
>
> On 9/25/2013 2:37 PM, Jacques Le Roux wrote:
>> Is this rather not hidding the warning?
>> Is a FIXME (moreover in xml code) better?
>> Do you intent to fix it soon?
>>
>> Jacques
>>
>> adrianc@apache.org wrote:
>>> Author: adrianc
>>> Date: Wed Sep 25 19:57:13 2013
>>> New Revision: 1526276
>>>
>>> URL: http://svn.apache.org/r1526276
>>> Log:
>>> Fixed a warning caused by a framework dependency on the Party component.
>>>
>>> Modified:
>>> ofbiz/trunk/framework/common/servicedef/services.xml
>>>
>>> Modified: ofbiz/trunk/framework/common/servicedef/services.xml
>>> URL:
>>> http://svn.apache.org/viewvc/ofbiz/trunk/framework/common/servicedef/services.xml?rev=1526276&r1=1526275&r2=1526276&view=diff
>>> ============================================================================== ---
>>> ofbiz/trunk/framework/common/servicedef/services.xml (original) +++ ofbiz/trunk/framework/common/servicedef/services.xml Wed
>>> Sep 25 19:57:13 2013 @@ -181,9 +181,9 @@ under the License.
>>> <description>Create a CustomTimePeriod record</description>
>>> <auto-attributes mode="OUT" include="pk" optional="false"/>
>>> <auto-attributes mode="IN" include="nonpk" optional="true"/>
>>> + <attribute name="organizationPartyId" type="String" mode="IN" optional="false"/><!-- FIXME: Framework dependency on
>>> Party component --> <override name="fromDate" optional="false"/>
>>> <override name="thruDate" optional="false"/>
>>> - <override name="organizationPartyId" optional="false"/>
>>> <override name="periodTypeId" optional="false"/>
>>> </service>
>>> <service name="updateCustomTimePeriod" default-entity-name="CustomTimePeriod" engine="simple"
Re: svn commit: r1526276 - /ofbiz/trunk/framework/common/servicedef/services.xml
Posted by Adrian Crum <ad...@sandglass-software.com>.
I have put dozens of FIXME comments in the project. No, I don't have
time to fix them all.
Adrian Crum
Sandglass Software
www.sandglass-software.com
On 9/25/2013 2:37 PM, Jacques Le Roux wrote:
> Is this rather not hidding the warning?
> Is a FIXME (moreover in xml code) better?
> Do you intent to fix it soon?
>
> Jacques
>
> adrianc@apache.org wrote:
>> Author: adrianc
>> Date: Wed Sep 25 19:57:13 2013
>> New Revision: 1526276
>>
>> URL: http://svn.apache.org/r1526276
>> Log:
>> Fixed a warning caused by a framework dependency on the Party component.
>>
>> Modified:
>> ofbiz/trunk/framework/common/servicedef/services.xml
>>
>> Modified: ofbiz/trunk/framework/common/servicedef/services.xml
>> URL: http://svn.apache.org/viewvc/ofbiz/trunk/framework/common/servicedef/services.xml?rev=1526276&r1=1526275&r2=1526276&view=diff
>> ==============================================================================
>> --- ofbiz/trunk/framework/common/servicedef/services.xml (original)
>> +++ ofbiz/trunk/framework/common/servicedef/services.xml Wed Sep 25 19:57:13 2013
>> @@ -181,9 +181,9 @@ under the License.
>> <description>Create a CustomTimePeriod record</description>
>> <auto-attributes mode="OUT" include="pk" optional="false"/>
>> <auto-attributes mode="IN" include="nonpk" optional="true"/>
>> + <attribute name="organizationPartyId" type="String" mode="IN" optional="false"/><!-- FIXME: Framework dependency on
>> Party component --> <override name="fromDate" optional="false"/>
>> <override name="thruDate" optional="false"/>
>> - <override name="organizationPartyId" optional="false"/>
>> <override name="periodTypeId" optional="false"/>
>> </service>
>> <service name="updateCustomTimePeriod" default-entity-name="CustomTimePeriod" engine="simple"
Re: svn commit: r1526276 -
/ofbiz/trunk/framework/common/servicedef/services.xml
Posted by Jacques Le Roux <ja...@les7arts.com>.
Is this rather not hidding the warning?
Is a FIXME (moreover in xml code) better?
Do you intent to fix it soon?
Jacques
adrianc@apache.org wrote:
> Author: adrianc
> Date: Wed Sep 25 19:57:13 2013
> New Revision: 1526276
>
> URL: http://svn.apache.org/r1526276
> Log:
> Fixed a warning caused by a framework dependency on the Party component.
>
> Modified:
> ofbiz/trunk/framework/common/servicedef/services.xml
>
> Modified: ofbiz/trunk/framework/common/servicedef/services.xml
> URL: http://svn.apache.org/viewvc/ofbiz/trunk/framework/common/servicedef/services.xml?rev=1526276&r1=1526275&r2=1526276&view=diff
> ==============================================================================
> --- ofbiz/trunk/framework/common/servicedef/services.xml (original)
> +++ ofbiz/trunk/framework/common/servicedef/services.xml Wed Sep 25 19:57:13 2013
> @@ -181,9 +181,9 @@ under the License.
> <description>Create a CustomTimePeriod record</description>
> <auto-attributes mode="OUT" include="pk" optional="false"/>
> <auto-attributes mode="IN" include="nonpk" optional="true"/>
> + <attribute name="organizationPartyId" type="String" mode="IN" optional="false"/><!-- FIXME: Framework dependency on
> Party component --> <override name="fromDate" optional="false"/>
> <override name="thruDate" optional="false"/>
> - <override name="organizationPartyId" optional="false"/>
> <override name="periodTypeId" optional="false"/>
> </service>
> <service name="updateCustomTimePeriod" default-entity-name="CustomTimePeriod" engine="simple"