You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@felix.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/09/20 19:02:00 UTC
[jira] [Commented] (FELIX-4447) Regression in ScrShellCommand (NPE
caused by falsy regex)
[ https://issues.apache.org/jira/browse/FELIX-4447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16173682#comment-16173682 ]
ASF GitHub Bot commented on FELIX-4447:
---------------------------------------
GitHub user cgdrake opened a pull request:
https://github.com/apache/felix/pull/120
[FELIX-4447] fix regexp, thanks to Olivier Fayau
git-svn-id: https://svn.apache.org/repos/asf/felix/trunk/scr@1591422 13f79535-47bb-0310-9956-ffa450edef68
Given that this is a low impact and trivial fix which causes a fair bit of aggrevation, it would be great if this could be merged into the scr-1.8.x branch and released in 1.8.5.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/cgdrake/felix scr-1.8.x
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/felix/pull/120.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #120
----
commit 29e5f8d247c5e927b6e703a7b1ed2f87d5015fa7
Author: David Jencks <dj...@apache.org>
Date: 2014-04-30T18:01:38Z
[FELIX-4447] fix regexp, thanks to Olivier Fayau
git-svn-id: https://svn.apache.org/repos/asf/felix/trunk/scr@1591422 13f79535-47bb-0310-9956-ffa450edef68
----
> Regression in ScrShellCommand (NPE caused by falsy regex)
> ---------------------------------------------------------
>
> Key: FELIX-4447
> URL: https://issues.apache.org/jira/browse/FELIX-4447
> Project: Felix
> Issue Type: Bug
> Components: Declarative Services (SCR), Script Console Plugin
> Affects Versions: scr-1.8.0, scr-1.8.2
> Reporter: Olivier Fayau
> Assignee: David Jencks
> Labels: easyfix
> Fix For: scr-2.0.0
>
>
> Using felix console and DS (scr + shell +shell tui), the command scr doesn't work anymore.
> Sample :
> scr list
> -> Unable to execute command: java.lang.NullPointerException
> java.lang.NullPointerException
> at org.apache.felix.scr.impl.ScrShellCommand.help(ScrShellCommand.java:116)
> at org.apache.felix.scr.impl.ScrShellCommand.execute(ScrShellCommand.java:75)
> at org.apache.felix.shell.impl.Activator$ShellServiceImpl.executeCommand(Activator.java:249)
> at org.apache.felix.shell.tui.Activator$ShellTuiRunnable.run(Activator.java:184)
> at java.lang.Thread.run(Unknown Source)
> Looking at source code, in ScrShellCommand.execute(), command is splitted by the falsy regex "//s".
> This should be "\\s+" instead.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)