[jira] [Commented] (HIVE-11483) Add encoding and decoding for query string config

["Alan Gates (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HIVE-11483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14682088#comment-14682088 ] 

Alan Gates commented on HIVE-11483:
-----------------------------------

Several comments:

# You should attach a patch so that it runs through the automated tests
# Do we need the query string in the config at all?  What on the backend reads it?
# (Going in the opposite direction of the previous comment) One issue with this is it makes the query string not human readable.  One possible use of putting the string in the config file is tools and users could see the associated query.  If we want to preserve this should we instead just mask the control characters (ie change actual ctrl-A to ^A or something).

> Add encoding and decoding for query string config
> -------------------------------------------------
>
>                 Key: HIVE-11483
>                 URL: https://issues.apache.org/jira/browse/HIVE-11483
>             Project: Hive
>          Issue Type: Improvement
>          Components: Query Processor
>            Reporter: Amareshwari Sriramadasu
>
> We have seen some queries in production where some of the literals passed in the query have control characters, which result in exception when query string is set in the job xml.
> Proposing a solution to encode the query string in configuration and provide getters decoded string.
> Here is a commit in a forked repo : https://github.com/InMobi/hive/commit/2faf5761191fa3103a0d779fde584d494ed75bf5
> Suggestions are welcome on the solution.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)