[GitHub] [flink] gaoyunhaii commented on a diff in pull request #20223: [FLINK-28457][runtime] Introduce JobStatusHook

[GitBox <gi...@apache.org>]

gaoyunhaii commented on code in PR #20223:
URL: https://github.com/apache/flink/pull/20223#discussion_r919606689


##########
flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/JobStatusHook.java:
##########
@@ -0,0 +1,51 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.runtime.executiongraph;
+
+import org.apache.flink.annotation.Internal;
+import org.apache.flink.api.common.JobID;
+
+import java.io.Serializable;
+
+/**
+ * Hooks provided by users on job status changing. Triggered at the initial(CREATED) and final
+ * state(FINISHED/CANCELED/FAILED) of the job.
+ *
+ * <p>Usage examples: <code>
+ *     StreamGraph streamGraph = env.getStreamGraph();
+ *     streamGraph.registerJobStatusHook(myJobStatusHook);
+ *     streamGraph.setJobName("my_flink");
+ *     env.execute(streamGraph);
+ * </code>
+ */
+@Internal
+public interface JobStatusHook extends Serializable {
+
+    /** When Job become {@link JobStatus#CREATED} status, it would only be called one time. */

Review Comment:
   `become` -> `becomes` 
   
   nit: import JobStatus to avoid warnings



##########
flink-runtime/src/test/java/org/apache/flink/runtime/scheduler/DefaultSchedulerTest.java:
##########
@@ -1618,6 +1621,141 @@ public void testCheckpointCleanerIsClosedAfterCheckpointServices() throws Except
         }
     }
 
+    @Test
+    public void testJobStatusHookWithJobFailed() throws Exception {

Review Comment:
   The three test methods seem quite similar, could we extract a common help method?



##########
flink-runtime/src/main/java/org/apache/flink/runtime/jobgraph/JobGraph.java:
##########
@@ -628,4 +632,12 @@ public void writeUserArtifactEntriesToConfiguration() {
                     userArtifact.getKey(), userArtifact.getValue(), jobConfiguration);
         }
     }
+
+    public void setJobStatusHooks(List<JobStatusHook> hooks) {
+        this.jobStatusHooks = hooks;

Review Comment:
   Might also `checkNotNull` ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org