You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/11/05 19:44:33 UTC
[GitHub] [arrow] pitrou opened a new pull request, #14594: ARROW-17975: [C++] Create at-fork facility
pitrou opened a new pull request, #14594:
URL: https://github.com/apache/arrow/pull/14594
Also migrate the `ThreadPool` class to use the new facility.
The `util::GlobalForkSafeMutex` facility is now unused, we may want to remove it in a later PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #14594: ARROW-17975: [C++] Create at-fork facility
Posted by GitBox <gi...@apache.org>.
ursabot commented on PR #14594:
URL: https://github.com/apache/arrow/pull/14594#issuecomment-1306100664
Benchmark runs are scheduled for baseline = 7f067f9a11a9752a1b5d226302c9c32358f7fd36 and contender = 619b034bd3e14937fa5d12f8e86fa83e7444b886. 619b034bd3e14937fa5d12f8e86fa83e7444b886 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/a49d0de46353411bb87c8ac4b87ca129...30b20111c12a4763a829b497c6e31f9f/)
[Failed :arrow_down:1.69% :arrow_up:2.1%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/7e3244d56cc940f68b53cd8572330f27...ca220bf993334d509ba836f58e0e6e88/)
[Failed :arrow_down:0.0% :arrow_up:0.0%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/d2d7c6a3ebab4ad1ac64a6064786d724...365ae5ff4db54596b7bf7a6d1d1c0b7e/)
[Finished :arrow_down:1.16% :arrow_up:0.74%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/cc4f17ab56b5418f8010fd080e532b08...3685680736844457a340be9dd76d9811/)
Buildkite builds:
[Finished] [`619b034b` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/1824)
[Failed] [`619b034b` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/1846)
[Finished] [`619b034b` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/1812)
[Finished] [`619b034b` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/1838)
[Finished] [`7f067f9a` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/1823)
[Failed] [`7f067f9a` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/1845)
[Failed] [`7f067f9a` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/1811)
[Finished] [`7f067f9a` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/1837)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou merged pull request #14594: ARROW-17975: [C++] Create at-fork facility
Posted by GitBox <gi...@apache.org>.
pitrou merged PR #14594:
URL: https://github.com/apache/arrow/pull/14594
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on pull request #14594: ARROW-17975: [C++] Create at-fork facility
Posted by GitBox <gi...@apache.org>.
pitrou commented on PR #14594:
URL: https://github.com/apache/arrow/pull/14594#issuecomment-1305998613
Yes, hopefully it should be more robust than the previous way of inspecting the current pid in random places...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #14594: ARROW-17975: [C++] Create at-fork facility
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #14594:
URL: https://github.com/apache/arrow/pull/14594#issuecomment-1304621686
Revision: 961a457c8ad428a96df5a71ace3269d4846e5b76
Submitted crossbow builds: [ursacomputing/crossbow @ actions-21ee6e6b86](https://github.com/ursacomputing/crossbow/branches/all?query=actions-21ee6e6b86)
|Task|Status|
|----|------|
|test-alpine-linux-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/3401434939/jobs/5656533073)|
|test-build-cpp-fuzz|[](https://github.com/ursacomputing/crossbow/actions/runs/3401435273/jobs/5656533522)|
|test-conda-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/3401434064/jobs/5656531775)|
|test-conda-cpp-valgrind|[](https://github.com/ursacomputing/crossbow/runs/9314766197)|
|test-cuda-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/3401435507/jobs/5656534054)|
|test-debian-10-cpp-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/3401435347/jobs/5656533728)|
|test-debian-10-cpp-i386|[](https://github.com/ursacomputing/crossbow/actions/runs/3401434265/jobs/5656532128)|
|test-debian-11-cpp-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/3401436612/jobs/5656535762)|
|test-debian-11-cpp-i386|[](https://github.com/ursacomputing/crossbow/actions/runs/3401433837/jobs/5656531414)|
|test-fedora-35-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/3401434765/jobs/5656532772)|
|test-ubuntu-18.04-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/3401435623/jobs/5656534255)|
|test-ubuntu-18.04-cpp-release|[](https://github.com/ursacomputing/crossbow/actions/runs/3401436163/jobs/5656534966)|
|test-ubuntu-18.04-cpp-static|[](https://github.com/ursacomputing/crossbow/actions/runs/3401434121/jobs/5656531907)|
|test-ubuntu-20.04-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/3401435445/jobs/5656533939)|
|test-ubuntu-20.04-cpp-20|[](https://github.com/ursacomputing/crossbow/actions/runs/3401433805/jobs/5656531289)|
|test-ubuntu-20.04-cpp-bundled|[](https://github.com/ursacomputing/crossbow/actions/runs/3401436342/jobs/5656535288)|
|test-ubuntu-20.04-cpp-thread-sanitizer|[](https://github.com/ursacomputing/crossbow/actions/runs/3401436835/jobs/5656536082)|
|test-ubuntu-22.04-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/3401433530/jobs/5656530886)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] westonpace commented on pull request #14594: ARROW-17975: [C++] Create at-fork facility
Posted by GitBox <gi...@apache.org>.
westonpace commented on PR #14594:
URL: https://github.com/apache/arrow/pull/14594#issuecomment-1305994425
Thanks for doing this. Looks like a very useful utility and IIRC the atfork handlers should be a safer way of solving this problem too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #14594: ARROW-17975: [C++] Create at-fork facility
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #14594:
URL: https://github.com/apache/arrow/pull/14594#issuecomment-1304620926
https://issues.apache.org/jira/browse/ARROW-17975
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on pull request #14594: ARROW-17975: [C++] Create at-fork facility
Posted by GitBox <gi...@apache.org>.
pitrou commented on PR #14594:
URL: https://github.com/apache/arrow/pull/14594#issuecomment-1304620994
@github-actions crossbow submit -g cpp
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org