[GitHub] spark pull request #18452: [SPARK-21239][STREAMING] Support WAL recover in w...

[dongjoon-hyun <gi...@git.apache.org>]

Github user dongjoon-hyun commented on a diff in the pull request:

    https://github.com/apache/spark/pull/18452#discussion_r124915742
  
    --- Diff: streaming/src/main/scala/org/apache/spark/streaming/rdd/WriteAheadLogBackedBlockRDD.scala ---
    @@ -135,8 +135,11 @@ class WriteAheadLogBackedBlockRDD[T: ClassTag](
             // FileBasedWriteAheadLog will not create any file or directory at that path. Also,
             // this dummy directory should not already exist otherwise the WAL will try to recover
             // past events from the directory and throw errors.
    +        // Specifically, the nonExistentDirectory will contain a colon in windows, this is invalid
    +        // for hadoop. Remove the drive letter and colon, e.g. "D:" out of this path by default
             val nonExistentDirectory = new File(
    -          System.getProperty("java.io.tmpdir"), UUID.randomUUID().toString).getAbsolutePath
    +          System.getProperty("java.io.tmpdir").replaceFirst("[a-zA-Z]:", ""),
    +          UUID.randomUUID().toString).getPath
    --- End diff --
    
    Hi, @Myasuka .
    I'm just wondering why do you change `getAbsolutePath` to `getPath` together? Is it related to your fix?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org