You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kafka.apache.org by st...@apache.org on 2024/01/08 09:42:56 UTC

(kafka) branch trunk updated: MINOR: Fix shadow jar publishing for the clients module (#15127)

This is an automated email from the ASF dual-hosted git repository.

stanislavkozlovski pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/kafka.git


The following commit(s) were added to refs/heads/trunk by this push:
     new 8a76c16a02e MINOR: Fix shadow jar publishing for the clients module (#15127)
8a76c16a02e is described below

commit 8a76c16a02ef11555dc9d5d3b59831341d896b28
Author: Apoorv Mittal <am...@confluent.io>
AuthorDate: Mon Jan 8 15:12:49 2024 +0530

    MINOR: Fix shadow jar publishing for the clients module (#15127)
    
    The PR fixes the publishing of kafka-clients artifact to remote maven. The kafka-clients jar was recently shadowed which would publish the artifacts to the local maven repo successfully but would throw an error when publishing to remote maven. (as part of the release process)
    
    The issue triggers only with publishMavenJavaPublicationToMavenRepository due to signing. Generating signed asc files error out for shadowed release artifacts as the module name (clients) differs from the artifact name (kafka-clients).
    
    The fix is basically to explicitly define artifact of shadowJar to signing and publish plugin. project.shadow.component(mavenJava) previously outputs the name as client-<version>-all.jar though the classifier and archivesBaseName are already defined correctly in :clients and shadowJar construction.
---
 build.gradle | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/build.gradle b/build.gradle
index ca98890bd5a..ed1c7b77924 100644
--- a/build.gradle
+++ b/build.gradle
@@ -303,7 +303,7 @@ subprojects {
             from components.java
           } else {
             apply plugin: 'com.github.johnrengelman.shadow'
-            project.shadow.component(mavenJava)
+            artifact shadowJar
           }
 
           afterEvaluate {