You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Alexander Rukletsov <ru...@gmail.com> on 2016/12/09 04:27:06 UTC
Review Request 54570: Added comments around some health check
limitations.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54570/
-----------------------------------------------------------
Review request for mesos, Gast�n Kleiman and haosdent huang.
Repository: mesos
Description
-------
See summary.
Diffs
-----
docs/health-checks.md 9e3be78b8900143c2cbb8c970ac6acee1b3f4bb5
src/health-check/health_checker.cpp c0d150a014b7debf23b58982efe335a189d32c7b
Diff: https://reviews.apache.org/r/54570/diff/
Testing
-------
None: Not a functional change.
Thanks,
Alexander Rukletsov
Re: Review Request 54570: Added comments around some health check
limitations.
Posted by Alexander Rukletsov <ru...@gmail.com>.
> On Dec. 9, 2016, 4:33 a.m., haosdent huang wrote:
> > docs/health-checks.md, line 282
> > <https://reviews.apache.org/r/54570/diff/1/?file=1580348#file1580348line282>
> >
> > Should be `e.g., 0.05 xx` here? I refer to https://en.wiktionary.org/wiki/e.g.
Yup, you're right.
- Alexander
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54570/#review158641
-----------------------------------------------------------
On Dec. 9, 2016, 4:27 a.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54570/
> -----------------------------------------------------------
>
> (Updated Dec. 9, 2016, 4:27 a.m.)
>
>
> Review request for mesos, Gast�n Kleiman and haosdent huang.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> docs/health-checks.md 9e3be78b8900143c2cbb8c970ac6acee1b3f4bb5
> src/health-check/health_checker.cpp c0d150a014b7debf23b58982efe335a189d32c7b
>
> Diff: https://reviews.apache.org/r/54570/diff/
>
>
> Testing
> -------
>
> None: Not a functional change.
>
>
> Thanks,
>
> Alexander Rukletsov
>
>
Re: Review Request 54570: Added comments around some health check
limitations.
Posted by haosdent huang <ha...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54570/#review158641
-----------------------------------------------------------
docs/health-checks.md (line 282)
<https://reviews.apache.org/r/54570/#comment229427>
Should be `e.g., 0.05 xx` here? I refer to https://en.wiktionary.org/wiki/e.g.
- haosdent huang
On Dec. 9, 2016, 4:27 a.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54570/
> -----------------------------------------------------------
>
> (Updated Dec. 9, 2016, 4:27 a.m.)
>
>
> Review request for mesos, Gast�n Kleiman and haosdent huang.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> docs/health-checks.md 9e3be78b8900143c2cbb8c970ac6acee1b3f4bb5
> src/health-check/health_checker.cpp c0d150a014b7debf23b58982efe335a189d32c7b
>
> Diff: https://reviews.apache.org/r/54570/diff/
>
>
> Testing
> -------
>
> None: Not a functional change.
>
>
> Thanks,
>
> Alexander Rukletsov
>
>
Re: Review Request 54570: Added comments around some health check
limitations.
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54570/
-----------------------------------------------------------
(Updated Dec. 10, 2016, 9:30 p.m.)
Review request for mesos, Gast�n Kleiman, haosdent huang, and Till Toenshoff.
Repository: mesos
Description
-------
See summary.
Diffs (updated)
-----
docs/health-checks.md 9e3be78b8900143c2cbb8c970ac6acee1b3f4bb5
src/health-check/health_checker.cpp c0d150a014b7debf23b58982efe335a189d32c7b
Diff: https://reviews.apache.org/r/54570/diff/
Testing
-------
None: Not a functional change.
Thanks,
Alexander Rukletsov
Re: Review Request 54570: Added comments around some health check
limitations.
Posted by Till Toenshoff <to...@me.com>.
> On Dec. 9, 2016, 3:46 p.m., Till Toenshoff wrote:
> > docs/health-checks.md, line 306
> > <https://reviews.apache.org/r/54570/diff/2/?file=1580448#file1580448line306>
> >
> > I wonder how significant this overhead is. Do we have any profiling information we could add to the ticket for reasoning?
>
> Alexander Rukletsov wrote:
> There will be a blog post!
sweeet!
- Till
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54570/#review158684
-----------------------------------------------------------
On Dec. 9, 2016, 3:11 p.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54570/
> -----------------------------------------------------------
>
> (Updated Dec. 9, 2016, 3:11 p.m.)
>
>
> Review request for mesos, Gast�n Kleiman, haosdent huang, and Till Toenshoff.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> docs/health-checks.md 9e3be78b8900143c2cbb8c970ac6acee1b3f4bb5
> src/health-check/health_checker.cpp c0d150a014b7debf23b58982efe335a189d32c7b
>
> Diff: https://reviews.apache.org/r/54570/diff/
>
>
> Testing
> -------
>
> None: Not a functional change.
>
>
> Thanks,
>
> Alexander Rukletsov
>
>
Re: Review Request 54570: Added comments around some health check
limitations.
Posted by Alexander Rukletsov <ru...@gmail.com>.
> On Dec. 9, 2016, 3:46 p.m., Till Toenshoff wrote:
> > docs/health-checks.md, line 306
> > <https://reviews.apache.org/r/54570/diff/2/?file=1580448#file1580448line306>
> >
> > I wonder how significant this overhead is. Do we have any profiling information we could add to the ticket for reasoning?
There will be a blog post!
- Alexander
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54570/#review158684
-----------------------------------------------------------
On Dec. 9, 2016, 3:11 p.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54570/
> -----------------------------------------------------------
>
> (Updated Dec. 9, 2016, 3:11 p.m.)
>
>
> Review request for mesos, Gast�n Kleiman, haosdent huang, and Till Toenshoff.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> docs/health-checks.md 9e3be78b8900143c2cbb8c970ac6acee1b3f4bb5
> src/health-check/health_checker.cpp c0d150a014b7debf23b58982efe335a189d32c7b
>
> Diff: https://reviews.apache.org/r/54570/diff/
>
>
> Testing
> -------
>
> None: Not a functional change.
>
>
> Thanks,
>
> Alexander Rukletsov
>
>
Re: Review Request 54570: Added comments around some health check
limitations.
Posted by Till Toenshoff <to...@me.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54570/#review158684
-----------------------------------------------------------
Ship it!
docs/health-checks.md (line 306)
<https://reviews.apache.org/r/54570/#comment229479>
I wonder how significant this overhead is. Do we have any profiling information we could add to the ticket for reasoning?
- Till Toenshoff
On Dec. 9, 2016, 3:11 p.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54570/
> -----------------------------------------------------------
>
> (Updated Dec. 9, 2016, 3:11 p.m.)
>
>
> Review request for mesos, Gast�n Kleiman, haosdent huang, and Till Toenshoff.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> docs/health-checks.md 9e3be78b8900143c2cbb8c970ac6acee1b3f4bb5
> src/health-check/health_checker.cpp c0d150a014b7debf23b58982efe335a189d32c7b
>
> Diff: https://reviews.apache.org/r/54570/diff/
>
>
> Testing
> -------
>
> None: Not a functional change.
>
>
> Thanks,
>
> Alexander Rukletsov
>
>
Re: Review Request 54570: Added comments around some health check
limitations.
Posted by Gastón Kleiman <ga...@mesosphere.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54570/#review158759
-----------------------------------------------------------
Ship it!
Ship It!
- Gast�n Kleiman
On Dec. 9, 2016, 3:11 p.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54570/
> -----------------------------------------------------------
>
> (Updated Dec. 9, 2016, 3:11 p.m.)
>
>
> Review request for mesos, Gast�n Kleiman, haosdent huang, and Till Toenshoff.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> docs/health-checks.md 9e3be78b8900143c2cbb8c970ac6acee1b3f4bb5
> src/health-check/health_checker.cpp c0d150a014b7debf23b58982efe335a189d32c7b
>
> Diff: https://reviews.apache.org/r/54570/diff/
>
>
> Testing
> -------
>
> None: Not a functional change.
>
>
> Thanks,
>
> Alexander Rukletsov
>
>
Re: Review Request 54570: Added comments around some health check
limitations.
Posted by haosdent huang <ha...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54570/#review158708
-----------------------------------------------------------
Ship it!
Ship It!
- haosdent huang
On Dec. 9, 2016, 3:11 p.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54570/
> -----------------------------------------------------------
>
> (Updated Dec. 9, 2016, 3:11 p.m.)
>
>
> Review request for mesos, Gast�n Kleiman, haosdent huang, and Till Toenshoff.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> docs/health-checks.md 9e3be78b8900143c2cbb8c970ac6acee1b3f4bb5
> src/health-check/health_checker.cpp c0d150a014b7debf23b58982efe335a189d32c7b
>
> Diff: https://reviews.apache.org/r/54570/diff/
>
>
> Testing
> -------
>
> None: Not a functional change.
>
>
> Thanks,
>
> Alexander Rukletsov
>
>
Re: Review Request 54570: Added comments around some health check
limitations.
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54570/
-----------------------------------------------------------
(Updated Dec. 9, 2016, 3:11 p.m.)
Review request for mesos, Gast�n Kleiman, haosdent huang, and Till Toenshoff.
Repository: mesos
Description
-------
See summary.
Diffs (updated)
-----
docs/health-checks.md 9e3be78b8900143c2cbb8c970ac6acee1b3f4bb5
src/health-check/health_checker.cpp c0d150a014b7debf23b58982efe335a189d32c7b
Diff: https://reviews.apache.org/r/54570/diff/
Testing
-------
None: Not a functional change.
Thanks,
Alexander Rukletsov