[jira] [Comment Edited] (JCR-4625) ParsingNameResolver.getQName(...) must not throw IllegalNameException for empty string

["Julian Reschke (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/JCR-4625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17165734#comment-17165734 ] 

Julian Reschke edited comment on JCR-4625 at 7/27/20, 2:04 PM:
---------------------------------------------------------------

I think I disagree. The Javadoc says that this methods expects a "JCR Name". That is defined in <https://docs.adobe.com/docs/en/spec/jcr/2.0/3_Repository_Model.html#3.2%20Names>, and local name is not allowed to be empty. IOW, the name of the root node is not a "JCR name".


was (Author: reschke):
I think I disagree. The Javadoc says that this methods expects a "JCR Name". That is defined in <https://docs.adobe.com/docs/en/spec/jcr/2.0/3_Repository_Model.html#3.2%20Names>, and local name is not allowed to be empty.

> ParsingNameResolver.getQName(...) must not throw IllegalNameException for empty string
> --------------------------------------------------------------------------------------
>
>                 Key: JCR-4625
>                 URL: https://issues.apache.org/jira/browse/JCR-4625
>             Project: Jackrabbit Content Repository
>          Issue Type: Bug
>          Components: jackrabbit-spi-commons
>    Affects Versions: 2.21.3
>            Reporter: Konrad Windszus
>            Priority: Major
>
> According to [https://docs.adobe.com/docs/en/spec/jcr/2.0/3_Repository_Model.html#3.1.3%20Names]
> {quote}The name of the root node of a workspace is always ““ (the empty string).{quote}
> Still https://github.com/apache/jackrabbit/blob/b23d6734381e49f236c3705820126803555608b5/jackrabbit-spi-commons/src/main/java/org/apache/jackrabbit/spi/commons/conversion/ParsingNameResolver.java#L63 throws an {{IllegalNameException}} for the empty string argument.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)