[GitHub] [hadoop] goiri commented on a diff in pull request #5443: YARN-11448 [Federation] Stateless Router Secret Manager

["goiri (via GitHub)" <gi...@apache.org>]

goiri commented on code in PR #5443:
URL: https://github.com/apache/hadoop/pull/5443#discussion_r1122098165


##########
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/token/delegation/AbstractDelegationTokenSecretManager.java:
##########
@@ -67,9 +67,9 @@
 
 @InterfaceAudience.Public
 @InterfaceStability.Evolving
-public abstract 
-class AbstractDelegationTokenSecretManager<TokenIdent 
-extends AbstractDelegationTokenIdentifier> 
+public abstract

Review Comment:
   In general, this is a fairly fundamental class in Hadoop in general.
   I would propose to do a separate JIRA to clean this class up.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org