You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Ross Allen <ro...@mesosphere.io> on 2014/01/13 22:21:29 UTC
Review Request 16828: Added missing trailing slash and 'f' in Makefile.am.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16828/
-----------------------------------------------------------
Review request for mesos.
Repository: mesos-git
Description
-------
Added missing trailing slash and 'f' in Makefile.am.
Commit 2026b0dd2a337e3873283ba501d7a5eb75aa9cfa updated the Makefile
but missed a trailing slash to append the file list.
The .woff font file was also missing an extra 'f', which prevented
make from finding it
Diffs
-----
src/Makefile.am 576023d37540067a4e020c0fe9e2668f41810757
Diff: https://reviews.apache.org/r/16828/diff/
Testing
-------
Thanks,
Ross Allen
Re: Review Request 16828: Added missing trailing slash and 'f' in
Makefile.am.
Posted by Niklas Nielsen <ni...@qni.dk>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16828/#review31657
-----------------------------------------------------------
Ship it!
Ship It!
- Niklas Nielsen
On Jan. 13, 2014, 1:24 p.m., Ross Allen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16828/
> -----------------------------------------------------------
>
> (Updated Jan. 13, 2014, 1:24 p.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Added missing trailing slash and 'f' in Makefile.am.
>
> Commit 2026b0dd2a337e3873283ba501d7a5eb75aa9cfa updated the Makefile
> but missed a trailing slash to append the file list.
>
> The .woff font file was also missing an extra 'f', which prevented
> make from finding it
>
>
> Diffs
> -----
>
> src/Makefile.am 576023d37540067a4e020c0fe9e2668f41810757
>
> Diff: https://reviews.apache.org/r/16828/diff/
>
>
> Testing
> -------
>
> Ran ./bootstrap, ./configure, and make in the build directory. Compilation worked with these fixes.
>
>
> Thanks,
>
> Ross Allen
>
>
Re: Review Request 16828: Added missing trailing slash and 'f' in
Makefile.am.
Posted by Ross Allen <ro...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16828/
-----------------------------------------------------------
(Updated Jan. 13, 2014, 9:24 p.m.)
Review request for mesos and Ben Mahler.
Repository: mesos-git
Description
-------
Added missing trailing slash and 'f' in Makefile.am.
Commit 2026b0dd2a337e3873283ba501d7a5eb75aa9cfa updated the Makefile
but missed a trailing slash to append the file list.
The .woff font file was also missing an extra 'f', which prevented
make from finding it
Diffs
-----
src/Makefile.am 576023d37540067a4e020c0fe9e2668f41810757
Diff: https://reviews.apache.org/r/16828/diff/
Testing (updated)
-------
Ran ./bootstrap, ./configure, and make in the build directory. Compilation worked with these fixes.
Thanks,
Ross Allen
Re: Review Request 16828: Added missing trailing slash and 'f' in
Makefile.am.
Posted by Ross Allen <ro...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16828/
-----------------------------------------------------------
(Updated Jan. 13, 2014, 9:22 p.m.)
Review request for mesos and Ben Mahler.
Repository: mesos-git
Description
-------
Added missing trailing slash and 'f' in Makefile.am.
Commit 2026b0dd2a337e3873283ba501d7a5eb75aa9cfa updated the Makefile
but missed a trailing slash to append the file list.
The .woff font file was also missing an extra 'f', which prevented
make from finding it
Diffs
-----
src/Makefile.am 576023d37540067a4e020c0fe9e2668f41810757
Diff: https://reviews.apache.org/r/16828/diff/
Testing
-------
Thanks,
Ross Allen