You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Tim Armstrong (Code Review)" <ge...@cloudera.org> on 2020/06/02 16:08:53 UTC

[Impala-ASF-CR] IMPALA-9000: clean up misc TODO-MT comments 

Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16023


Change subject: IMPALA-9000: clean up misc TODO-MT comments
......................................................................

IMPALA-9000: clean up misc TODO-MT comments

Filed IMPALA-9812, IMPALA-9811 for misc cleanup tasks. and
IMPALA-9812 for the planner estimation issue in AnalyticPlanner.

Change-Id: Ieeffebf6883427ca88640d4fe57159078516ba11
---
M be/src/runtime/fragment-instance-state.h
M bin/run-all-tests.sh
M common/thrift/ExecStats.thrift
3 files changed, 2 insertions(+), 6 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/23/16023/1
-- 
To view, visit http://gerrit.cloudera.org:8080/16023
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ieeffebf6883427ca88640d4fe57159078516ba11
Gerrit-Change-Number: 16023
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>

[Impala-ASF-CR] IMPALA-9000: clean up misc TODO-MT comments

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16023 )

Change subject: IMPALA-9000: clean up misc TODO-MT comments
......................................................................


Patch Set 3: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/16023
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ieeffebf6883427ca88640d4fe57159078516ba11
Gerrit-Change-Number: 16023
Gerrit-PatchSet: 3
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 02 Jun 2020 19:28:04 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9000: clean up misc TODO-MT comments

Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Hello Joe McDonnell, Bikramjeet Vig, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/16023

to look at the new patch set (#2).

Change subject: IMPALA-9000: clean up misc TODO-MT comments
......................................................................

IMPALA-9000: clean up misc TODO-MT comments

Filed IMPALA-9812, IMPALA-9811 for misc cleanup tasks and
IMPALA-9814 for the planner estimation issue in AnalyticPlanner.

Change-Id: Ieeffebf6883427ca88640d4fe57159078516ba11
---
M be/src/runtime/fragment-instance-state.h
M bin/run-all-tests.sh
M common/thrift/ExecStats.thrift
3 files changed, 2 insertions(+), 6 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/23/16023/2
-- 
To view, visit http://gerrit.cloudera.org:8080/16023
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ieeffebf6883427ca88640d4fe57159078516ba11
Gerrit-Change-Number: 16023
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>

[Impala-ASF-CR] IMPALA-9000: clean up misc TODO-MT comments

Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/16023 )

Change subject: IMPALA-9000: clean up misc TODO-MT comments
......................................................................


Patch Set 1: Code-Review+2

(2 comments)

This makes sense to me. A couple nits about the commit message.

http://gerrit.cloudera.org:8080/#/c/16023/1//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/16023/1//COMMIT_MSG@9
PS1, Line 9: .
Nit: comma


http://gerrit.cloudera.org:8080/#/c/16023/1//COMMIT_MSG@10
PS1, Line 10: IMPALA-9812
IMPALA-9814 is the planner estimation jira.



-- 
To view, visit http://gerrit.cloudera.org:8080/16023
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ieeffebf6883427ca88640d4fe57159078516ba11
Gerrit-Change-Number: 16023
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Comment-Date: Tue, 02 Jun 2020 19:06:53 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-9000: clean up misc TODO-MT comments

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16023 )

Change subject: IMPALA-9000: clean up misc TODO-MT comments
......................................................................


Patch Set 1:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/6194/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/16023
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ieeffebf6883427ca88640d4fe57159078516ba11
Gerrit-Change-Number: 16023
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Comment-Date: Tue, 02 Jun 2020 17:06:13 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9000: clean up misc TODO-MT comments

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16023 )

Change subject: IMPALA-9000: clean up misc TODO-MT comments
......................................................................


Patch Set 3:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/5931/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/16023
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ieeffebf6883427ca88640d4fe57159078516ba11
Gerrit-Change-Number: 16023
Gerrit-PatchSet: 3
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 02 Jun 2020 19:28:05 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9000: clean up misc TODO-MT comments

Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16023 )

Change subject: IMPALA-9000: clean up misc TODO-MT comments
......................................................................


Patch Set 2:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/16023/1//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/16023/1//COMMIT_MSG@9
PS1, Line 9:  
> Nit: comma
Done


http://gerrit.cloudera.org:8080/#/c/16023/1//COMMIT_MSG@10
PS1, Line 10: IMPALA-9814
> IMPALA-9814 is the planner estimation jira.
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/16023
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ieeffebf6883427ca88640d4fe57159078516ba11
Gerrit-Change-Number: 16023
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 02 Jun 2020 19:27:53 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-9000: clean up misc TODO-MT comments

Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16023 )

Change subject: IMPALA-9000: clean up misc TODO-MT comments
......................................................................


Patch Set 2: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/16023
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ieeffebf6883427ca88640d4fe57159078516ba11
Gerrit-Change-Number: 16023
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 02 Jun 2020 19:27:20 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9000: clean up misc TODO-MT comments

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16023 )

Change subject: IMPALA-9000: clean up misc TODO-MT comments
......................................................................


Patch Set 3: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/16023
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ieeffebf6883427ca88640d4fe57159078516ba11
Gerrit-Change-Number: 16023
Gerrit-PatchSet: 3
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 03 Jun 2020 00:50:17 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9000: clean up misc TODO-MT comments

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16023 )

Change subject: IMPALA-9000: clean up misc TODO-MT comments
......................................................................

IMPALA-9000: clean up misc TODO-MT comments

Filed IMPALA-9812, IMPALA-9811 for misc cleanup tasks and
IMPALA-9814 for the planner estimation issue in AnalyticPlanner.

Change-Id: Ieeffebf6883427ca88640d4fe57159078516ba11
Reviewed-on: http://gerrit.cloudera.org:8080/16023
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M be/src/runtime/fragment-instance-state.h
M bin/run-all-tests.sh
M common/thrift/ExecStats.thrift
3 files changed, 2 insertions(+), 6 deletions(-)

Approvals:
  Impala Public Jenkins: Looks good to me, approved; Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/16023
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ieeffebf6883427ca88640d4fe57159078516ba11
Gerrit-Change-Number: 16023
Gerrit-PatchSet: 4
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>