You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@polaris.apache.org by "jbonofre (via GitHub)" <gi...@apache.org> on 2025/03/27 13:40:29 UTC
[PR] Update .asf.yaml adding dismiss_stale_reviews to true and require_last_push_approval to false [polaris]
jbonofre opened a new pull request, #1265:
URL: https://github.com/apache/polaris/pull/1265
With https://github.com/apache/infrastructure-asfyaml/pull/55 I added the `require_last_push_approval` option to `.asf.yaml` (it was not possible to change it before).
This PR updates `.asf.yaml` with:
* `dismiss_stale_reviews: true`
* `require_last_push_approval: false`
See https://github.com/apache/infrastructure-asfyaml?tab=readme-ov-file#branch-protection for details.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update .asf.yaml adding dismiss_stale_reviews to true and require_last_push_approval to false [polaris]
Posted by "dimas-b (via GitHub)" <gi...@apache.org>.
dimas-b commented on code in PR #1265:
URL: https://github.com/apache/polaris/pull/1265#discussion_r2018758246
##########
.asf.yaml:
##########
@@ -41,6 +41,8 @@ github:
main:
required_pull_request_reviews:
require_code_owner_reviews: false
+ dismiss_stale_reviews: true
Review Comment:
So, IIUC, `dismiss_stale_reviews` will automatically dismiss approvals _and_ "request changes" when new commits are added?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update .asf.yaml adding dismiss_stale_reviews to true and require_last_push_approval to false [polaris]
Posted by "eric-maynard (via GitHub)" <gi...@apache.org>.
eric-maynard commented on code in PR #1265:
URL: https://github.com/apache/polaris/pull/1265#discussion_r2019718951
##########
.asf.yaml:
##########
@@ -41,6 +41,8 @@ github:
main:
required_pull_request_reviews:
require_code_owner_reviews: false
+ dismiss_stale_reviews: true
Review Comment:
I agree that's a little awkward... but we already have the option to manually do that dismissal, so automating it doesn't really move the needle too much imo.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update .asf.yaml adding dismiss_stale_reviews to true and require_last_push_approval to false [polaris]
Posted by "dimas-b (via GitHub)" <gi...@apache.org>.
dimas-b commented on code in PR #1265:
URL: https://github.com/apache/polaris/pull/1265#discussion_r2018754366
##########
.asf.yaml:
##########
@@ -41,6 +41,8 @@ github:
main:
required_pull_request_reviews:
require_code_owner_reviews: false
+ dismiss_stale_reviews: true
Review Comment:
Thx!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update .asf.yaml adding dismiss_stale_reviews to true and require_last_push_approval to false [polaris]
Posted by "jbonofre (via GitHub)" <gi...@apache.org>.
jbonofre commented on code in PR #1265:
URL: https://github.com/apache/polaris/pull/1265#discussion_r2020214607
##########
.asf.yaml:
##########
@@ -41,6 +41,8 @@ github:
main:
required_pull_request_reviews:
require_code_owner_reviews: false
+ dismiss_stale_reviews: true
Review Comment:
My understanding is that an approval will be still valid. I propose to merge and try 😄 If it's worse than before, I will revert.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update .asf.yaml adding dismiss_stale_reviews to true and require_last_push_approval to false [polaris]
Posted by "dimas-b (via GitHub)" <gi...@apache.org>.
dimas-b commented on code in PR #1265:
URL: https://github.com/apache/polaris/pull/1265#discussion_r2016961907
##########
.asf.yaml:
##########
@@ -41,6 +41,8 @@ github:
main:
required_pull_request_reviews:
require_code_owner_reviews: false
+ dismiss_stale_reviews: true
Review Comment:
sorry, @jbonofre , I could not find any description for this option in the README linked from the PR :sweat_smile: Could you add a comment to explain how it works?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update .asf.yaml adding dismiss_stale_reviews to true and require_last_push_approval to false [polaris]
Posted by "jbonofre (via GitHub)" <gi...@apache.org>.
jbonofre commented on code in PR #1265:
URL: https://github.com/apache/polaris/pull/1265#discussion_r2018311297
##########
.asf.yaml:
##########
@@ -41,6 +41,8 @@ github:
main:
required_pull_request_reviews:
require_code_owner_reviews: false
+ dismiss_stale_reviews: true
Review Comment:
The documentation is light here, I agree 😄 (https://github.com/apache/infrastructure-asfyaml/blob/main/README.md?plain=1#L388).
It basically corresponds to this GitHub configuration:
* https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/dismissing-a-pull-request-review
* https://docs.github.com/en/repositories/configuring-branches-and-merges-in-your-repository/managing-protected-branches/about-protected-branches#require-pull-request-reviews-before-merging
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update .asf.yaml adding dismiss_stale_reviews to true and require_last_push_approval to false [polaris]
Posted by "jbonofre (via GitHub)" <gi...@apache.org>.
jbonofre commented on code in PR #1265:
URL: https://github.com/apache/polaris/pull/1265#discussion_r2020214607
##########
.asf.yaml:
##########
@@ -41,6 +41,8 @@ github:
main:
required_pull_request_reviews:
require_code_owner_reviews: false
+ dismiss_stale_reviews: true
Review Comment:
An approval will be needed as soon as a PR is updated (not stale anymore). I propose to merge and try 😄 If it's worse than before, I will revert.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update .asf.yaml adding dismiss_stale_reviews to true and require_last_push_approval to false [polaris]
Posted by "jbonofre (via GitHub)" <gi...@apache.org>.
jbonofre merged PR #1265:
URL: https://github.com/apache/polaris/pull/1265
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org