You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Andrei Budnik <ab...@mesosphere.com> on 2019/08/14 16:12:15 UTC
Review Request 71137: Added a test to ensure composing containerizer
preserves request order.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71137/
-----------------------------------------------------------
Review request for mesos, Gilbert Song, Greg Mann, and Qian Zhang.
Summary (updated)
-----------------
Added a test to ensure composing containerizer preserves request order.
Bugs: MESOS-9887
https://issues.apache.org/jira/browse/MESOS-9887
Repository: mesos
Description (updated)
-------
Added a test to ensure composing containerizer preserves request order.
Diffs (updated)
-----
src/tests/containerizer/composing_containerizer_tests.cpp 4236bd4ea97f5d2cf91601de34b89e63c85a6fa9
src/tests/containerizer/mock_containerizer.hpp 8700257a9347199ed6e32b8b6b2a58787d68af03
src/tests/slave_tests.cpp 1a926029a9f81eb0c43e9cddd73c318557760c27
Diff: https://reviews.apache.org/r/71137/diff/1/
Testing (updated)
-------
1. manual testing described in MESOS-9887
2. internal CI
Thanks,
Andrei Budnik
Re: Review Request 71137: Added a test to ensure composing
containerizer preserves request order.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71137/#review217210
-----------------------------------------------------------
Patch looks great!
Reviews applied: [71289, 71137]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On Aug. 14, 2019, 4:12 p.m., Andrei Budnik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71137/
> -----------------------------------------------------------
>
> (Updated Aug. 14, 2019, 4:12 p.m.)
>
>
> Review request for mesos, Gilbert Song, Greg Mann, and Qian Zhang.
>
>
> Bugs: MESOS-9887
> https://issues.apache.org/jira/browse/MESOS-9887
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added a test to ensure composing containerizer preserves request order.
>
>
> Diffs
> -----
>
> src/tests/containerizer/composing_containerizer_tests.cpp 4236bd4ea97f5d2cf91601de34b89e63c85a6fa9
> src/tests/containerizer/mock_containerizer.hpp 8700257a9347199ed6e32b8b6b2a58787d68af03
> src/tests/slave_tests.cpp 1a926029a9f81eb0c43e9cddd73c318557760c27
>
>
> Diff: https://reviews.apache.org/r/71137/diff/1/
>
>
> Testing
> -------
>
> 1. manual testing described in MESOS-9887
> 2. internal CI
>
>
> Thanks,
>
> Andrei Budnik
>
>
Re: Review Request 71137: Added a test to ensure composing
containerizer preserves request order.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71137/#review217311
-----------------------------------------------------------
Patch looks great!
Reviews applied: [71289, 71137]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On Aug. 14, 2019, 4:12 p.m., Andrei Budnik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71137/
> -----------------------------------------------------------
>
> (Updated Aug. 14, 2019, 4:12 p.m.)
>
>
> Review request for mesos, Gilbert Song, Greg Mann, and Qian Zhang.
>
>
> Bugs: MESOS-9887
> https://issues.apache.org/jira/browse/MESOS-9887
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added a test to ensure composing containerizer preserves request order.
>
>
> Diffs
> -----
>
> src/tests/containerizer/composing_containerizer_tests.cpp 4236bd4ea97f5d2cf91601de34b89e63c85a6fa9
> src/tests/slave_tests.cpp 02b65a925a52d09b0a9183d3288b9ab363b98bc5
>
>
> Diff: https://reviews.apache.org/r/71137/diff/2/
>
>
> Testing
> -------
>
> 1. manual testing described in MESOS-9887
> 2. internal CI
>
>
> Thanks,
>
> Andrei Budnik
>
>