[GitHub] [incubator-superset] graceguo-supercat edited a comment on pull request #11137: fix: enable consistent etag across workers and force no-cache for dashboards

[GitBox <gi...@apache.org>]

graceguo-supercat edited a comment on pull request #11137:
URL: https://github.com/apache/incubator-superset/pull/11137#issuecomment-702874881


   For dashboard requests:
   If you enable dashboard etag header feature, dashboard metadata will be stored in browser cache. But for every new dashboard request, browser still sends out request to server-side to validate if cache is still valid, to make sure dashboard metadata is in-sync. If server-side response 304, browser will use cached data. otherwise, server-side will response 200 with newer version of dashboard metadata. so this feature only save server-side processing time but still need a roundtrip.
   
   For explore_json requests:
   If you use GET request for explore_json, query results will be cached in browser, and browser will not send requests to server-side until the cache expired (set by Expire header). This is current behavior (per #7032), this PR and #10963 will not change it.
   
   cc @betodealmeida and @bkyryliuk since you are interested in this topic.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org