[GitHub] [apisix-helm-chart] lzxuan commented on a diff in pull request #278: feat: support creating ServiceAccount and RBAC

[GitBox <gi...@apache.org>]

lzxuan commented on code in PR #278:
URL: https://github.com/apache/apisix-helm-chart/pull/278#discussion_r950676067


##########
charts/apisix/values.yaml:
##########
@@ -120,6 +120,14 @@ apisix:
 nameOverride: ""
 fullnameOverride: ""
 
+serviceAccount:
+  create: false  # Set to `true` to create ServiceAccount for Kubernetes service discovery.
+  annotations: {}
+  name: ""
+
+rbac:
+  create: false  # Set to `true` to create RBAC resources for Kubernetes service discovery.

Review Comment:
   I've updated accordingly, thanks for the recommendation!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org