[jira] [Commented] (PHOENIX-5219) Fix ConcurrentMutationsIT testLockUntilMVCCAdvanced and testRowLockDuringPreBatchMutateWhenIndexed failures on the master branch

["Anoop Sam John (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/PHOENIX-5219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16806994#comment-16806994 ] 

Anoop Sam John commented on PHOENIX-5219:
-----------------------------------------

So here we are changing the TS on existing cells? Or these are cells created by Phoenix CP?

> Fix ConcurrentMutationsIT testLockUntilMVCCAdvanced and testRowLockDuringPreBatchMutateWhenIndexed failures on the master branch
> --------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: PHOENIX-5219
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-5219
>             Project: Phoenix
>          Issue Type: Test
>            Reporter: Thomas D'Silva
>            Assignee: Thomas D'Silva
>            Priority: Major
>             Fix For: 5.1.0
>
>         Attachments: PHOENIX-5219.patch
>
>
> These tests are failing because when we set the timestamp in {{Indexer.preBatchMutateWithExceptions}} we call {{KeyValueUtil.ensureKeyValues}} on the list of cells and then call {{KeyValue.getTimestampOffset}}
> Pre 2.0 the cells objects are NoTagsKeyValue (which extend KeyValue). In 2.0 they are NoTagsByteBufferKeyValue (which doesn't extend KeyValue) so {{KeyValueUtil.ensureKeyValues}} returns a new list of objects on which we set the timestamp. 
> The fix us to use  {{CellUtil.setTimestamp}} to the set the timestamp directly on the cell. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)