You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@reef.apache.org by ma...@apache.org on 2015/11/04 21:22:46 UTC
incubator-reef git commit: [REEF-907] Upgrade Maven checkstyle
versions and fix the code
Repository: incubator-reef
Updated Branches:
refs/heads/master e426de4be -> d856969f6
[REEF-907] Upgrade Maven checkstyle versions and fix the code
This upgrades maven-checkstyle-plugin version from 2.15 to 2.17
and checkstyle version from 6.6 to 6.12. This also fixes newly
detected violations of checks, primarily RedundantModifier.
JIRA:
[REEF-907](https://issues.apache.org/jira/browse/REEF-907)
Pull Request:
This closes #611
Project: http://git-wip-us.apache.org/repos/asf/incubator-reef/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-reef/commit/d856969f
Tree: http://git-wip-us.apache.org/repos/asf/incubator-reef/tree/d856969f
Diff: http://git-wip-us.apache.org/repos/asf/incubator-reef/diff/d856969f
Branch: refs/heads/master
Commit: d856969f60c1a51d18fccebf078325a81cec5581
Parents: e426de4
Author: Dongjoon Hyun <do...@apache.org>
Authored: Thu Nov 5 04:15:28 2015 +0900
Committer: Mariia Mykhailova <ma...@apache.org>
Committed: Wed Nov 4 12:20:35 2015 -0800
----------------------------------------------------------------------
.../evaluator/EvaluatorDescriptorImpl.java | 8 +++---
.../driver/evaluator/FailedEvaluatorImpl.java | 8 +++---
.../common/driver/idle/DriverIdleManager.java | 4 +--
.../runtime/common/utils/DispatchingEStage.java | 2 +-
.../java/org/apache/reef/util/DeadlockInfo.java | 2 +-
.../hellohttp/HttpServerShellCmdHandler.java | 2 +-
.../examples/scheduler/driver/TaskEntity.java | 2 +-
.../io/data/loading/api/DistributedDataSet.java | 4 +--
.../data/loading/impl/WritableSerializer.java | 4 +--
.../io/network/group/impl/task/InitHandler.java | 2 +-
.../impl/NetworkConnectionServiceImpl.java | 2 +-
.../impl/NetworkConnectionServiceMessage.java | 2 +-
.../reef/io/network/impl/NetworkService.java | 4 +--
.../reef/io/network/naming/NameClient.java | 2 +-
.../reef/io/network/naming/NameServerImpl.java | 6 ++---
.../io/storage/local/CodecFileAccumulator.java | 2 +-
.../PoissonPoisonedContextStartHandler.java | 2 +-
.../task/PoissonPoisonedTaskStartHandler.java | 2 +-
.../reef/runtime/hdinsight/cli/TFileParser.java | 2 +-
.../reef/runtime/local/client/DriverFiles.java | 2 +-
.../local/client/LocalJobSubmissionHandler.java | 2 +-
.../driver/LocalResourceLaunchHandler.java | 2 +-
.../reef/tang/formats/ConfigurationModule.java | 2 +-
.../reef/tang/implementation/TangImpl.java | 2 +-
.../implementation/avro/AvroClassHierarchy.java | 2 +-
.../org/apache/reef/tang/TestBindSingleton.java | 2 +-
.../reef/tang/TestImplicitConversions.java | 2 +-
.../java/org/apache/reef/tang/TestTang.java | 24 ++++++++---------
.../org/apache/reef/tang/TestTweetExample.java | 8 +++---
.../tang/formats/TestConfigurationModule.java | 4 +--
.../tang/implementation/TestClassHierarchy.java | 28 ++++++++++----------
.../java/TestParameterParser.java | 14 +++++-----
.../reef/tang/test/RootImplementation.java | 28 ++++++++++----------
.../reef/tang/test/SetInterfaceImplOne.java | 2 +-
.../evaluatorsize/EvaluatorSizeTestDriver.java | 4 +--
.../tests/evaluatorsize/MemorySizeTask.java | 2 +-
.../tests/files/FileResourceTestDriver.java | 8 +++---
.../apache/reef/util/cache/WrappedValue.java | 2 +-
.../reef/util/cache/ImmediateInteger.java | 2 +-
.../apache/reef/util/cache/SleepingInteger.java | 2 +-
.../wake/examples/accumulate/CombinerStage.java | 2 +-
.../netty/AbstractNettyEventListener.java | 2 +-
.../netty/ChunkedReadWriteHandler.java | 2 +-
.../transport/netty/LoggingLinkListener.java | 4 +--
.../transport/netty/NettyChannelHandler.java | 2 +-
.../netty/NettyChannelInitializer.java | 2 +-
.../netty/NettyClientEventListener.java | 2 +-
.../netty/NettyServerEventListener.java | 2 +-
.../wake/test/PubSubThreadPoolStageTest.java | 2 +-
.../reef/wake/test/examples/SkipListTest.java | 4 +--
.../wake/test/remote/RemoteManagerTest.java | 8 +++---
.../reef/wake/test/remote/TestRemote.java | 2 +-
.../apache/reef/wake/test/time/ClockTest.java | 6 ++---
.../reef/webserver/TestHttpConfiguration.java | 2 +-
.../apache/reef/webserver/TestJettyHandler.java | 2 +-
.../webserver/TestReefEventStateManager.java | 6 ++---
pom.xml | 4 +--
57 files changed, 130 insertions(+), 130 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/d856969f/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/driver/evaluator/EvaluatorDescriptorImpl.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/driver/evaluator/EvaluatorDescriptorImpl.java b/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/driver/evaluator/EvaluatorDescriptorImpl.java
index c8637e3..ed9fefc 100644
--- a/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/driver/evaluator/EvaluatorDescriptorImpl.java
+++ b/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/driver/evaluator/EvaluatorDescriptorImpl.java
@@ -36,10 +36,10 @@ final class EvaluatorDescriptorImpl implements EvaluatorDescriptor {
private final int numberOfCores;
private EvaluatorProcess process;
- public EvaluatorDescriptorImpl(final NodeDescriptor nodeDescriptor,
- final int megaBytes,
- final int numberOfCores,
- final EvaluatorProcess process) {
+ EvaluatorDescriptorImpl(final NodeDescriptor nodeDescriptor,
+ final int megaBytes,
+ final int numberOfCores,
+ final EvaluatorProcess process) {
this.nodeDescriptor = nodeDescriptor;
this.megaBytes = megaBytes;
this.numberOfCores = numberOfCores;
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/d856969f/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/driver/evaluator/FailedEvaluatorImpl.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/driver/evaluator/FailedEvaluatorImpl.java b/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/driver/evaluator/FailedEvaluatorImpl.java
index 80b08ce..6db2bec 100644
--- a/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/driver/evaluator/FailedEvaluatorImpl.java
+++ b/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/driver/evaluator/FailedEvaluatorImpl.java
@@ -37,10 +37,10 @@ final class FailedEvaluatorImpl implements FailedEvaluator {
private final List<FailedContext> ctx;
private final Optional<FailedTask> task;
- public FailedEvaluatorImpl(final EvaluatorException ex,
- final List<FailedContext> ctx,
- final Optional<FailedTask> task,
- final String id) {
+ FailedEvaluatorImpl(final EvaluatorException ex,
+ final List<FailedContext> ctx,
+ final Optional<FailedTask> task,
+ final String id) {
this.ex = ex;
this.ctx = ctx;
this.task = task;
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/d856969f/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/driver/idle/DriverIdleManager.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/driver/idle/DriverIdleManager.java b/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/driver/idle/DriverIdleManager.java
index f100395..cdc71dd 100644
--- a/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/driver/idle/DriverIdleManager.java
+++ b/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/driver/idle/DriverIdleManager.java
@@ -57,8 +57,8 @@ public final class DriverIdleManager {
for (final DriverIdlenessSource idlenessSource : this.idlenessSources) {
final IdleMessage idleMessage = idlenessSource.getIdleStatus();
- LOG.log(IDLE_REASONS_LEVEL, "[{0}] is reporting {1} because [{2}]."
- , new Object[]{idleMessage.getComponentName(), idleMessage.isIdle() ? "idle" : "not idle",
+ LOG.log(IDLE_REASONS_LEVEL, "[{0}] is reporting {1} because [{2}].",
+ new Object[]{idleMessage.getComponentName(), idleMessage.isIdle() ? "idle" : "not idle",
idleMessage.getReason()}
);
isIdle &= idleMessage.isIdle();
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/d856969f/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/utils/DispatchingEStage.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/utils/DispatchingEStage.java b/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/utils/DispatchingEStage.java
index e6e8e9a..36c0aee 100644
--- a/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/utils/DispatchingEStage.java
+++ b/lang/java/reef-common/src/main/java/org/apache/reef/runtime/common/utils/DispatchingEStage.java
@@ -137,7 +137,7 @@ public final class DispatchingEStage implements AutoCloseable {
private final Object message;
@SuppressWarnings("unchecked")
- public <T, U extends T> DelayedOnNext(final EventHandler<T> handler, final U message) {
+ <T, U extends T> DelayedOnNext(final EventHandler<T> handler, final U message) {
this.handler = (EventHandler<Object>) handler;
this.message = message;
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/d856969f/lang/java/reef-common/src/main/java/org/apache/reef/util/DeadlockInfo.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-common/src/main/java/org/apache/reef/util/DeadlockInfo.java b/lang/java/reef-common/src/main/java/org/apache/reef/util/DeadlockInfo.java
index a5f49a8..5f5e0e2 100644
--- a/lang/java/reef-common/src/main/java/org/apache/reef/util/DeadlockInfo.java
+++ b/lang/java/reef-common/src/main/java/org/apache/reef/util/DeadlockInfo.java
@@ -40,7 +40,7 @@ final class DeadlockInfo {
private static final ThreadInfo[] EMPTY_ARRAY = new ThreadInfo[0];
private final Map<ThreadInfo, Map<StackTraceElement, List<MonitorInfo>>> monitorLockedElements;
- public DeadlockInfo() {
+ DeadlockInfo() {
mxBean = ManagementFactory.getThreadMXBean();
deadlockedThreadsIDs = mxBean.findDeadlockedThreads();
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/d856969f/lang/java/reef-examples/src/main/java/org/apache/reef/examples/hellohttp/HttpServerShellCmdHandler.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-examples/src/main/java/org/apache/reef/examples/hellohttp/HttpServerShellCmdHandler.java b/lang/java/reef-examples/src/main/java/org/apache/reef/examples/hellohttp/HttpServerShellCmdHandler.java
index f5c233d..35fa866 100644
--- a/lang/java/reef-examples/src/main/java/org/apache/reef/examples/hellohttp/HttpServerShellCmdHandler.java
+++ b/lang/java/reef-examples/src/main/java/org/apache/reef/examples/hellohttp/HttpServerShellCmdHandler.java
@@ -68,7 +68,7 @@ class HttpServerShellCmdHandler implements HttpHandler {
* HttpServerShellEventHandler constructor.
*/
@Inject
- public HttpServerShellCmdHandler(final InjectionFuture<HttpShellJobDriver.ClientMessageHandler> messageHandler) {
+ HttpServerShellCmdHandler(final InjectionFuture<HttpShellJobDriver.ClientMessageHandler> messageHandler) {
this.messageHandler = messageHandler;
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/d856969f/lang/java/reef-examples/src/main/java/org/apache/reef/examples/scheduler/driver/TaskEntity.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-examples/src/main/java/org/apache/reef/examples/scheduler/driver/TaskEntity.java b/lang/java/reef-examples/src/main/java/org/apache/reef/examples/scheduler/driver/TaskEntity.java
index bb29228..ad4ebef 100644
--- a/lang/java/reef-examples/src/main/java/org/apache/reef/examples/scheduler/driver/TaskEntity.java
+++ b/lang/java/reef-examples/src/main/java/org/apache/reef/examples/scheduler/driver/TaskEntity.java
@@ -27,7 +27,7 @@ final class TaskEntity {
private final int taskId;
private final String command;
- public TaskEntity(final int taskId, final String command) {
+ TaskEntity(final int taskId, final String command) {
this.taskId = taskId;
this.command = command;
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/d856969f/lang/java/reef-io/src/main/java/org/apache/reef/io/data/loading/api/DistributedDataSet.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-io/src/main/java/org/apache/reef/io/data/loading/api/DistributedDataSet.java b/lang/java/reef-io/src/main/java/org/apache/reef/io/data/loading/api/DistributedDataSet.java
index 24f82ce..d1f2c05 100644
--- a/lang/java/reef-io/src/main/java/org/apache/reef/io/data/loading/api/DistributedDataSet.java
+++ b/lang/java/reef-io/src/main/java/org/apache/reef/io/data/loading/api/DistributedDataSet.java
@@ -83,9 +83,9 @@ public final class DistributedDataSet implements Iterable<DistributedDataSetPart
private final List<DistributedDataSetPartition> partitions;
private int position;
- public DistributedDataSetIterator(
+ DistributedDataSetIterator(
final Collection<DistributedDataSetPartition> partitions) {
- this.partitions = new LinkedList<DistributedDataSetPartition>(partitions);
+ this.partitions = new LinkedList<>(partitions);
position = 0;
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/d856969f/lang/java/reef-io/src/main/java/org/apache/reef/io/data/loading/impl/WritableSerializer.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-io/src/main/java/org/apache/reef/io/data/loading/impl/WritableSerializer.java b/lang/java/reef-io/src/main/java/org/apache/reef/io/data/loading/impl/WritableSerializer.java
index 6021d45..d0dd07a 100644
--- a/lang/java/reef-io/src/main/java/org/apache/reef/io/data/loading/impl/WritableSerializer.java
+++ b/lang/java/reef-io/src/main/java/org/apache/reef/io/data/loading/impl/WritableSerializer.java
@@ -54,11 +54,11 @@ public final class WritableSerializer {
static class WritableCodec<E extends Writable> implements Codec<E> {
private final JobConf jobConf;
- public WritableCodec(final JobConf jobConf) {
+ WritableCodec(final JobConf jobConf) {
this.jobConf = jobConf;
}
- public WritableCodec() {
+ WritableCodec() {
this.jobConf = new JobConf();
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/d856969f/lang/java/reef-io/src/main/java/org/apache/reef/io/network/group/impl/task/InitHandler.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-io/src/main/java/org/apache/reef/io/network/group/impl/task/InitHandler.java b/lang/java/reef-io/src/main/java/org/apache/reef/io/network/group/impl/task/InitHandler.java
index a60216d..733154d 100644
--- a/lang/java/reef-io/src/main/java/org/apache/reef/io/network/group/impl/task/InitHandler.java
+++ b/lang/java/reef-io/src/main/java/org/apache/reef/io/network/group/impl/task/InitHandler.java
@@ -32,7 +32,7 @@ class InitHandler implements EventHandler<GroupCommOperator> {
private ParentDeadException exception = null;
private final CountDownLatch initLatch;
- public InitHandler(final CountDownLatch initLatch) {
+ InitHandler(final CountDownLatch initLatch) {
this.initLatch = initLatch;
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/d856969f/lang/java/reef-io/src/main/java/org/apache/reef/io/network/impl/NetworkConnectionServiceImpl.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-io/src/main/java/org/apache/reef/io/network/impl/NetworkConnectionServiceImpl.java b/lang/java/reef-io/src/main/java/org/apache/reef/io/network/impl/NetworkConnectionServiceImpl.java
index aa79597..6e63f30 100644
--- a/lang/java/reef-io/src/main/java/org/apache/reef/io/network/impl/NetworkConnectionServiceImpl.java
+++ b/lang/java/reef-io/src/main/java/org/apache/reef/io/network/impl/NetworkConnectionServiceImpl.java
@@ -245,7 +245,7 @@ public final class NetworkConnectionServiceImpl implements NetworkConnectionServ
@Override
public void close() throws Exception {
- if (isClosed.compareAndSet(false , true)) {
+ if (isClosed.compareAndSet(false, true)) {
LOG.log(Level.FINE, "Shutting down");
this.nameServiceRegisteringStage.close();
this.nameServiceUnregisteringStage.close();
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/d856969f/lang/java/reef-io/src/main/java/org/apache/reef/io/network/impl/NetworkConnectionServiceMessage.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-io/src/main/java/org/apache/reef/io/network/impl/NetworkConnectionServiceMessage.java b/lang/java/reef-io/src/main/java/org/apache/reef/io/network/impl/NetworkConnectionServiceMessage.java
index 910c1e0..854e1c7 100644
--- a/lang/java/reef-io/src/main/java/org/apache/reef/io/network/impl/NetworkConnectionServiceMessage.java
+++ b/lang/java/reef-io/src/main/java/org/apache/reef/io/network/impl/NetworkConnectionServiceMessage.java
@@ -45,7 +45,7 @@ final class NetworkConnectionServiceMessage<T> implements Message<T> {
* @param destId the destination identifier of NetworkConnectionService
* @param messages the list of messages
*/
- public NetworkConnectionServiceMessage(
+ NetworkConnectionServiceMessage(
final String connFactoryId,
final Identifier srcId,
final Identifier destId,
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/d856969f/lang/java/reef-io/src/main/java/org/apache/reef/io/network/impl/NetworkService.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-io/src/main/java/org/apache/reef/io/network/impl/NetworkService.java b/lang/java/reef-io/src/main/java/org/apache/reef/io/network/impl/NetworkService.java
index d19bd67..679f1de 100644
--- a/lang/java/reef-io/src/main/java/org/apache/reef/io/network/impl/NetworkService.java
+++ b/lang/java/reef-io/src/main/java/org/apache/reef/io/network/impl/NetworkService.java
@@ -195,8 +195,8 @@ class MessageHandler<T> implements EventHandler<TransportEvent> {
private final EventHandler<Message<T>> handler;
private final NSMessageCodec<T> codec;
- public MessageHandler(final EventHandler<Message<T>> handler,
- final Codec<T> codec, final IdentifierFactory factory) {
+ MessageHandler(final EventHandler<Message<T>> handler,
+ final Codec<T> codec, final IdentifierFactory factory) {
this.handler = handler;
this.codec = new NSMessageCodec<>(codec, factory);
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/d856969f/lang/java/reef-io/src/main/java/org/apache/reef/io/network/naming/NameClient.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-io/src/main/java/org/apache/reef/io/network/naming/NameClient.java b/lang/java/reef-io/src/main/java/org/apache/reef/io/network/naming/NameClient.java
index 50d4c09..c7cdec9 100644
--- a/lang/java/reef-io/src/main/java/org/apache/reef/io/network/naming/NameClient.java
+++ b/lang/java/reef-io/src/main/java/org/apache/reef/io/network/naming/NameClient.java
@@ -168,7 +168,7 @@ class NamingClientEventHandler implements EventHandler<TransportEvent> {
private final EventHandler<NamingMessage> handler;
private final Codec<NamingMessage> codec;
- public NamingClientEventHandler(
+ NamingClientEventHandler(
final EventHandler<NamingMessage> handler, final Codec<NamingMessage> codec) {
this.handler = handler;
this.codec = codec;
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/d856969f/lang/java/reef-io/src/main/java/org/apache/reef/io/network/naming/NameServerImpl.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-io/src/main/java/org/apache/reef/io/network/naming/NameServerImpl.java b/lang/java/reef-io/src/main/java/org/apache/reef/io/network/naming/NameServerImpl.java
index bbb8ccb..1af96c1 100644
--- a/lang/java/reef-io/src/main/java/org/apache/reef/io/network/naming/NameServerImpl.java
+++ b/lang/java/reef-io/src/main/java/org/apache/reef/io/network/naming/NameServerImpl.java
@@ -264,7 +264,7 @@ class NamingLookupRequestHandler implements EventHandler<NamingLookupRequest> {
private final NameServer server;
private final Codec<NamingMessage> codec;
- public NamingLookupRequestHandler(final NameServer server, final Codec<NamingMessage> codec) {
+ NamingLookupRequestHandler(final NameServer server, final Codec<NamingMessage> codec) {
this.server = server;
this.codec = codec;
}
@@ -288,7 +288,7 @@ class NamingRegisterRequestHandler implements EventHandler<NamingRegisterRequest
private final NameServer server;
private final Codec<NamingMessage> codec;
- public NamingRegisterRequestHandler(final NameServer server, final Codec<NamingMessage> codec) {
+ NamingRegisterRequestHandler(final NameServer server, final Codec<NamingMessage> codec) {
this.server = server;
this.codec = codec;
}
@@ -308,7 +308,7 @@ class NamingUnregisterRequestHandler implements EventHandler<NamingUnregisterReq
private final NameServer server;
- public NamingUnregisterRequestHandler(final NameServer server) {
+ NamingUnregisterRequestHandler(final NameServer server) {
this.server = server;
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/d856969f/lang/java/reef-io/src/main/java/org/apache/reef/io/storage/local/CodecFileAccumulator.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-io/src/main/java/org/apache/reef/io/storage/local/CodecFileAccumulator.java b/lang/java/reef-io/src/main/java/org/apache/reef/io/storage/local/CodecFileAccumulator.java
index f4bd66e..fabec60 100644
--- a/lang/java/reef-io/src/main/java/org/apache/reef/io/storage/local/CodecFileAccumulator.java
+++ b/lang/java/reef-io/src/main/java/org/apache/reef/io/storage/local/CodecFileAccumulator.java
@@ -30,7 +30,7 @@ final class CodecFileAccumulator<T> implements Accumulator<T> {
private final Codec<T> codec;
private final ObjectOutputStream out;
- public CodecFileAccumulator(final Codec<T> codec, final File file) throws IOException {
+ CodecFileAccumulator(final Codec<T> codec, final File file) throws IOException {
this.codec = codec;
this.out = new ObjectOutputStream(new BufferedOutputStream(new FileOutputStream(file)));
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/d856969f/lang/java/reef-poison/src/main/java/org/apache/reef/poison/context/PoissonPoisonedContextStartHandler.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-poison/src/main/java/org/apache/reef/poison/context/PoissonPoisonedContextStartHandler.java b/lang/java/reef-poison/src/main/java/org/apache/reef/poison/context/PoissonPoisonedContextStartHandler.java
index 7b1138f..8d2a353 100644
--- a/lang/java/reef-poison/src/main/java/org/apache/reef/poison/context/PoissonPoisonedContextStartHandler.java
+++ b/lang/java/reef-poison/src/main/java/org/apache/reef/poison/context/PoissonPoisonedContextStartHandler.java
@@ -38,7 +38,7 @@ final class PoissonPoisonedContextStartHandler implements EventHandler<ContextSt
private final int timeToCrash;
@Inject
- public PoissonPoisonedContextStartHandler(
+ PoissonPoisonedContextStartHandler(
@Parameter(CrashProbability.class) final double lambda, final Clock clock) {
this.clock = clock;
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/d856969f/lang/java/reef-poison/src/main/java/org/apache/reef/poison/task/PoissonPoisonedTaskStartHandler.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-poison/src/main/java/org/apache/reef/poison/task/PoissonPoisonedTaskStartHandler.java b/lang/java/reef-poison/src/main/java/org/apache/reef/poison/task/PoissonPoisonedTaskStartHandler.java
index 7a95c26..d3111fa 100644
--- a/lang/java/reef-poison/src/main/java/org/apache/reef/poison/task/PoissonPoisonedTaskStartHandler.java
+++ b/lang/java/reef-poison/src/main/java/org/apache/reef/poison/task/PoissonPoisonedTaskStartHandler.java
@@ -38,7 +38,7 @@ final class PoissonPoisonedTaskStartHandler implements EventHandler<TaskStart> {
private final int timeToCrash;
@Inject
- public PoissonPoisonedTaskStartHandler(
+ PoissonPoisonedTaskStartHandler(
@Parameter(CrashProbability.class) final double lambda, final Clock clock) {
this.clock = clock;
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/d856969f/lang/java/reef-runtime-hdinsight/src/main/java/org/apache/reef/runtime/hdinsight/cli/TFileParser.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-runtime-hdinsight/src/main/java/org/apache/reef/runtime/hdinsight/cli/TFileParser.java b/lang/java/reef-runtime-hdinsight/src/main/java/org/apache/reef/runtime/hdinsight/cli/TFileParser.java
index 3bbe9dd..a31193b 100644
--- a/lang/java/reef-runtime-hdinsight/src/main/java/org/apache/reef/runtime/hdinsight/cli/TFileParser.java
+++ b/lang/java/reef-runtime-hdinsight/src/main/java/org/apache/reef/runtime/hdinsight/cli/TFileParser.java
@@ -37,7 +37,7 @@ final class TFileParser {
private final FileSystem fileSystem;
private final Configuration configuration;
- public TFileParser(final Configuration conf, final FileSystem fs) {
+ TFileParser(final Configuration conf, final FileSystem fs) {
this.configuration = conf;
this.fileSystem = fs;
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/d856969f/lang/java/reef-runtime-local/src/main/java/org/apache/reef/runtime/local/client/DriverFiles.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-runtime-local/src/main/java/org/apache/reef/runtime/local/client/DriverFiles.java b/lang/java/reef-runtime-local/src/main/java/org/apache/reef/runtime/local/client/DriverFiles.java
index 1887751..9ddf685 100644
--- a/lang/java/reef-runtime-local/src/main/java/org/apache/reef/runtime/local/client/DriverFiles.java
+++ b/lang/java/reef-runtime-local/src/main/java/org/apache/reef/runtime/local/client/DriverFiles.java
@@ -45,7 +45,7 @@ final class DriverFiles {
private final FileSet globalLibs = new FileSet();
private final REEFFileNames fileNames;
- public DriverFiles(final REEFFileNames fileNames) {
+ DriverFiles(final REEFFileNames fileNames) {
this.fileNames = fileNames;
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/d856969f/lang/java/reef-runtime-local/src/main/java/org/apache/reef/runtime/local/client/LocalJobSubmissionHandler.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-runtime-local/src/main/java/org/apache/reef/runtime/local/client/LocalJobSubmissionHandler.java b/lang/java/reef-runtime-local/src/main/java/org/apache/reef/runtime/local/client/LocalJobSubmissionHandler.java
index 6138c8a..50631fd 100644
--- a/lang/java/reef-runtime-local/src/main/java/org/apache/reef/runtime/local/client/LocalJobSubmissionHandler.java
+++ b/lang/java/reef-runtime-local/src/main/java/org/apache/reef/runtime/local/client/LocalJobSubmissionHandler.java
@@ -54,7 +54,7 @@ final class LocalJobSubmissionHandler implements JobSubmissionHandler {
private final DriverConfigurationProvider driverConfigurationProvider;
@Inject
- public LocalJobSubmissionHandler(
+ LocalJobSubmissionHandler(
final ExecutorService executor,
@Parameter(RootFolder.class) final String rootFolderName,
final ConfigurationSerializer configurationSerializer,
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/d856969f/lang/java/reef-runtime-local/src/main/java/org/apache/reef/runtime/local/driver/LocalResourceLaunchHandler.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-runtime-local/src/main/java/org/apache/reef/runtime/local/driver/LocalResourceLaunchHandler.java b/lang/java/reef-runtime-local/src/main/java/org/apache/reef/runtime/local/driver/LocalResourceLaunchHandler.java
index a45df67..3f05ee0 100644
--- a/lang/java/reef-runtime-local/src/main/java/org/apache/reef/runtime/local/driver/LocalResourceLaunchHandler.java
+++ b/lang/java/reef-runtime-local/src/main/java/org/apache/reef/runtime/local/driver/LocalResourceLaunchHandler.java
@@ -35,7 +35,7 @@ final class LocalResourceLaunchHandler implements ResourceLaunchHandler {
private final ResourceManager resourceManager;
@Inject
- public LocalResourceLaunchHandler(final ResourceManager resourceManager) {
+ LocalResourceLaunchHandler(final ResourceManager resourceManager) {
this.resourceManager = resourceManager;
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/d856969f/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/formats/ConfigurationModule.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/formats/ConfigurationModule.java b/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/formats/ConfigurationModule.java
index 735c5ad..41f24aa 100644
--- a/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/formats/ConfigurationModule.java
+++ b/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/formats/ConfigurationModule.java
@@ -354,7 +354,7 @@ public class ConfigurationModule {
private final String k;
private final String v;
- public MyEntry(final String k, final String v) {
+ MyEntry(final String k, final String v) {
this.k = k;
this.v = v;
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/d856969f/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/implementation/TangImpl.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/implementation/TangImpl.java b/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/implementation/TangImpl.java
index 6034c58..f08fb79 100644
--- a/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/implementation/TangImpl.java
+++ b/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/implementation/TangImpl.java
@@ -131,7 +131,7 @@ public class TangImpl implements Tang {
private class SetValuedKey {
private final Set<Object> key;
- public SetValuedKey(final Object[] ts, final Object[] us) {
+ SetValuedKey(final Object[] ts, final Object[] us) {
key = new HashSet<>(Arrays.asList(ts));
key.addAll(Arrays.asList(us));
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/d856969f/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/implementation/avro/AvroClassHierarchy.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/implementation/avro/AvroClassHierarchy.java b/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/implementation/avro/AvroClassHierarchy.java
index 74c8d3c..a120214 100644
--- a/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/implementation/avro/AvroClassHierarchy.java
+++ b/lang/java/reef-tang/tang/src/main/java/org/apache/reef/tang/implementation/avro/AvroClassHierarchy.java
@@ -35,7 +35,7 @@ final class AvroClassHierarchy implements ClassHierarchy {
private final PackageNode namespace;
private final HashMap<String, Node> lookupTable = new HashMap<>();
- public AvroClassHierarchy(final AvroNode root) {
+ AvroClassHierarchy(final AvroNode root) {
namespace = new PackageNodeImpl();
if (root.getPackageNode() == null) {
throw new IllegalArgumentException("Expected a package node. Got: " + root);
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/d856969f/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/TestBindSingleton.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/TestBindSingleton.java b/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/TestBindSingleton.java
index 6de8aa7..336fbe9 100644
--- a/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/TestBindSingleton.java
+++ b/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/TestBindSingleton.java
@@ -418,7 +418,7 @@ class IncestuousInterfaceSingletons {
class IsBrokenClassInjectable {
@Inject
- public IsBrokenClassInjectable() {
+ IsBrokenClassInjectable() {
throw new UnsupportedOperationException();
}
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/d856969f/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/TestImplicitConversions.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/TestImplicitConversions.java b/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/TestImplicitConversions.java
index 98883c0..1fb2961 100644
--- a/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/TestImplicitConversions.java
+++ b/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/TestImplicitConversions.java
@@ -138,7 +138,7 @@ public class TestImplicitConversions {
private final Identifier id;
@Inject
- public IdentifierParser(final String id) {
+ IdentifierParser(final String id) {
this.id = id.startsWith("a://") ? new AIdentifierImpl(id) :
id.startsWith("b://") ? new BIdentifierImpl(id) :
null;
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/d856969f/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/TestTang.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/TestTang.java b/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/TestTang.java
index 697c291..2fb4eb4 100644
--- a/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/TestTang.java
+++ b/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/TestTang.java
@@ -717,14 +717,14 @@ public class TestTang {
class Fail {
@Inject
- public Fail() {
+ Fail() {
throw new UnsupportedOperationException();
}
}
class Pass {
@Inject
- public Pass() {
+ Pass() {
}
}
@@ -755,11 +755,11 @@ class InjectInjector {
class SingletonMultiConst implements SMC {
@Inject
- public SingletonMultiConst(@Parameter(A.class) final String a) {
+ SingletonMultiConst(@Parameter(A.class) final String a) {
}
@Inject
- public SingletonMultiConst(@Parameter(A.class) final String a, @Parameter(B.class) final String b) {
+ SingletonMultiConst(@Parameter(A.class) final String a, @Parameter(B.class) final String b) {
}
@NamedParameter
@@ -779,7 +779,7 @@ class HaveDefaultImplImpl implements HaveDefaultImpl {
class OverrideDefaultImpl implements HaveDefaultImpl {
@Inject
- public OverrideDefaultImpl() {
+ OverrideDefaultImpl() {
}
}
@@ -791,7 +791,7 @@ class HaveDefaultStringImplImpl implements HaveDefaultStringImpl {
class OverrideDefaultStringImpl implements HaveDefaultStringImpl {
@Inject
- public OverrideDefaultStringImpl() {
+ OverrideDefaultStringImpl() {
}
}
@@ -810,7 +810,7 @@ class MustBeSingleton {
protected static boolean alreadyInstantiated;
@Inject
- public MustBeSingleton() {
+ MustBeSingleton() {
if (alreadyInstantiated) {
throw new IllegalStateException("Can't instantiate me twice!");
}
@@ -945,7 +945,7 @@ class ExternalConstructorExample {
protected final Integer x;
protected final String y;
- public Legacy(final Integer x, final String y) {
+ Legacy(final Integer x, final String y) {
this.x = x;
this.y = y;
}
@@ -956,7 +956,7 @@ class LegacyConstructor {
protected final Integer x;
protected final String y;
- public LegacyConstructor(final Integer x, final String y) {
+ LegacyConstructor(final Integer x, final String y) {
this.x = x;
this.y = y;
}
@@ -1326,7 +1326,7 @@ class WantSomeFutureHandlersName {
class OuterUnitWithStatic {
@Inject
- public OuterUnitWithStatic() {
+ OuterUnitWithStatic() {
}
public void bar() {
@@ -1334,7 +1334,7 @@ class OuterUnitWithStatic {
}
static class InnerStaticClass {
- public InnerStaticClass() {
+ InnerStaticClass() {
}
public void baz() {
@@ -1343,7 +1343,7 @@ class OuterUnitWithStatic {
static class InnerStaticClass2 {
@Inject
- public InnerStaticClass2() {
+ InnerStaticClass2() {
}
public void baz() {
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/d856969f/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/TestTweetExample.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/TestTweetExample.java b/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/TestTweetExample.java
index 3c80e70..288f4b8 100644
--- a/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/TestTweetExample.java
+++ b/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/TestTweetExample.java
@@ -65,7 +65,7 @@ public class TestTweetExample {
static class MockTweetFactory implements TweetFactory {
@Inject
- public MockTweetFactory() {
+ MockTweetFactory() {
}
@Override
@@ -76,7 +76,7 @@ public class TestTweetExample {
static class MockSMS implements SMS {
@Inject
- public MockSMS() {
+ MockSMS() {
}
@Override
@@ -94,8 +94,8 @@ public class TestTweetExample {
private final long phoneNumber;
@Inject
- public Tweeter(final TweetFactory tw, final SMS sms,
- @Parameter(PhoneNumber.class) final long phoneNumber) {
+ Tweeter(final TweetFactory tw, final SMS sms,
+ @Parameter(PhoneNumber.class) final long phoneNumber) {
this.tw = tw;
this.sms = sms;
this.phoneNumber = phoneNumber;
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/d856969f/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/formats/TestConfigurationModule.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/formats/TestConfigurationModule.java b/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/formats/TestConfigurationModule.java
index 6891234..015e49e 100644
--- a/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/formats/TestConfigurationModule.java
+++ b/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/formats/TestConfigurationModule.java
@@ -428,13 +428,13 @@ class SetClassConfigurationModule extends ConfigurationModuleBuilder {
class SubA implements Super {
@Inject
- public SubA() {
+ SubA() {
}
}
class SubB implements Super {
@Inject
- public SubB() {
+ SubB() {
}
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/d856969f/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/implementation/TestClassHierarchy.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/implementation/TestClassHierarchy.java b/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/implementation/TestClassHierarchy.java
index 183f641..2922757 100644
--- a/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/implementation/TestClassHierarchy.java
+++ b/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/implementation/TestClassHierarchy.java
@@ -372,7 +372,7 @@ public class TestClassHierarchy {
@Test
public void testNonInjectableParam() throws NameResolutionException {
thrown.expect(ClassHierarchyException.class);
- thrown.expectMessage("public org.apache.reef.tang.implementation.NonInjectableParam(int) is not injectable, " +
+ thrown.expectMessage("org.apache.reef.tang.implementation.NonInjectableParam(int) is not injectable, " +
"but it has an @Parameter annotation.");
ns.getNode(s(NonInjectableParam.class));
}
@@ -390,25 +390,25 @@ class BadName implements Name<String> {
class SimpleConstructors {
@Inject
- public SimpleConstructors() {
+ SimpleConstructors() {
}
@Inject
- public SimpleConstructors(final int x) {
+ SimpleConstructors(final int x) {
}
- public SimpleConstructors(final String x) {
+ SimpleConstructors(final String x) {
}
@Inject
- public SimpleConstructors(final int x, final String y) {
+ SimpleConstructors(final int x, final String y) {
}
}
class NamedParameterConstructors {
@Inject
- public NamedParameterConstructors(final String x, @Parameter(X.class) final String y) {
+ NamedParameterConstructors(final String x, @Parameter(X.class) final String y) {
}
@NamedParameter()
@@ -418,7 +418,7 @@ class NamedParameterConstructors {
class RepeatConstructorArg {
@Inject
- public RepeatConstructorArg(final int x, final int y) {
+ RepeatConstructorArg(final int x, final int y) {
}
}
@@ -427,7 +427,7 @@ class A {
class RepeatConstructorArgClasses {
@Inject
- public RepeatConstructorArgClasses(final A x, final A y) {
+ RepeatConstructorArgClasses(final A x, final A y) {
}
}
@@ -460,15 +460,15 @@ class BB implements Name<A> {
class NamedRepeatConstructorArgClasses {
@Inject
- public NamedRepeatConstructorArgClasses(@Parameter(AA.class) final A x,
- @Parameter(BB.class) final A y) {
+ NamedRepeatConstructorArgClasses(@Parameter(AA.class) final A x,
+ @Parameter(BB.class) final A y) {
}
}
class DocumentedLocalNamedParameter {
@Inject
- public DocumentedLocalNamedParameter(@Parameter(Foo.class) final String s) {
+ DocumentedLocalNamedParameter(@Parameter(Foo.class) final String s) {
}
@NamedParameter(doc = "doc stuff", default_value = "some value")
@@ -479,7 +479,7 @@ class DocumentedLocalNamedParameter {
class NamedParameterTypeMismatch {
@Inject
- public NamedParameterTypeMismatch(@Parameter(Foo.class) final String s) {
+ NamedParameterTypeMismatch(@Parameter(Foo.class) final String s) {
}
@NamedParameter(doc = "doc.stuff", default_value = "1")
@@ -519,7 +519,7 @@ final class NameWithConstructor implements Name<Object> {
@NamedParameter()
class NameWithZeroArgInject implements Name<Object> {
@Inject
- public NameWithZeroArgInject() {
+ NameWithZeroArgInject() {
}
}
@@ -655,6 +655,6 @@ class SomeName implements Name<Integer> {
}
class NonInjectableParam {
- public NonInjectableParam(@Parameter(SomeName.class) final int i) {
+ NonInjectableParam(@Parameter(SomeName.class) final int i) {
}
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/d856969f/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/implementation/java/TestParameterParser.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/implementation/java/TestParameterParser.java b/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/implementation/java/TestParameterParser.java
index 8bfa82b..cfd2f5d 100644
--- a/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/implementation/java/TestParameterParser.java
+++ b/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/implementation/java/TestParameterParser.java
@@ -136,7 +136,7 @@ public class TestParameterParser {
private final Foo foo;
@Inject
- public FooParser(final String s) {
+ FooParser(final String s) {
this.foo = new Foo(s);
}
@@ -150,7 +150,7 @@ public class TestParameterParser {
private final Bar bar;
@Inject
- public BarParser(final String s) {
+ BarParser(final String s) {
this.bar = new Bar(s);
}
@@ -166,13 +166,13 @@ public class TestParameterParser {
return s;
}
- public Foo(final String s) {
+ Foo(final String s) {
this.s = s;
}
}
private static class Bar extends Foo {
- public Bar(final String s) {
+ Bar(final String s) {
super(s);
}
}
@@ -204,7 +204,7 @@ public class TestParameterParser {
private ParseableType instance;
@Inject
- public TypeParser(final String s) {
+ TypeParser(final String s) {
if (s.equals("a")) {
instance = new ParseTypeA();
}
@@ -237,14 +237,14 @@ public class TestParameterParser {
private static class NeedsA {
@Inject
- public NeedsA(@Parameter(ParseNameA.class) final ParseableType a) {
+ NeedsA(@Parameter(ParseNameA.class) final ParseableType a) {
Assert.assertTrue(a instanceof ParseTypeA);
}
}
private static class NeedsB {
@Inject
- public NeedsB(@Parameter(ParseNameB.class) final ParseTypeB b) {
+ NeedsB(@Parameter(ParseNameB.class) final ParseTypeB b) {
Assert.assertTrue(b instanceof ParseTypeB);
}
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/d856969f/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/test/RootImplementation.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/test/RootImplementation.java b/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/test/RootImplementation.java
index 72d14ba..dee55b0 100644
--- a/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/test/RootImplementation.java
+++ b/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/test/RootImplementation.java
@@ -44,20 +44,20 @@ final class RootImplementation implements RootInterface {
private final CyclicDependency cyclicDependency;
@Inject
- public RootImplementation(@Parameter(TestConfiguration.RequiredString.class) final String requiredString,
- @Parameter(TestConfiguration.OptionalString.class) final String optionalString,
- @Parameter(TestConfiguration.StringHandler.class) final Handler<String> stringHandler,
- @Parameter(TestConfiguration.IntegerHandler.class) final Handler<Integer> integerHandler,
- @Parameter(TestConfiguration.NamedParameterInteger.class) final int anInt,
- @Parameter(TestConfiguration.NamedParameterDouble.class) final double aDouble,
- final UnitClass unit,
- final AnInterface anInterface,
- final InjectableClass injectableClass,
- final SetOfImplementations setOfImplementations,
- final SetOfBaseTypes setOfBaseTypes,
- final ListOfImplementations listOfImplementations,
- final ListOfBaseTypes listOfBaseTypes,
- final CyclicDependency cyclicDependency) {
+ RootImplementation(@Parameter(TestConfiguration.RequiredString.class) final String requiredString,
+ @Parameter(TestConfiguration.OptionalString.class) final String optionalString,
+ @Parameter(TestConfiguration.StringHandler.class) final Handler<String> stringHandler,
+ @Parameter(TestConfiguration.IntegerHandler.class) final Handler<Integer> integerHandler,
+ @Parameter(TestConfiguration.NamedParameterInteger.class) final int anInt,
+ @Parameter(TestConfiguration.NamedParameterDouble.class) final double aDouble,
+ final UnitClass unit,
+ final AnInterface anInterface,
+ final InjectableClass injectableClass,
+ final SetOfImplementations setOfImplementations,
+ final SetOfBaseTypes setOfBaseTypes,
+ final ListOfImplementations listOfImplementations,
+ final ListOfBaseTypes listOfBaseTypes,
+ final CyclicDependency cyclicDependency) {
this.requiredString = requiredString;
this.optionalString = optionalString;
this.unit = unit;
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/d856969f/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/test/SetInterfaceImplOne.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/test/SetInterfaceImplOne.java b/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/test/SetInterfaceImplOne.java
index 067b50d..43d885c 100644
--- a/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/test/SetInterfaceImplOne.java
+++ b/lang/java/reef-tang/tang/src/test/java/org/apache/reef/tang/test/SetInterfaceImplOne.java
@@ -28,7 +28,7 @@ final class SetInterfaceImplOne implements SetInterface {
private final int magicNumber;
@Inject
- public SetInterfaceImplOne() {
+ SetInterfaceImplOne() {
this.magicNumber = 42;
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/d856969f/lang/java/reef-tests/src/test/java/org/apache/reef/tests/evaluatorsize/EvaluatorSizeTestDriver.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-tests/src/test/java/org/apache/reef/tests/evaluatorsize/EvaluatorSizeTestDriver.java b/lang/java/reef-tests/src/test/java/org/apache/reef/tests/evaluatorsize/EvaluatorSizeTestDriver.java
index 6a57132..4cfe8fc 100644
--- a/lang/java/reef-tests/src/test/java/org/apache/reef/tests/evaluatorsize/EvaluatorSizeTestDriver.java
+++ b/lang/java/reef-tests/src/test/java/org/apache/reef/tests/evaluatorsize/EvaluatorSizeTestDriver.java
@@ -43,8 +43,8 @@ final class EvaluatorSizeTestDriver {
private final int memorySize;
@Inject
- public EvaluatorSizeTestDriver(final EvaluatorRequestor evaluatorRequestor,
- @Parameter(EvaluatorSizeTestConfiguration.MemorySize.class) final int memorySize) {
+ EvaluatorSizeTestDriver(final EvaluatorRequestor evaluatorRequestor,
+ @Parameter(EvaluatorSizeTestConfiguration.MemorySize.class) final int memorySize) {
this.evaluatorRequestor = evaluatorRequestor;
this.memorySize = memorySize;
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/d856969f/lang/java/reef-tests/src/test/java/org/apache/reef/tests/evaluatorsize/MemorySizeTask.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-tests/src/test/java/org/apache/reef/tests/evaluatorsize/MemorySizeTask.java b/lang/java/reef-tests/src/test/java/org/apache/reef/tests/evaluatorsize/MemorySizeTask.java
index c82332f..6789900 100644
--- a/lang/java/reef-tests/src/test/java/org/apache/reef/tests/evaluatorsize/MemorySizeTask.java
+++ b/lang/java/reef-tests/src/test/java/org/apache/reef/tests/evaluatorsize/MemorySizeTask.java
@@ -31,7 +31,7 @@ final class MemorySizeTask implements Task {
private final int memorySize;
@Inject
- public MemorySizeTask(@Parameter(EvaluatorSizeTestConfiguration.MemorySize.class) final int memorySize) {
+ MemorySizeTask(@Parameter(EvaluatorSizeTestConfiguration.MemorySize.class) final int memorySize) {
this.memorySize = memorySize;
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/d856969f/lang/java/reef-tests/src/test/java/org/apache/reef/tests/files/FileResourceTestDriver.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-tests/src/test/java/org/apache/reef/tests/files/FileResourceTestDriver.java b/lang/java/reef-tests/src/test/java/org/apache/reef/tests/files/FileResourceTestDriver.java
index 76fcde5..614bcc7 100644
--- a/lang/java/reef-tests/src/test/java/org/apache/reef/tests/files/FileResourceTestDriver.java
+++ b/lang/java/reef-tests/src/test/java/org/apache/reef/tests/files/FileResourceTestDriver.java
@@ -49,10 +49,10 @@ final class FileResourceTestDriver {
private final File localFolder;
@Inject
- public FileResourceTestDriver(@Parameter(FileResourceTestDriverConfiguration.FileNamesToExpect.class)
- final Set<String> fileNamesToExpect,
- final EvaluatorRequestor requestor,
- final REEFFileNames fileNames) {
+ FileResourceTestDriver(@Parameter(FileResourceTestDriverConfiguration.FileNamesToExpect.class)
+ final Set<String> fileNamesToExpect,
+ final EvaluatorRequestor requestor,
+ final REEFFileNames fileNames) {
this.fileNamesToExpect = fileNamesToExpect;
this.requestor = requestor;
this.fileNames = fileNames;
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/d856969f/lang/java/reef-utils/src/main/java/org/apache/reef/util/cache/WrappedValue.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-utils/src/main/java/org/apache/reef/util/cache/WrappedValue.java b/lang/java/reef-utils/src/main/java/org/apache/reef/util/cache/WrappedValue.java
index ea19843..4b4227b 100644
--- a/lang/java/reef-utils/src/main/java/org/apache/reef/util/cache/WrappedValue.java
+++ b/lang/java/reef-utils/src/main/java/org/apache/reef/util/cache/WrappedValue.java
@@ -42,7 +42,7 @@ final class WrappedValue<V> {
* @param valueFetcher method used to fetch the value
* @param currentTime class that returns the current time
*/
- public WrappedValue(final Callable<V> valueFetcher,
+ WrappedValue(final Callable<V> valueFetcher,
final CurrentTime currentTime) {
this.valueFetcher = valueFetcher;
this.currentTime = currentTime;
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/d856969f/lang/java/reef-utils/src/test/java/org/apache/reef/util/cache/ImmediateInteger.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-utils/src/test/java/org/apache/reef/util/cache/ImmediateInteger.java b/lang/java/reef-utils/src/test/java/org/apache/reef/util/cache/ImmediateInteger.java
index 4fbc3e5..a05a20f 100644
--- a/lang/java/reef-utils/src/test/java/org/apache/reef/util/cache/ImmediateInteger.java
+++ b/lang/java/reef-utils/src/test/java/org/apache/reef/util/cache/ImmediateInteger.java
@@ -26,7 +26,7 @@ import java.util.concurrent.Callable;
class ImmediateInteger implements Callable<Integer> {
private final int returnValue;
- public ImmediateInteger(final int returnValue) {
+ ImmediateInteger(final int returnValue) {
this.returnValue = returnValue;
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/d856969f/lang/java/reef-utils/src/test/java/org/apache/reef/util/cache/SleepingInteger.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-utils/src/test/java/org/apache/reef/util/cache/SleepingInteger.java b/lang/java/reef-utils/src/test/java/org/apache/reef/util/cache/SleepingInteger.java
index 0c642d2..10807ec 100644
--- a/lang/java/reef-utils/src/test/java/org/apache/reef/util/cache/SleepingInteger.java
+++ b/lang/java/reef-utils/src/test/java/org/apache/reef/util/cache/SleepingInteger.java
@@ -33,7 +33,7 @@ class SleepingInteger implements Callable<Integer> {
* @param returnValue value to return
* @param sleepMillis amount to sleep
*/
- public SleepingInteger(final int returnValue, final long sleepMillis) {
+ SleepingInteger(final int returnValue, final long sleepMillis) {
this.returnValue = returnValue;
this.sleepMillis = sleepMillis;
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/d856969f/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/examples/accumulate/CombinerStage.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/examples/accumulate/CombinerStage.java b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/examples/accumulate/CombinerStage.java
index 2aeaa1f..3771b1e 100644
--- a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/examples/accumulate/CombinerStage.java
+++ b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/examples/accumulate/CombinerStage.java
@@ -140,7 +140,7 @@ public class CombinerStage<K extends Comparable<K>, V> implements Stage {
}
private class OutputThread extends Thread {
- public OutputThread() {
+ OutputThread() {
super("grouper-output-thread");
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/d856969f/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/transport/netty/AbstractNettyEventListener.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/transport/netty/AbstractNettyEventListener.java b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/transport/netty/AbstractNettyEventListener.java
index 8dea218..d286d0c 100644
--- a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/transport/netty/AbstractNettyEventListener.java
+++ b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/transport/netty/AbstractNettyEventListener.java
@@ -41,7 +41,7 @@ abstract class AbstractNettyEventListener implements NettyEventListener {
protected final EStage<TransportEvent> stage;
protected EventHandler<Exception> exceptionHandler;
- public AbstractNettyEventListener(
+ AbstractNettyEventListener(
final ConcurrentMap<SocketAddress, LinkReference> addrToLinkRefMap,
final EStage<TransportEvent> stage) {
this.addrToLinkRefMap = addrToLinkRefMap;
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/d856969f/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/transport/netty/ChunkedReadWriteHandler.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/transport/netty/ChunkedReadWriteHandler.java b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/transport/netty/ChunkedReadWriteHandler.java
index 738c17e..648b48f 100644
--- a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/transport/netty/ChunkedReadWriteHandler.java
+++ b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/transport/netty/ChunkedReadWriteHandler.java
@@ -183,7 +183,7 @@ public class ChunkedReadWriteHandler extends ChunkedWriteHandler {
private class ByteBufCloseableStream extends ByteBufInputStream {
private final ByteBuf buffer;
- public ByteBufCloseableStream(final ByteBuf buffer) {
+ ByteBufCloseableStream(final ByteBuf buffer) {
super(buffer);
this.buffer = buffer;
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/d856969f/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/transport/netty/LoggingLinkListener.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/transport/netty/LoggingLinkListener.java b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/transport/netty/LoggingLinkListener.java
index 4c6626c..8cd8daf 100644
--- a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/transport/netty/LoggingLinkListener.java
+++ b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/transport/netty/LoggingLinkListener.java
@@ -49,8 +49,8 @@ public class LoggingLinkListener<T> implements LinkListener<T> {
@Override
public void onException(final Throwable cause, final SocketAddress remoteAddress, final T message) {
if (LOG.isLoggable(Level.FINEST)) {
- LOG.log(Level.FINEST, "The message to {0} is failed to be sent. message : {1}, cause : {2}"
- , new Object[]{remoteAddress, message, cause});
+ LOG.log(Level.FINEST, "The message to {0} is failed to be sent. message : {1}, cause : {2}",
+ new Object[]{remoteAddress, message, cause});
}
}
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/d856969f/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/transport/netty/NettyChannelHandler.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/transport/netty/NettyChannelHandler.java b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/transport/netty/NettyChannelHandler.java
index 79b2230..b61a37e 100644
--- a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/transport/netty/NettyChannelHandler.java
+++ b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/transport/netty/NettyChannelHandler.java
@@ -45,7 +45,7 @@ class NettyChannelHandler extends ChannelInboundHandlerAdapter {
* @param channelGroup the channel group
* @param listener the Netty event listener
*/
- public NettyChannelHandler(
+ NettyChannelHandler(
final String tag, final ChannelGroup channelGroup, final NettyEventListener listener) {
this.tag = tag;
this.channelGroup = channelGroup;
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/d856969f/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/transport/netty/NettyChannelInitializer.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/transport/netty/NettyChannelInitializer.java b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/transport/netty/NettyChannelInitializer.java
index ca2ca4d..14fd0af 100644
--- a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/transport/netty/NettyChannelInitializer.java
+++ b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/transport/netty/NettyChannelInitializer.java
@@ -35,7 +35,7 @@ class NettyChannelInitializer extends ChannelInitializer<SocketChannel> {
public static final int MAXFRAMELENGTH = 10 * 1024 * 1024;
private final NettyChannelHandlerFactory handlerFactory;
- public NettyChannelInitializer(final NettyChannelHandlerFactory handlerFactory) {
+ NettyChannelInitializer(final NettyChannelHandlerFactory handlerFactory) {
this.handlerFactory = handlerFactory;
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/d856969f/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/transport/netty/NettyClientEventListener.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/transport/netty/NettyClientEventListener.java b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/transport/netty/NettyClientEventListener.java
index 9d3234c..02447bc 100644
--- a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/transport/netty/NettyClientEventListener.java
+++ b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/transport/netty/NettyClientEventListener.java
@@ -35,7 +35,7 @@ final class NettyClientEventListener extends AbstractNettyEventListener {
private static final Logger LOG = Logger.getLogger(NettyClientEventListener.class.getName());
- public NettyClientEventListener(
+ NettyClientEventListener(
final ConcurrentMap<SocketAddress, LinkReference> addrToLinkRefMap,
final EStage<TransportEvent> stage) {
super(addrToLinkRefMap, stage);
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/d856969f/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/transport/netty/NettyServerEventListener.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/transport/netty/NettyServerEventListener.java b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/transport/netty/NettyServerEventListener.java
index 218f04e..d4d8f88 100644
--- a/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/transport/netty/NettyServerEventListener.java
+++ b/lang/java/reef-wake/wake/src/main/java/org/apache/reef/wake/remote/transport/netty/NettyServerEventListener.java
@@ -33,7 +33,7 @@ import java.util.logging.Level;
*/
final class NettyServerEventListener extends AbstractNettyEventListener {
- public NettyServerEventListener(
+ NettyServerEventListener(
final ConcurrentMap<SocketAddress, LinkReference> addrToLinkRefMap,
final EStage<TransportEvent> stage) {
super(addrToLinkRefMap, stage);
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/d856969f/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/PubSubThreadPoolStageTest.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/PubSubThreadPoolStageTest.java b/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/PubSubThreadPoolStageTest.java
index 68557e3..a49f11a 100644
--- a/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/PubSubThreadPoolStageTest.java
+++ b/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/PubSubThreadPoolStageTest.java
@@ -83,7 +83,7 @@ public class PubSubThreadPoolStageTest {
class TestEvent {
private final String msg;
- public TestEvent(final String msg) {
+ TestEvent(final String msg) {
this.msg = msg;
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/d856969f/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/examples/SkipListTest.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/examples/SkipListTest.java b/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/examples/SkipListTest.java
index eaa7baf..dbc5de3 100644
--- a/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/examples/SkipListTest.java
+++ b/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/examples/SkipListTest.java
@@ -330,8 +330,8 @@ public class SkipListTest {
mm.put(i, i);
}
}
- }
- , 10, TimeUnit.SECONDS);
+ },
+ 10, TimeUnit.SECONDS);
}
final long inend = System.currentTimeMillis();
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/d856969f/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/remote/RemoteManagerTest.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/remote/RemoteManagerTest.java b/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/remote/RemoteManagerTest.java
index 13758d8..a46a54e 100644
--- a/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/remote/RemoteManagerTest.java
+++ b/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/remote/RemoteManagerTest.java
@@ -312,7 +312,7 @@ public class RemoteManagerTest {
private final int timeout;
private RemoteManager rm;
- public SendingRemoteManagerThread(final RemoteManager rm, final int remotePort, final int timeout) {
+ SendingRemoteManagerThread(final RemoteManager rm, final int remotePort, final int timeout) {
this.remotePort = remotePort;
this.timeout = timeout;
this.rm = rm;
@@ -355,8 +355,8 @@ public class RemoteManagerTest {
private final int numOfEvent;
private RemoteManager rm;
- public ReceivingRemoteManagerThread(final RemoteManager rm, final int timeout,
- final int numOfConnection, final int numOfEvent) {
+ ReceivingRemoteManagerThread(final RemoteManager rm, final int timeout,
+ final int numOfConnection, final int numOfEvent) {
this.rm = rm;
this.timeout = timeout;
this.numOfConnection = numOfConnection;
@@ -479,7 +479,7 @@ public class RemoteManagerTest {
final class TestRuntimeException extends RuntimeException {
private static final long serialVersionUID = 1L;
- public TestRuntimeException(final String s) {
+ TestRuntimeException(final String s) {
super(s);
}
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/d856969f/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/remote/TestRemote.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/remote/TestRemote.java b/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/remote/TestRemote.java
index b01e5e5..f7f40bc 100644
--- a/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/remote/TestRemote.java
+++ b/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/remote/TestRemote.java
@@ -79,7 +79,7 @@ class TestEventHandler implements EventHandler<RemoteMessage<TestEvent>> {
private final EventHandler<TestEvent> proxy;
- public TestEventHandler(final EventHandler<TestEvent> proxy) {
+ TestEventHandler(final EventHandler<TestEvent> proxy) {
this.proxy = proxy;
}
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/d856969f/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/time/ClockTest.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/time/ClockTest.java b/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/time/ClockTest.java
index 3f3ff20..c444205 100644
--- a/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/time/ClockTest.java
+++ b/lang/java/reef-wake/wake/src/test/java/org/apache/reef/wake/test/time/ClockTest.java
@@ -216,11 +216,11 @@ public class ClockTest {
private final CountDownLatch eventCountLatch;
- public EventRecorder() {
+ EventRecorder() {
this(null);
}
- public EventRecorder(final CountDownLatch latch) {
+ EventRecorder(final CountDownLatch latch) {
eventCountLatch = latch;
}
@@ -248,7 +248,7 @@ public class ClockTest {
private final CountDownLatch eventCountLatch;
private final Random rand;
- public RandomAlarmProducer(final RuntimeClock clock, final CountDownLatch latch) {
+ RandomAlarmProducer(final RuntimeClock clock, final CountDownLatch latch) {
this.clock = clock;
this.eventCountLatch = latch;
this.rand = new Random();
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/d856969f/lang/java/reef-webserver/src/test/java/org/apache/reef/webserver/TestHttpConfiguration.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-webserver/src/test/java/org/apache/reef/webserver/TestHttpConfiguration.java b/lang/java/reef-webserver/src/test/java/org/apache/reef/webserver/TestHttpConfiguration.java
index 7edca44..0c78e8c 100644
--- a/lang/java/reef-webserver/src/test/java/org/apache/reef/webserver/TestHttpConfiguration.java
+++ b/lang/java/reef-webserver/src/test/java/org/apache/reef/webserver/TestHttpConfiguration.java
@@ -155,7 +155,7 @@ public class TestHttpConfiguration {
final class MockActiveContext implements ActiveContext {
@Inject
- public MockActiveContext() {
+ MockActiveContext() {
}
@Override
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/d856969f/lang/java/reef-webserver/src/test/java/org/apache/reef/webserver/TestJettyHandler.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-webserver/src/test/java/org/apache/reef/webserver/TestJettyHandler.java b/lang/java/reef-webserver/src/test/java/org/apache/reef/webserver/TestJettyHandler.java
index 5705b9a..049619a 100644
--- a/lang/java/reef-webserver/src/test/java/org/apache/reef/webserver/TestJettyHandler.java
+++ b/lang/java/reef-webserver/src/test/java/org/apache/reef/webserver/TestJettyHandler.java
@@ -145,7 +145,7 @@ public class TestJettyHandler {
final class HttpAbcEventHandler implements HttpHandler {
@Inject
- public HttpAbcEventHandler() {
+ HttpAbcEventHandler() {
}
@Override
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/d856969f/lang/java/reef-webserver/src/test/java/org/apache/reef/webserver/TestReefEventStateManager.java
----------------------------------------------------------------------
diff --git a/lang/java/reef-webserver/src/test/java/org/apache/reef/webserver/TestReefEventStateManager.java b/lang/java/reef-webserver/src/test/java/org/apache/reef/webserver/TestReefEventStateManager.java
index 9ef49ce..c64f5be 100644
--- a/lang/java/reef-webserver/src/test/java/org/apache/reef/webserver/TestReefEventStateManager.java
+++ b/lang/java/reef-webserver/src/test/java/org/apache/reef/webserver/TestReefEventStateManager.java
@@ -98,8 +98,8 @@ final class MockEvaluatorDescriptor implements EvaluatorDescriptor {
private final EvaluatorProcessFactory evaluatorProcessFactory;
@Inject
- public MockEvaluatorDescriptor(final NodeDescriptor nodeDescriptor,
- final EvaluatorProcessFactory evaluatorProcessFactory) {
+ MockEvaluatorDescriptor(final NodeDescriptor nodeDescriptor,
+ final EvaluatorProcessFactory evaluatorProcessFactory) {
this.nodeDescriptor = nodeDescriptor;
this.evaluatorProcessFactory = evaluatorProcessFactory;
}
@@ -127,7 +127,7 @@ final class MockEvaluatorDescriptor implements EvaluatorDescriptor {
final class MockNodeDescriptor implements NodeDescriptor {
@Inject
- public MockNodeDescriptor() {
+ MockNodeDescriptor() {
}
@Override
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/d856969f/pom.xml
----------------------------------------------------------------------
diff --git a/pom.xml b/pom.xml
index 190fdbd..e40a89b 100644
--- a/pom.xml
+++ b/pom.xml
@@ -53,9 +53,9 @@ under the License.
<jetty.version>6.1.26</jetty.version>
<jackson.version>1.9.13</jackson.version>
<protobuf.version>2.5.0</protobuf.version>
- <maven-checkstyle-plugin.version>2.15</maven-checkstyle-plugin.version>
+ <maven-checkstyle-plugin.version>2.17</maven-checkstyle-plugin.version>
<sevntu.checkstyle.plugin.version>1.15.0</sevntu.checkstyle.plugin.version>
- <checkstyle.version>6.6</checkstyle.version>
+ <checkstyle.version>6.12</checkstyle.version>
<findbugs.version>3.0.2</findbugs.version>
<rootPath>${user.dir}</rootPath>
</properties>