You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@kylin.apache.org by "liyang (JIRA)" <ji...@apache.org> on 2017/10/08 08:18:00 UTC

[jira] [Commented] (KYLIN-2876) Ineffective check in ExternalAclProvider

    [ https://issues.apache.org/jira/browse/KYLIN-2876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16196015#comment-16196015 ] 

liyang commented on KYLIN-2876:
-------------------------------

The inited=true is right before the return, guarantees the flat is only set after a successful init. Do you still think this is problem?

{code}
            inited = true;
            return singleton;
{code}

> Ineffective check in ExternalAclProvider
> ----------------------------------------
>
>                 Key: KYLIN-2876
>                 URL: https://issues.apache.org/jira/browse/KYLIN-2876
>             Project: Kylin
>          Issue Type: Bug
>            Reporter: Ted Yu
>
> {code}
>         if (inited)
>             return singleton;
>         synchronized (ExternalAclProvider.class) {
>             if (inited)
>                 return singleton;
> {code}
> If one thread assigns inited but without initialization complete, another thread may read the value of inited being true and use the partial result.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)